linux-stable.git/net/mctp/test, branch linux-5.17.y

mctp: make __mctp_dev_get() take a refcount hold

2022-04-13T17:27:18+00:00

[ Upstream commit dc121c0084910db985cf1c8ba6fce5d8c307cc02 ]

Previously there was a race that could allow the mctp_dev refcount
to hit zero:

rcu_read_lock();
mdev = __mctp_dev_get(dev);
// mctp_unregister() happens here, mdev->refs hits zero
mctp_dev_hold(dev);
rcu_read_unlock();

Now we make __mctp_dev_get() take the hold itself. It is safe to test
against the zero refcount because __mctp_dev_get() is called holding
rcu_read_lock and mctp_dev uses kfree_rcu().

Reported-by: Jakub Kicinski 
Signed-off-by: Matt Johnston 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

mctp: test: zero out sockaddr

2022-01-12T04:26:36+00:00

MCTP now requires that padding bytes are zero.

Signed-off-by: Matt Johnston 
Fixes: 1e4b50f06d97 ("mctp: handle the struct sockaddr_mctp padding fields")
Link: https://lore.kernel.org/r/20220110021806.2343023-1-matt@codeconstruct.com.au
Signed-off-by: Jakub Kicinski

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2021-12-02T19:44:56+00:00

Signed-off-by: Jakub Kicinski

mctp: test: fix skb free in test device tx

2021-11-29T13:00:09+00:00

In our test device, we're currently freeing skbs in the transmit path
with kfree(), rather than kfree_skb(). This change uses the correct
kfree_skb() instead.

Fixes: ded21b722995 ("mctp: Add test utils")
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp/test: Update refcount checking in route fragment tests

2021-11-18T12:01:14+00:00

In 99ce45d5e, we moved a route refcount decrement from
mctp_do_fragment_route into the caller. This invalidates the assumption
that the route test makes about refcount behaviour, so the route tests
fail.

This change fixes the test case to suit the new refcount behaviour.

Fixes: 99ce45d5e7db ("mctp: Implement extended addressing")
Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Add input reassembly tests

2021-10-03T13:35:41+00:00

Add multi-packet route input tests, for message reassembly. These will
feed packets to be received by a bound socket, or dropped.

Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Add route input to socket tests

2021-10-03T13:35:41+00:00

Add a few tests for single-packet route inputs, testing the
mctp_route_input function.

Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Add packet rx tests

2021-10-03T13:35:41+00:00

Add a few tests for the initial packet ingress through
mctp_pkttype_receive function; mainly packet header sanity checks. Full
input routing checks will be added as a separate change.

Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Add test utils

2021-10-03T13:35:41+00:00

Add a new object for shared test utilities

Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller

mctp: Add initial test structure and fragmentation test

2021-10-03T13:35:41+00:00

This change adds the first kunit test for the mctp subsystem, and an
initial test for the fragmentation path.

We're adding tests under a new net/mctp/test/ directory.

Incorporates a fix for module configs:

Reported-by: kernel test robot 

Signed-off-by: Jeremy Kerr 
Signed-off-by: David S. Miller