linux-stable.git/net/mac802154, branch linux-4.3.y

ieee802154: add ack request default handling

2015-08-10T18:43:06+00:00

This patch introduce a new mib entry which isn't part of 802.15.4 but
useful as default behaviour to set the ack request bit or not if we
don't know if the ack request bit should set. This is currently used for
stacks like IEEE 802.15.4 6LoWPAN.

Reviewed-by: Stefan Schmidt 
Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: change frame_retries behaviour

2015-08-10T18:43:06+00:00

This patch changes the default minimum value of frame_retries to 0 and
changes the frame_retries default value to 3 which is also 802.15.4
default.

We don't use the frame_retries "-1" value as indicator for no-aret mode
anymore, instead we checking on the ack request bit inside the 802.15.4
frame control field. This allows a acknowledge handling per frame. This
checking is done by transceiver or inside xmit callback of driver layer.

If a transceiver doesn't support ARET handling the transmit
functionality ignores ack frames then, which isn't well but should not
effect anything of current functionality.

Reviewed-by: Stefan Schmidt 
Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: cfg: remove test and set checks

2015-08-10T18:43:06+00:00

This patch removes several checks if a value is really changed. This
makes only sense if we have another layer call e.g. calling the
driver_ops which is done by callbacks like "set_channel".

For MAC settings which need to be set by phy registers (if the phy
supports that handling) this is set by doing an interface up currently
and are not direct driver_ops calls, so we remove the checks from these
configuration callbacks.

Reviewed-by: Stefan Schmidt 
Suggested-by: Phoebe Buckheister 
Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: fix wpan mac setting while lowpan is there

2015-08-10T18:43:06+00:00

If we currently change the mac address inside the wpan interface while
we have a lowpan interface on top of the wpan interface, the mac address
setting doesn't reach the lowpan interface. The effect would be that the
IPv6 lowpan interface has the old SLAAC address and isn't working
anymore because the lowpan interface use in internal mechanism sometimes
dev->addr which is the old mac address of the wpan interface.

This patch checks if a wpan interface belongs to lowpan interface, if
yes then we need to check if the lowpan interface is down and change the
mac address also at the lowpan interface. When the lowpan interface will
be set up afterwards, it will use the correct SLAAC address which based
on the updated mac address setting.

Reviewed-by: Stefan Schmidt 
Tested-by: Stefan Schmidt 
Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: Fix memory corruption with global deferred transmit state.

2015-07-30T12:08:55+00:00

When transmitting a packet via a mac802154 driver that can sleep in
its transmit function, mac802154 defers the call to the driver's
transmit function to a per-device workqueue.

However, mac802154 uses a single global work_struct for this, which
means that if you have more than one registered mac802154 interface
in the system, and you transmit on more than one of them at the same
time, you'll very easily cause memory corruption.

This patch moves the deferred transmit processing state from global
variables to struct ieee802154_local, and this seems to fix the memory
corruption issue.

Signed-off-by: Lennert Buytenhek 
Acked-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: fix ieee802154_rx handling

2015-07-23T15:10:50+00:00

Instead of passing ieee802154_hw pointer to ieee802154_rx,
we can directly pass the ieee802154_local pointer.

Signed-off-by: Varka Bhadram 
Acked-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: do not export ieee802154_rx()

2015-07-23T15:10:50+00:00

Right now there are no other users for ieee802154_rx()
in kernel. So lets remove EXPORT_SYMBOL() for this.

Also it moves the function prototype from global header
file to local header file.

Signed-off-by: Varka Bhadram 
Acked-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: cfg: add suspend and resume callbacks

2015-07-23T15:10:49+00:00

This patch introduces suspend and resume callbacks to mac802154. When
doing suspend we calling the stop driver callback which should stop the
receiving of frames. A transceiver should go into low-power mode then.
Calling resume will call the start driver callback, which starts receiving
again and allow to transmit frames.

This was tested only with the fakelb driver and a qemu vm by doing the
following commands:

echo "devices" > /sys/power/pm_test
echo "freeze" > /sys/power/state

while doing some high traffic between two fakelb phys.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: util: add stop_device utility function

2015-07-23T15:10:49+00:00

This patch adds ieee802154_stop_device for preparing a utility function
to stop the ieee802154 device.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: remove unused macro

2015-07-23T15:10:48+00:00

This patch removes the unused macro which was removed
with the rework of linux-wpan kernel.

Signed-off-by: Varka Bhadram 
Signed-off-by: Marcel Holtmann