linux-stable.git/net/mac80211/debugfs_netdev.c, branch linux-4.9.y

mac80211: fix txq null pointer dereference

2019-10-29T08:15:03+00:00

[ Upstream commit 8ed31a264065ae92058ce54aa3cc8da8d81dc6d7 ]

If the interface type is P2P_DEVICE or NAN, read the file of
'/sys/kernel/debug/ieee80211/phyx/netdev:wlanx/aqm' will get a
NULL pointer dereference. As for those interface type, the
pointer sdata->vif.txq is NULL.

Unable to handle kernel NULL pointer dereference at virtual address 00000011
CPU: 1 PID: 30936 Comm: cat Not tainted 4.14.104 #1
task: ffffffc0337e4880 task.stack: ffffff800cd20000
PC is at ieee80211_if_fmt_aqm+0x34/0xa0 [mac80211]
LR is at ieee80211_if_fmt_aqm+0x34/0xa0 [mac80211]
[...]
Process cat (pid: 30936, stack limit = 0xffffff800cd20000)
[...]
[] ieee80211_if_fmt_aqm+0x34/0xa0 [mac80211]
[] ieee80211_if_read+0x60/0xbc [mac80211]
[] ieee80211_if_read_aqm+0x28/0x30 [mac80211]
[] full_proxy_read+0x2c/0x48
[] __vfs_read+0x2c/0xd4
[] vfs_read+0x8c/0x108
[] SyS_read+0x40/0x7c

Signed-off-by: Miaoqing Pan 
Acked-by: Toke Høiland-Jørgensen 
Link: https://lore.kernel.org/r/1569549796-8223-1-git-send-email-miaoqing@codeaurora.org
[trim useless data from commit message]
Signed-off-by: Johannes Berg 
Signed-off-by: Sasha Levin

mac80211: add offset_tsf driver op and use it for mesh

2016-09-30T11:45:44+00:00

This allows the mesh sync (and debugfs) code to make incremental
TSF adjustments, avoiding any uncertainty introduced by delay in
programming absolute TSF.

Signed-off-by: Thomas Pedersen 
Signed-off-by: Johannes Berg

mac80211: Re-structure aqm debugfs output and keep CoDel stats per txq

2016-09-13T06:20:16+00:00

Currently the 'aqm' stats in mac80211 only keeps overlimit drop stats,
not CoDel stats. This moves the CoDel stats into the txqi structure to
keep them per txq in order to show them in debugfs.

In addition, the aqm debugfs output is restructured by splitting it up
into three files: One global per phy, one per netdev and one per
station, in the appropriate directories. The files are all called aqm,
and are only created if the driver supports the wake_tx_queue op (rather
than emitting an error on open as previously).

Signed-off-by: Toke Høiland-Jørgensen 
Signed-off-by: Johannes Berg

cfg80211: remove enum ieee80211_band

2016-04-12T13:56:15+00:00

This enum is already perfectly aliased to enum nl80211_band, and
the only reason for it is that we get IEEE80211_NUM_BANDS out of
it. There's no really good reason to not declare the number of
bands in nl80211 though, so do that and remove the cfg80211 one.

Signed-off-by: Johannes Berg

mac80211: remove last_beacon/ave_beacon debugfs files

2015-09-22T13:21:25+00:00

These file aren't really useful:
 - if per beacon data is required then you need to use
   radiotap or similar anyway, debugfs won't help much
 - average beacon signal is reported in station info in
   nl80211 and can be looked up with iw

Signed-off-by: Johannes Berg

mac80211: debugfs: add file to disallow TDLS wider-bw

2015-09-22T13:21:21+00:00

Sometimes we are interested in testing TDLS performance in a specific
width setting. Add the ability to disable the wider-band feature, thereby
allowing the TDLS channel width to be controlled by the BSS width.

Signed-off-by: Arik Nemtsov 
Signed-off-by: Emmanuel Grumbach 
Signed-off-by: Johannes Berg

mac80211: add rate mask logic for vht rates

2015-08-14T15:49:51+00:00

Define rc_rateidx_vht_mcs_mask array and rate_idx_match_vht_mcs_mask()
method in order to apply mcs mask for vht rates

Signed-off-by: Lorenzo Bianconi 
Signed-off-by: Johannes Berg

mac80211: clear subdir_stations when removing debugfs

2015-07-17T08:53:19+00:00

If we don't do this, and we then fail to recreate the debugfs
directory during a mode change, then we will fail later trying
to add stations to this now bogus directory:

BUG: unable to handle kernel NULL pointer dereference at 0000006c
IP: [] mutex_lock+0x12/0x30
Call Trace:
[] start_creating+0x44/0xc0
[] debugfs_create_dir+0x13/0xf0
[] ieee80211_sta_debugfs_add+0x6e/0x490 [mac80211]

Cc: stable@kernel.org
Signed-off-by: Tom Hughes 
Signed-off-by: Johannes Berg

mac80211: remove drop_unencrypted code

2015-03-20T10:37:36+00:00

This mechanism was historic, and only ever used by IBSS, which
also doesn't need to have it as it properly manages station's
802.1X PAE state (or, with WEP, always has a key.)

Remove the mechanism to clean up the code.

Signed-off-by: Johannes Berg

mac80211: replace SMPS hw flags with wiphy feature bits

2014-09-11T11:37:02+00:00

Use the new static_smps / dynamic_smps feature bits
instead of mac80211-internal hw flags.

Signed-off-by: Eliad Peller 
Signed-off-by: Emmanuel Grumbach 
Signed-off-by: Johannes Berg