linux-stable.git/net/irda, branch v2.6.30

proc tty: switch ircomm to ->proc_fops

2009-04-01T15:59:10+00:00

Signed-off-by: Alexey Dobriyan 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc 2/2: remove struct proc_dir_entry::owner

2009-03-30T21:14:44+00:00

Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan

irlan: convert to net_device_ops

2009-03-22T02:19:16+00:00

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

irda: net_device_ops ioctl fix

2009-03-22T02:19:14+00:00

Need to reference net_device_ops not old pointer.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: convert usage of packet_type to read_mostly

2009-03-10T12:22:43+00:00

Protocols that use packet_type can be __read_mostly section for better
locality. Elminate any unnecessary initializations of NULL.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: replace uses of __constant_{endian}

2009-02-01T08:45:17+00:00

Base versions handle constant folding now.

Signed-off-by: Harvey Harrison 
Signed-off-by: David S. Miller

tty: Fix an ircomm warning and note another bug

2009-01-02T18:19:43+00:00

Roel Kluin noted that line is unsigned so one test is unneccessary. Also
add a warning for another flaw I noticed while making this change.

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

irda: merge exit paths

2008-12-15T07:18:30+00:00

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

net: Make static

2008-12-10T23:18:31+00:00

Sparse asked whether these could be static.

Signed-off-by: Roel Kluin 
Signed-off-by: David S. Miller

netdevice: safe convert to netdev_priv() #part-4

2008-11-13T07:39:10+00:00

We have some reasons to kill netdev->priv:
1. netdev->priv is equal to netdev_priv().
2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
   netdev_priv() is more flexible than netdev->priv.
But we cann't kill netdev->priv, because so many drivers reference to it
directly.

This patch is a safe convert for netdev->priv to netdev_priv(netdev).
Since all of the netdev->priv is only for read.
But it is too big to be sent in one mail.
I split it to 4 parts and make every part smaller than 100,000 bytes,
which is max size allowed by vger.

Signed-off-by: Wang Chen 
Signed-off-by: David S. Miller