linux-stable.git/net/ipv6/addrconf.c, branch linux-4.2.y

ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev

2015-12-09T19:31:06+00:00

[ Upstream commit 2a189f9e57650e9f310ddf4aad75d66c1233a064 ]

In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up
the dev_snmp6 entry that we have already registered for this device.
Call snmp6_unregister_dev in this case.

Fixes: a317a2f19da7d ("ipv6: fail early when creating netdev named all or default")
Reported-by: Dmitry Vyukov 
Signed-off-by: Sabrina Dubroca 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ipv6: Consider RTF_CACHE when searching the fib6 tree

2015-05-02T00:57:06+00:00

It is a prep work for the later bug-fix patch which will stop /128 route
from disappearing after pmtu update.

The later bug-fix patch will allow a /128 route and its RTF_CACHE clone
both exist at the same fib6_node.  To do this, we need to prepare the
existing fib6 tree search to expect RTF_CACHE for /128 route.

Note that the fn->leaf is sorted by rt6i_metric.  Hence,
RTF_CACHE (if there is any) is always at the front.  This property
leads to the following:

1. When doing ip6_route_del(), it should honor the RTF_CACHE flag which
   the caller is used to ask for deleting clone or non-clone.
   The rtm_to_fib6_config() should also check the RTM_F_CLONED and
   then set RTF_CACHE accordingly so that:
   - 'ip -6 r del...' will make ip6_route_del() to delete a route
     and all its clones. Note that its clones is flushed by fib6_del()
   - 'ip -6 r flush table cache' will make ip6_route_del() to
      only delete clone(s).

2. Exclude RTF_CACHE from addrconf_get_prefix_route() which
   should not configure on a cloned route.

3. No change is need for rt6_device_match() since it currently could
   return a RTF_CACHE clone route, so the later bug-fix patch will not
   affect it.

Signed-off-by: Martin KaFai Lau 
Reviewed-by: Hannes Frederic Sowa 
Cc: Steffen Klassert 
Signed-off-by: David S. Miller

dev: introduce dev_get_iflink()

2015-04-02T18:04:59+00:00

The goal of this patch is to prepare the removal of the iflink field. It
introduces a new ndo function, which will be implemented by virtual interfaces.

There is no functional change into this patch. All readers of iflink field
now call dev_get_iflink().

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

netlink: implement nla_put_in_addr and nla_put_in6_addr

2015-03-31T17:58:35+00:00

IP addresses are often stored in netlink attributes. Add generic functions
to do that.

For nla_put_in_addr, it would be nicer to pass struct in_addr but this is
not used universally throughout the kernel, in way too many places __be32 is
used to store IPv4 address.

Signed-off-by: Jiri Benc 
Signed-off-by: David S. Miller

ipv6: coding style: comparison for equality with NULL

2015-03-31T17:51:54+00:00

The ipv6 code uses a mixture of coding styles. In some instances check for NULL
pointer is done as x == NULL and sometimes as !x. !x is preferred according to
checkpatch and this patch makes the code consistent by adopting the latter
form.

No changes detected by objdiff.

Signed-off-by: Ian Morris 
Signed-off-by: David S. Miller

ipv6: fix sparse warnings in privacy stable addresses generation

2015-03-24T19:21:35+00:00

Those warnings reported by sparse endianness check (via kbuild test robot)
are harmless, nevertheless fix them up and make the code a little bit
easier to read.

Reported-by: kbuild test robot 
Fixes: 622c81d57b392cc ("ipv6: generation of stable privacy addresses for link-local and autoconf")
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller

ipv6: introduce idgen_delay and idgen_retries knobs

2015-03-24T02:12:09+00:00

This is specified by RFC 7217.

Cc: Erik Kline 
Cc: Fernando Gont 
Cc: Lorenzo Colitti 
Cc: YOSHIFUJI Hideaki/吉藤英明 
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller

ipv6: do retries on stable privacy addresses

2015-03-24T02:12:09+00:00

If a DAD conflict is detected, we want to retry privacy stable address
generation up to idgen_retries (= 3) times with a delay of idgen_delay
(= 1 second). Add the logic to addrconf_dad_failure.

By design, we don't clean up dad failed permanent addresses.

Cc: Erik Kline 
Cc: Fernando Gont 
Cc: Lorenzo Colitti 
Cc: YOSHIFUJI Hideaki/吉藤英明 
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller

ipv6: collapse state_lock and lock

2015-03-24T02:12:09+00:00

Cc: Erik Kline 
Cc: Fernando Gont 
Cc: Lorenzo Colitti 
Cc: YOSHIFUJI Hideaki/吉藤英明 
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller

ipv6: introduce IFA_F_STABLE_PRIVACY flag

2015-03-24T02:12:09+00:00

We need to mark appropriate addresses so we can do retries in case their
DAD failed.

Cc: Erik Kline 
Cc: Fernando Gont 
Cc: Lorenzo Colitti 
Cc: YOSHIFUJI Hideaki/吉藤英明 
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller