linux-stable.git/net/ipv4/ipconfig.c, branch linux-3.19.y

ipv4: remove 0/NULL assignment on static

2014-11-04T20:09:52+00:00

static values are automatically initialized to 0

Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

ipv4: remove set but unused variable sha

2014-10-27T20:03:52+00:00

unsigned char *sha (source) was already in original git version
 but was never used.

Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

ipconfig: Use time_before

2014-08-22T19:23:11+00:00

The functions time_before, time_before_eq, time_after, and time_after_eq
are more robust for comparing jiffies against other values.

A simplified version of the Coccinelle semantic patch making this change
is as follows:

@change@
expression E1,E2;
@@
- jiffies - E1 < E2
+ time_before(jiffies, E1+E2)

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Signed-off-by: David S. Miller

ipconfig: Only bootp paths should reference ic_dev_xid.

2014-07-10T05:25:18+00:00

It is only tested, and declared, in the bootp code.

So, in ic_dynamic() guard it's setting with IPCONFIG_BOOTP.

Signed-off-by: David S. Miller

ipconfig: move ic_dev_xid under IPCONFIG_BOOTP

2014-07-09T21:32:54+00:00

ic_dev_xid is only used in __init ic_bootp_recv under IPCONFIG_BOOTP
and __init ic_dynamic under IPCONFIG_DYNAMIC(which is itself defined
with the same IPCONFIG_BOOTP)

This patch fixes the following warning when IPCONFIG_BOOTP is not set:
>> net/ipv4/ipconfig.c:146:15: warning: 'ic_dev_xid' defined but not used [-Wunused-variable]
    static __be32 ic_dev_xid;  /* Device under configuration */

Reported-by: Fengguang Wu 
Cc: Fengguang Wu 
Cc: "David S. Miller" 
Cc: Alexey Kuznetsov 
Cc: netdev@vger.kernel.org
Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

ipconfig: add static to local variable

2014-07-08T18:30:33+00:00

ic_dev_xid is only used in ipconfig.c

Cc: "David S. Miller" 
Cc: Alexey Kuznetsov 
Cc: netdev@vger.kernel.org
Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

ipv4: ipconfig.c: add parentheses in an if statement

2014-02-14T05:14:23+00:00

Even if the 'time_before' macro expand with parentheses, the look is bad.

Signed-off-by: Francois-Xavier Le Bail 
Signed-off-by: David S. Miller

ipconfig: add informative timeout messages while waiting for carrier

2013-04-02T18:35:33+00:00

Commit 3fb72f1e6e6165c5f495e8dc11c5bbd14c73385c ("ipconfig wait
for carrier") added a "wait for carrier on at least one interface"
policy, with a worst case maximum wait of two minutes.

However, if you encounter this, you won't get any feedback from
the console as to the nature of what is going on.  You just see
the booting process hang for two minutes and then continue.

Here we add a message so the user knows what is going on, and
hence can take action to rectify the situation (e.g. fix network
cable or whatever.)  After the 1st 10s pause, output now begins
that looks like this:

	Waiting up to 110 more seconds for network.
	Waiting up to 100 more seconds for network.
	Waiting up to 90 more seconds for network.
	Waiting up to 80 more seconds for network.
	...

Since most systems will have no problem getting link/carrier in the
1st 10s, the only people who will see these messages are people with
genuine issues that need to be resolved.

Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

ipconfig: Fix newline handling in log message.

2013-03-20T16:15:58+00:00

When using ipconfig the logs currently look like:

Single name server:
[    3.467270] IP-Config: Complete:
[    3.470613]      device=eth0, hwaddr=ac:de:48:00:00:01, ipaddr=172.16.42.2, mask=255.255.255.0, gw=172.16.42.1
[    3.480670]      host=infigo-1, domain=, nis-domain=(none)
[    3.486166]      bootserver=172.16.42.1, rootserver=172.16.42.1, rootpath=
[    3.492910]      nameserver0=172.16.42.1[    3.496853] ALSA device list:

Three name servers:
[    3.496949] IP-Config: Complete:
[    3.500293]      device=eth0, hwaddr=ac:de:48:00:00:01, ipaddr=172.16.42.2, mask=255.255.255.0, gw=172.16.42.1
[    3.510367]      host=infigo-1, domain=, nis-domain=(none)
[    3.515864]      bootserver=172.16.42.1, rootserver=172.16.42.1, rootpath=
[    3.522635]      nameserver0=172.16.42.1, nameserver1=172.16.42.100
[    3.529149] , nameserver2=172.16.42.200

Fix newline handling for these cases

Signed-off-by: Martin Fuzzey 
Signed-off-by: David S. Miller

net: proc: change proc_net_fops_create to proc_create

2013-02-18T19:53:08+00:00

Right now, some modules such as bonding use proc_create
to create proc entries under /proc/net/, and other modules
such as ipv4 use proc_net_fops_create.

It looks a little chaos.this patch changes all of
proc_net_fops_create to proc_create. we can remove
proc_net_fops_create after this patch.

Signed-off-by: Gao feng 
Signed-off-by: David S. Miller