linux-stable.git/net/ipv4/datagram.c, branch v3.2

ipv4: Lock socket and use cork flow in ip4_datagram_connect().

2011-05-08T20:48:57+00:00

This is to make sure that an l2tp socket's inet cork flow is
fully filled in, when it's encapsulated in UDP.

Signed-off-by: David S. Miller

ipv4: Get route daddr from flow key in ip4_datagram_connect().

2011-04-29T06:49:45+00:00

Now that output route lookups update the flow with
destination address selection, we can fetch it from
fl4->daddr instead of rt->rt_dst

Signed-off-by: David S. Miller

ipv4: Fetch route saddr from flow key in ip4_datagram_connect().

2011-04-29T06:17:16+00:00

Now that output route lookups update the flow with
source address selection, we can fetch it from
fl4->saddr instead of rt->rt_src

Signed-off-by: David S. Miller

ipv4: Sanitize and simplify ip_route_{connect,newports}()

2011-04-27T20:59:04+00:00

These functions are used together as a unit for route resolution
during connect().  They address the chicken-and-egg problem that
exists when ports need to be allocated during connect() processing,
yet such port allocations require addressing information from the
routing code.

It's currently more heavy handed than it needs to be, and in
particular we allocate and initialize a flow object twice.

Let the callers provide the on-stack flow object.  That way we only
need to initialize it once in the ip_route_connect() call.

Later, if ip_route_newports() needs to do anything, it re-uses that
flow object as-is except for the ports which it updates before the
route re-lookup.

Also, describe why this set of facilities are needed and how it works
in a big comment.

Signed-off-by: David S. Miller 
Reviewed-by: Eric Dumazet

ipv4: Make output route lookup return rtable directly.

2011-03-02T22:31:35+00:00

Instead of on the stack.

Signed-off-by: David S. Miller

ipv4: Can final ip_route_connect() arg to boolean "can_sleep".

2011-03-01T22:15:24+00:00

Since that's what the current vague "flags" thing means.

Signed-off-by: David S. Miller

net: return operator cleanup

2010-09-23T21:33:39+00:00

Change "return (EXPR);" to "return EXPR;"

return is not a function, parentheses are not required.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

udp: add rehash on connect()

2010-09-09T04:45:01+00:00

commit 30fff923 introduced in linux-2.6.33 (udp: bind() optimisation)
added a secondary hash on UDP, hashed on (local addr, local port).

Problem is that following sequence :

fd = socket(...)
connect(fd, &remote, ...)

not only selects remote end point (address and port), but also sets
local address, while UDP stack stored in secondary hash table the socket
while its local address was INADDR_ANY (or ipv6 equivalent)

Sequence is :
 - autobind() : choose a random local port, insert socket in hash tables
              [while local address is INADDR_ANY]
 - connect() : set remote address and port, change local address to IP
              given by a route lookup.

When an incoming UDP frame comes, if more than 10 sockets are found in
primary hash table, we switch to secondary table, and fail to find
socket because its local address changed.

One solution to this problem is to rehash datagram socket if needed.

We add a new rehash(struct socket *) method in "struct proto", and
implement this method for UDP v4 & v6, using a common helper.

This rehashing only takes care of secondary hash table, since primary
hash (based on local port only) is not changed.

Reported-by: Krzysztof Piotr Oledzki 
Signed-off-by: Eric Dumazet 
Tested-by: Krzysztof Piotr Oledzki 
Signed-off-by: David S. Miller

net/ipv4: EXPORT_SYMBOL cleanups

2010-07-12T19:57:54+00:00

CodingStyle cleanups

EXPORT_SYMBOL should immediately follow the symbol declaration.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net-next: remove useless union keyword

2010-06-11T06:31:35+00:00

remove useless union keyword in rtable, rt6_info and dn_route.

Since there is only one member in a union, the union keyword isn't useful.

Signed-off-by: Changli Gao 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller