linux-stable.git/net/hsr, branch v3.14

hsr: off by one sanity check in hsr_register_frame_in()

2014-03-03T20:29:42+00:00

This is a sanity check and we never pass invalid values so this patch
doesn't change anything.  However the node->time_in[] array has
HSR_MAX_SLAVE (2) elements and not HSR_MAX_DEV (3).

Signed-off-by: Dan Carpenter 
Signed-off-by: David S. Miller

net/hsr: using kfree_rcu() to simplify the code

2013-12-17T21:32:30+00:00

The callback function of call_rcu() just calls a kfree(), so we
can use kfree_rcu() instead of call_rcu() + callback function.

Signed-off-by: Wei Yongjun 
Acked-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Support iproute print_opt ('ip -details ...')

2013-11-30T17:48:14+00:00

This implements the rtnl_link_ops fill_info routine for HSR.

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Very small fix of comment style.

2013-11-30T17:48:13+00:00

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

genetlink: make multicast groups const, prevent abuse

2013-11-19T21:39:06+00:00

Register generic netlink multicast groups as an array with
the family and give them contiguous group IDs. Then instead
of passing the global group ID to the various functions that
send messages, pass the ID relative to the family - for most
families that's just 0 because the only have one group.

This avoids the list_head and ID in each group, adding a new
field for the mcast group ID offset to the family.

At the same time, this allows us to prevent abusing groups
again like the quota and dropmon code did, since we can now
check that a family only uses a group it owns.

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

genetlink: pass family to functions using groups

2013-11-19T21:39:06+00:00

This doesn't really change anything, but prepares for the
next patch that will change the APIs to pass the group ID
within the family, rather than the global group ID.

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

hsr: don't call genl_unregister_mc_group()

2013-11-19T21:39:06+00:00

There's no need to unregister the multicast group if the
generic netlink family is registered immediately after.

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

genetlink: only pass array to genl_register_family_with_ops()

2013-11-19T21:39:05+00:00

As suggested by David Miller, make genl_register_family_with_ops()
a macro and pass only the array, evaluating ARRAY_SIZE() in the
macro, this is a little safer.

The openvswitch has some indirection, assing ops/n_ops directly in
that code. This might ultimately just assign the pointers in the
family initializations, saving the struct genl_family_and_ops and
code (once mcast groups are handled differently.)

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

net/hsr: Fix possible leak in 'hsr_get_node_status()'

2013-11-14T22:26:21+00:00

If 'hsr_get_node_data()' returns error, going directly to 'fail' label
doesn't free the memory pointed by 'skb_out'.

Signed-off-by: Geyslan G. Bem 
Signed-off-by: David S. Miller

genetlink: make all genl_ops users const

2013-11-14T22:10:41+00:00

Now that genl_ops are no longer modified in place when
registering, they can be made const. This patch was done
mostly with spatch:

@@
identifier ops;
@@
+const
 struct genl_ops ops[] = {
 ...
 };

(except the struct thing in net/openvswitch/datapath.c)

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller