linux-stable.git/net/hsr, branch linux-3.19.y

net/hsr: Remove left-over never-true conditional code.

2014-07-11T22:04:40+00:00

MacAddressB is an array (unsigned char MacAddressB[ETH_ALEN]) and is allocated
as a part of *node_dst (which is a struct hsr_node). So the condition is always
false.

Detected by Dan Carpenter.

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Fix NULL pointer dereference on incomplete hsr_newlink() params.

2014-07-08T18:35:31+00:00

If none of the slave interfaces are specified, struct nlattr *data[] may
be NULL. Make sure to check for that.

While I'm at it, fix the horrible error messages displayed when only one
of the slave interfaces isn't specified.

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Better frame dispatch

2014-07-08T18:35:31+00:00

This patch removes the separate paths for frames coming from the outside, and
frames sent from the HSR device, and instead makes all frames go through
hsr_forward_skb() in hsr_forward.c. This greatly improves code readability and
also opens up the possibility for future support of the HSR Interlink device
that is the basis for HSR RedBoxes and HSR QuadBoxes, as well as VLAN
compatibility.

Other improvements:
* A reduction in the number of times an skb is copied on machines without
  HAVE_EFFICIENT_UNALIGNED_ACCESS, which improves throughput somewhat.
* Headers are now created using the standard eth_header(), and using the
  standard hard_header_len.
* Each HSR slave now gets its own private skb, so slave-specific fields can be
  correctly set.

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Added SET_NETDEV_DEVTYPE and features |= NETIF_F_NETNS_LOCAL to dev_setup.

2014-07-08T18:35:31+00:00

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Implemented .ndo_fix_features (better device features handling).

2014-07-08T18:35:31+00:00

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Use list_head (and rcu) instead of array for slave devices.

2014-07-08T18:35:31+00:00

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Move slave init to hsr_slave.c.

2014-07-08T18:35:31+00:00

Also try to prevent some possible slave dereference race conditions. This is
finalized in the next patch, which abandons the slave array in favour of
a list_head list and list RCU.

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Operstate handling cleanup.

2014-07-08T18:35:30+00:00

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Move to per-hsr device prune timer.

2014-07-08T18:35:30+00:00

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller

net/hsr: Switch from dev_add_pack() to netdev_rx_handler_register()

2014-07-08T18:35:30+00:00

Also move the frame receive handler to hsr_slave.c.

Signed-off-by: Arvid Brodin 
Signed-off-by: David S. Miller