linux-stable.git/net/ethtool/netlink.c, branch linux-5.6.y

ethtool: count header size in reply size estimate

2020-06-03T06:22:38+00:00

[ Upstream commit 7c87e32d2e380228ada79d20ac5b7674718ef097 ]

As ethnl_request_ops::reply_size handlers do not include common header
size into calculated/estimated reply size, it needs to be added in
ethnl_default_doit() and ethnl_default_notify() before allocating the
message. On the other hand, strset_reply_size() should not add common
header size.

Fixes: 728480f12442 ("ethtool: default handlers for GET requests")
Reported-by: Oleksij Rempel 
Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ethtool: reject unrecognized request flags

2020-03-16T09:04:24+00:00

As pointed out by Jakub Kicinski, we ethtool netlink code should respond
with an error if request head has flags set which are not recognized by
kernel, either as a mistake or because it expects functionality introduced
in later kernel versions.

To avoid unnecessary roundtrips, use extack cookie to provide the
information about supported request flags.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: add WOL_NTF notification

2020-01-27T10:31:36+00:00

Send ETHTOOL_MSG_WOL_NTF notification whenever wake-on-lan settings of
a device are modified using ETHTOOL_MSG_WOL_SET netlink message or
ETHTOOL_SWOL ioctl request.

As notifications can be received by anyone, do not include SecureOn(tm)
password in notification messages.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: set wake-on-lan settings with WOL_SET request

2020-01-27T10:31:36+00:00

Implement WOL_SET netlink request to set wake-on-lan settings. This is
equivalent to ETHTOOL_SWOL ioctl request.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: provide WoL settings with WOL_GET request

2020-01-27T10:31:36+00:00

Implement WOL_GET request to get wake-on-lan settings for a device,
traditionally available via ETHTOOL_GWOL ioctl request.

As part of the implementation, provide symbolic names for wake-on-line
modes as ETH_SS_WOL_MODES string set.

Signed-off-by: Michal Kubecek 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

ethtool: add DEBUG_NTF notification

2020-01-27T10:31:36+00:00

Send ETHTOOL_MSG_DEBUG_NTF notification message whenever debugging message
mask for a device are modified using ETHTOOL_MSG_DEBUG_SET netlink message
or ETHTOOL_SMSGLVL ioctl request.

The notification message has the same format as reply to DEBUG_GET request.
As with other ethtool notifications, netlink requests only trigger the
notification if the mask is actually changed while ioctl request trigger it
whenever the request results in calling the ethtool_ops handler.

Signed-off-by: Michal Kubecek 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

ethtool: set message mask with DEBUG_SET request

2020-01-27T10:31:35+00:00

Implement DEBUG_SET netlink request to set debugging settings for a device.
At the moment, only message mask corresponding to message level as set by
ETHTOOL_SMSGLVL ioctl request can be set. (It is called message level in
ioctl interface but almost all drivers interpret it as a bit mask.)

Signed-off-by: Michal Kubecek 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

ethtool: provide message mask with DEBUG_GET request

2020-01-27T10:31:35+00:00

Implement DEBUG_GET request to get debugging settings for a device. At the
moment, only message mask corresponding to message level as reported by
ETHTOOL_GMSGLVL ioctl request is provided. (It is called message level in
ioctl interface but almost all drivers interpret it as a bit mask.)

As part of the implementation, provide symbolic names for message mask bits
as ETH_SS_MSG_CLASSES string set.

Signed-off-by: Michal Kubecek 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

ethtool: fix kernel-doc descriptions

2020-01-27T10:31:35+00:00

Fix missing or incorrect function argument and struct member descriptions.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: fix ->reply_size() error handling

2020-01-09T00:03:35+00:00

The "ret < 0" comparison is never true because "ret" is still zero.

Fixes: 728480f12442 ("ethtool: default handlers for GET requests")
Signed-off-by: Dan Carpenter 
Reviewed-by: Michal Kubecek 
Signed-off-by: David S. Miller