linux-stable.git/net/ethtool/ioctl.c, branch linux-5.7.y

ethtool: Fix check in ethtool_rx_flow_rule_create

2020-06-30T19:35:45+00:00

[ Upstream commit 21a739c64d3e9871186483a0cc3e7b52638c3d59 ]

Fix check in ethtool_rx_flow_rule_create

Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")
Signed-off-by: Gaurav Singh 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ethtool: provide timestamping information with TSINFO_GET request

2020-03-30T05:32:37+00:00

Implement TSINFO_GET request to get timestamping information for a network
device. This is traditionally available via ETHTOOL_GET_TS_INFO ioctl
request.

Move part of ethtool_get_ts_info() into common.c so that ioctl and netlink
code use the same logic to get timestamping information from the device.

v3: use "TSINFO" rather than "TIMESTAMP", suggested by Richard Cochran

Signed-off-by: Michal Kubecek 
Acked-by: Richard Cochran 
Signed-off-by: David S. Miller

ethtool: add EEE_NTF notification

2020-03-30T05:32:36+00:00

Send ETHTOOL_MSG_EEE_NTF notification whenever EEE settings of a network
device are modified using ETHTOOL_MSG_EEE_SET netlink message or
ETHTOOL_SEEE ioctl request.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: add PAUSE_NTF notification

2020-03-30T05:32:36+00:00

Send ETHTOOL_MSG_PAUSE_NTF notification whenever pause parameters of
a network device are modified using ETHTOOL_MSG_PAUSE_SET netlink message
or ETHTOOL_SPAUSEPARAM ioctl request.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: add COALESCE_NTF notification

2020-03-30T05:32:36+00:00

Send ETHTOOL_MSG_COALESCE_NTF notification whenever coalescing parameters
of a network device are modified using ETHTOOL_MSG_COALESCE_SET netlink
message or ETHTOOL_SCOALESCE ioctl request.

Signed-off-by: Michal Kubecek 
Reviewed-by: Jakub Kicinski 
Signed-off-by: David S. Miller

ethtool: fix incorrect tx-checksumming settings reporting

2020-03-24T23:25:11+00:00

Currently, ethtool feature mask for checksum command is ORed with
NETIF_F_FCOE_CRC_BIT, which is bit's position number, instead of the
actual feature bit - NETIF_F_FCOE_CRC.

The invalid bitmask here might affect unrelated features when toggling
TX checksumming. For example, TX checksumming is always mistakenly
reported as enabled on the netdevs tested (mlx5, virtio_net).

Fixes: f70bb06563ed ("ethtool: update mapping of features to legacy ioctl requests")
Signed-off-by: Vladyslav Tarasiuk 
Reviewed-by: Michal Kubecek 
Signed-off-by: David S. Miller

net: ethtool: require drivers to set supported_coalesce_params

2020-03-18T03:56:58+00:00

Now that all in-tree drivers have been updated we can
make the supported_coalesce_params mandatory.

To save debugging time in case some driver was missed
(or is out of tree) add a warning when netdev is registered
with set_coalesce but without supported_coalesce_params.

Signed-off-by: Jakub Kicinski 
Reviewed-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: add CHANNELS_NTF notification

2020-03-12T22:32:33+00:00

Send ETHTOOL_MSG_CHANNELS_NTF notification whenever channel counts of
a network device are modified using ETHTOOL_MSG_CHANNELS_SET netlink
message or ETHTOOL_SCHANNELS ioctl request.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: set device channel counts with CHANNELS_SET request

2020-03-12T22:32:33+00:00

Implement CHANNELS_SET netlink request to set channel counts of a network
device. These are traditionally set with ETHTOOL_SCHANNELS ioctl request.

Like the ioctl implementation, the generic ethtool code checks if supplied
values do not exceed driver defined limits; if they do, first offending
attribute is reported using extack. Checks preventing removing channels
used for RX indirection table or zerocopy AF_XDP socket are also
implemented.

Move ethtool_get_max_rxfh_channel() helper into common.c so that it can be
used by both ioctl and netlink code.

v2:
  - fix netdev reference leak in error path (found by Jakub Kicinsky)

Signed-off-by: Michal Kubecek 
Reviewed-by: Jakub Kicinski 
Signed-off-by: David S. Miller

ethtool: add RINGS_NTF notification

2020-03-12T22:32:33+00:00

Send ETHTOOL_MSG_RINGS_NTF notification whenever ring sizes of a network
device are modified using ETHTOOL_MSG_RINGS_SET netlink message or
ETHTOOL_SRINGPARAM ioctl request.

Signed-off-by: Michal Kubecek 
Signed-off-by: David S. Miller