linux-stable.git/net/dsa, branch linux-4.5.y

net: dsa: Fix cleanup resources upon module removal

2016-04-20T06:45:10+00:00

[ Upstream commit 04761890a7cec6a1ff9aafd909004da4fe8059db ]

The initial commit badly merged into the dsa_resume method instead
of the dsa_remove_dst method.
As consequence, the dst->master_netdev->dsa_ptr is not set to NULL on
removal and re-bind of the dsa device fails with error -17.

Fixes: b0dc635d923c ("net: dsa: cleanup resources upon module removal ")
Signed-off-by: Neil Armstrong 
Acked-by: Andrew Lunn 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net: dsa: Unregister slave_dev in error path

2016-02-18T03:05:16+00:00

With commit 0071f56e46da ("dsa: Register netdev before phy"), we are now trying
to free a network device that has been previously registered, and in case of
errors, this will make us hit the BUG_ON(dev->reg_state != NETREG_UNREGISTERED)
condition.

Fix this by adding a missing unregister_netdev() before free_netdev().

Fixes: 0071f56e46da ("dsa: Register netdev before phy")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: remove phy_disconnect from error path

2016-02-16T21:04:08+00:00

The phy has not been initialized, disconnecting it in the error
path results in a NULL pointer exception. Drop the phy_disconnect
from the error path.

Signed-off-by: Sascha Hauer 
Reviewed-by: Andrew Lunn 
Acked-by: Neil Armstrong 
Signed-off-by: David S. Miller

dsa: Register netdev before phy

2016-01-07T19:31:26+00:00

When the phy is connected, an info message is printed. If the netdev
it is attached to has not been registered yet, the name
'uninitialised' in the output. By registering the netdev first, then
connecting they phy, we can avoid this.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

phy: Add API for {un}registering an mdio device to a bus.

2016-01-07T19:31:26+00:00

Rather than have drivers directly manipulate the mii_bus structure,
provide and API for registering and unregistering devices on an MDIO
bus, and performing lookups.

Signed-off-by: Andrew Lunn 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

phy: Add an mdio_device structure

2016-01-07T19:31:26+00:00

Not all devices attached to an MDIO bus are phys. So add an
mdio_device structure to represent the generic parts of an mdio
device, and place this structure into the phy_device.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

phy: Centralise print about attached phy

2016-01-07T19:31:25+00:00

Many Ethernet drivers contain the same netdev_info() print statement
about the attached phy. Move it into the phy device code. Additionally
add a varargs function which can be used to append additional
information.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: move dsa slave destroy code to slave.c

2015-12-07T21:35:50+00:00

Move dsa slave dedicated code from dsa_switch_destroy to a new
dsa_slave_destroy function in slave.c.
Add the netif_carrier_off and phy_disconnect calls in order to
correctly cleanup the netdev state and PHY state machine.

Signed-off-by: Frode Isaksen 
Signed-off-by: Neil Armstrong 
Signed-off-by: David S. Miller

net: dsa: Add missing master netdev dev_put() calls

2015-12-07T21:35:50+00:00

Upon probe failure or unbinding, add missing dev_put() calls.

Signed-off-by: Neil Armstrong 
Signed-off-by: David S. Miller

net: dsa: cleanup resources upon module removal

2015-12-07T21:35:50+00:00

Make sure that we unassign the master_netdev dsa_ptr to make the packet
processing go through the regular Ethernet receive path.

Suggested-by: Florian Fainelli 
Signed-off-by: Neil Armstrong 
Signed-off-by: David S. Miller