linux-stable.git/net/dsa/slave.c, branch linux-4.7.y

dsa: Rename switch chip data to cd

2016-05-11T23:36:28+00:00

The dsa_switch structure contains a dsa_chip_data member called pd.
However in the rest of the code, pd is used for dsa_platform_data.
This is confusing. Rename it cd, which is already often used in dsa.c
and slave.c for this data type.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: Remove master_dev from switch structure

2016-05-11T23:36:28+00:00

The switch drivers only use the master_dev member for dev_info()
messages.  Now that the device is passed to the old style probe, and
new style drivers are probed as true linux drivers, this is no longer
needed.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: dsa: Provide CPU port statistics to master netdev

2016-04-28T21:16:17+00:00

This patch overloads the DSA master netdev, aka CPU Ethernet MAC to also
include switch-side statistics, which is useful for debugging purposes,
when the switch is not properly connected to the Ethernet MAC (duplex
mismatch, (RG)MII electrical issues etc.).

We accomplish this by retaining the original copy of the master netdev's
ethtool_ops, and just overload the 3 operations we care about:
get_sset_count, get_strings and get_ethtool_stats so as to intercept
these calls and call into the original master_netdev ethtool_ops, plus
our own.

We take this approach as opposed to providing a set of DSA helper
functions that would retrive the CPU port's statistics, because the
entire purpose of DSA is to allow unmodified Ethernet MAC drivers to be
used as CPU conduit interfaces, therefore, statistics overlay in such
drivers would simply not scale.

The new ethtool -S  output would therefore look like this now:
 statistics
p<2 digits cpu port number>_

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: kill circular reference with slave priv

2016-04-20T00:28:49+00:00

The dsa_slave_priv structure does not need a pointer to its net_device.
Kill it.

Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: make the VLAN add function return void

2016-04-08T20:50:41+00:00

The switchdev design implies that a software error should not happen in
the commit phase since it must have been previously reported in the
prepare phase. If an hardware error occurs during the commit phase,
there is nothing switchdev can do about it.

The DSA layer separates port_vlan_prepare and port_vlan_add for
simplicity and convenience. If an hardware error occurs during the
commit phase, there is no need to report it outside the driver itself.

Make the DSA port_vlan_add routine return void for explicitness.

Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: make the FDB add function return void

2016-04-08T20:50:40+00:00

The switchdev design implies that a software error should not happen in
the commit phase since it must have been previously reported in the
prepare phase. If an hardware error occurs during the commit phase,
there is nothing switchdev can do about it.

The DSA layer separates port_fdb_prepare and port_fdb_add for simplicity
and convenience. If an hardware error occurs during the commit phase,
there is no need to report it outside the DSA driver itself.

Make the DSA port_fdb_add routine return void for explicitness.

Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: make the STP state function return void

2016-04-08T20:50:40+00:00

The DSA layer doesn't care about the return code of the port_stp_update
routine, so make it void in the layer and the DSA drivers.

Replace the useless dsa_slave_stp_update function with a
dsa_slave_stp_state function used to reply to the switchdev
SWITCHDEV_ATTR_ID_PORT_STP_STATE attribute.

In the meantime, rename port_stp_update to port_stp_state_set to
explicit the state change.

Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller

net: dsa: refine netdev event notifier

2016-03-14T20:05:32+00:00

Rework the netdev event handler, similar to what the Mellanox Spectrum
driver does, to easily welcome more events later (for example
NETDEV_PRECHANGEUPPER) and use netdev helpers (such as
netif_is_bridge_master).

Signed-off-by: Vivien Didelot 
Acked-by: Jiri Pirko 
Acked-by: Ido Schimmel 
Signed-off-by: David S. Miller

net: dsa: make port_bridge_leave return void

2016-03-14T20:05:31+00:00

netdev_upper_dev_unlink() which notifies NETDEV_CHANGEUPPER, returns
void, as well as del_nbp(). So there's no advantage to catch an eventual
error from the port_bridge_leave routine at the DSA level.

Make this routine void for the DSA layer and its existing drivers.

Signed-off-by: Vivien Didelot 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: dsa: rename port_*_bridge routines

2016-03-14T20:05:31+00:00

Rename DSA port_join_bridge and port_leave_bridge routines to
respectively port_bridge_join and port_bridge_leave in order to respect
an implicit Port::Bridge namespace.

Signed-off-by: Vivien Didelot 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller