linux-stable.git/net/dsa/slave.c, branch linux-4.2.y

net: dsa: fix preparation of a port STP update

2015-10-27T00:53:35+00:00

[ Upstream commit 57a47532c4312159935c98b7f1cf0e62296b9171 ]

Because of the default 0 value of ret in dsa_slave_port_attr_set, a
driver may return -EOPNOTSUPP from the commit phase of a STP state,
which triggers a WARN() from switchdev.

This happened on a 6185 switch which does not support hardware bridging.

Fixes: 3563606258cf ("switchdev: convert STP update to switchdev attr set")
Reported-by: Andrew Lunn 
Signed-off-by: Vivien Didelot 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net: dsa: Do not override PHY interface if already configured

2015-08-12T21:29:50+00:00

In case we need to divert reads/writes using the slave MII bus, we may have
already fetched a valid PHY interface property from Device Tree, and that
mode is used by the PHY driver to make configuration decisions.

If we could not fetch the "phy-mode" property, we will assign p->phy_interface
to PHY_INTERFACE_MODE_NA, such that we can actually check for that condition as
to whether or not we should override the interface value.

Fixes: 19334920eaf7 ("net: dsa: Set valid phy interface type")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

dsa: fix promiscuity leak on slave dev open error

2015-06-28T23:57:08+00:00

DSA master netdev promiscuity counter was not being properly
decremented on slave device open error path.

Signed-off-by: Gilad Ben-Yossef 
CC: Gilad Ben-Yossef 
CC: David S. Miller 
CC: Florian Fainelli 
CC: Guenter Roeck 
CC: Andrew Lunn 
CC: Scott Feldman 
Acked-by: Andrew Lunn 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

switchdev: don't use anonymous union on switchdev attr/obj structs

2015-05-13T18:20:59+00:00

Older gcc versions (e.g.  gcc version 4.4.6) don't like anonymous unions
which was causing build issues on the newly added switchdev attr/obj
structs.  Fix this by using named union on structs.

Signed-off-by: Scott Feldman 
Reported-by: Or Gerlitz 
Signed-off-by: David S. Miller

switchdev: convert STP update to switchdev attr set

2015-05-12T22:43:53+00:00

STP update is just a settable port attribute, so convert
switchdev_port_stp_update to an attr set.

For DSA, the prepare phase is skipped and STP updates are only done in the
commit phase.  This is because currently the DSA drivers don't need to
allocate any memory for STP updates and the STP update will not fail to HW
(unless something horrible goes wrong on the MDIO bus, in which case the
prepare phase wouldn't have been able to predict anyway).

Signed-off-by: Scott Feldman 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

switchdev: convert parent_id_get to switchdev attr get

2015-05-12T22:43:53+00:00

Switch ID is just a gettable port attribute.  Convert switchdev op
switchdev_parent_id_get to a switchdev attr.

Note: for sysfs and netlink interfaces, SWITCHDEV_ATTR_PORT_PARENT_ID is
called with SWITCHDEV_F_NO_RECUSE to limit switch ID user-visiblity to only
port netdevs.  So when a port is stacked under bond/bridge, the user can
only query switch id via the switch ports, but not via the upper devices

Signed-off-by: Scott Feldman 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

switchdev: s/swdev_/switchdev_/

2015-05-12T22:43:53+00:00

Turned out that "switchdev" sticks. So just unify all related terms to use
this prefix.

Signed-off-by: Jiri Pirko 
Signed-off-by: Scott Feldman 
Acked-by: Roopa Prabhu 
Acked-by: Andy Gospodarek 
Signed-off-by: David S. Miller

net: dsa: Add lockdep class to tx queues to avoid lockdep splat

2015-05-09T20:05:54+00:00

DSA stacks an Ethernet device on top of an Ethernet device. This can
cause false positive lockdep splats for the transmit queue:
Acked-by: Florian Fainelli 

=============================================
[ INFO: possible recursive locking detected ]
4.0.0-rc7-01838-g70621a215fc7 #386 Not tainted
---------------------------------------------
kworker/0:0/4 is trying to acquire lock:
 (_xmit_ETHER#2){+.-...}, at: [] sch_direct_xmit+0xa8/0x1fc

but task is already holding lock:
 (_xmit_ETHER#2){+.-...}, at: [] __dev_queue_xmit+0x4d4/0x56c

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(_xmit_ETHER#2);
  lock(_xmit_ETHER#2);

To avoid this, walk the tq queues of the dsa slaves and set a lockdep
class.

Signed-off-by: Andrew Lunn 
Signed-off-by: David S. Miller

dsa: implement ndo_get_iflink

2015-04-02T18:05:01+00:00

Don't use dev->iflink anymore.

CC: Florian Fainelli 
Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

net: dsa: Add basic framework to support ndo_fdb functions

2015-03-29T20:23:54+00:00

Provide callbacks for ndo_fdb_add, ndo_fdb_del, and ndo_fdb_dump.

Reviewed-by: Andrew Lunn 
Tested-by: Andrew Lunn 
Signed-off-by: Guenter Roeck 
Signed-off-by: David S. Miller