linux-stable.git/net/dccp/ipv4.c, branch linux-3.5.y

inet: makes syn_ack_timeout mandatory

2012-04-14T19:24:26+00:00

There are two struct request_sock_ops providers, tcp and dccp.

inet_csk_reqsk_queue_prune() can avoid testing syn_ack_timeout being
NULL if we make it non NULL like syn_ack_timeout

Signed-off-by: Eric Dumazet 
Cc: Gerrit Renker 
Cc: dccp@vger.kernel.org
Signed-off-by: David S. Miller

dccp: fix bug in sequence number validation during connection setup

2012-03-03T16:02:52+00:00

This fixes a bug in the sequence number validation during the initial handshake.

The code did not treat the initial sequence numbers ISS and ISR as read-only and
did not keep state for GSR and GSS as required by the specification. This causes
problems with retransmissions during the initial handshake, causing the
budding connection to be reset.

This patch now treats ISS/ISR as read-only and tracks GSS/GSR as required.

Signed-off-by: Samuel Jero 
Signed-off-by: Gerrit Renker

dccp: Evaluate ip_hdr() only once in dccp_v4_route_skb().

2011-12-01T18:28:34+00:00

This also works around a bogus gcc warning generated by an
upcoming patch from Eric Dumazet that rearranges the layout
of struct flowi4.

Signed-off-by: David S. Miller

dccp: fix error propagation in dccp_v4_connect

2011-11-21T21:45:26+00:00

The errcode is not updated when ip_route_newports() fails.

Signed-off-by: RongQing.Li 
Signed-off-by: David S. Miller

net: add missing bh_unlock_sock() calls

2011-11-03T22:06:18+00:00

Simon Kirby reported lockdep warnings and following messages :

[104661.897577] huh, entered softirq 3 NET_RX ffffffff81613740
preempt_count 00000101, exited with 00000102?

[104661.923653] huh, entered softirq 3 NET_RX ffffffff81613740
preempt_count 00000101, exited with 00000102?

Problem comes from commit 0e734419
(ipv4: Use inet_csk_route_child_sock() in DCCP and TCP.)

If inet_csk_route_child_sock() returns NULL, we should release socket
lock before freeing it.

Another lock imbalance exists if __inet_inherit_port() returns an error
since commit 093d282321da ( tproxy: fix hash locking issue when using
port redirection in __inet_inherit_port()) a backport is also needed for
>= 2.6.37 kernels.

Reported-by: Simon Kirby 
Signed-off-by: Eric Dumazet 
Tested-by: Eric Dumazet 
CC: Balazs Scheidler 
CC: KOVACS Krisztian 
Reviewed-by: Thomas Gleixner 
Tested-by: Simon Kirby 
Signed-off-by: David S. Miller

net: Compute protocol sequence numbers and fragment IDs using MD5.

2011-08-07T01:33:19+00:00

Computers have become a lot faster since we compromised on the
partial MD4 hash which we use currently for performance reasons.

MD5 is a much safer choice, and is inline with both RFC1948 and
other ISS generators (OpenBSD, Solaris, etc.)

Furthermore, only having 24-bits of the sequence number be truly
unpredictable is a very serious limitation.  So the periodic
regeneration and 8-bit counter have been removed.  We compute and
use a full 32-bit sequence number.

For ipv6, DCCP was found to use a 32-bit truncated initial sequence
number (it needs 43-bits) and that is fixed here as well.

Reported-by: Dan Kaminsky 
Tested-by: Willy Tarreau 
Signed-off-by: David S. Miller

ipv4: Make caller provide flowi4 key to inet_csk_route_req().

2011-05-18T22:32:03+00:00

This way the caller can get at the fully resolved fl4->{daddr,saddr}
etc.

Signed-off-by: David S. Miller

ipv4: Use inet_csk_route_child_sock() in DCCP and TCP.

2011-05-08T22:28:03+00:00

Operation order is now transposed, we first create the child
socket then we try to hook up the route.

Signed-off-by: David S. Miller

dccp: Use cork flow in dccp_v4_connect()

2011-05-08T20:18:53+00:00

Since this is invoked from inet_stream_connect() the socket is locked
and therefore this usage is safe.

Signed-off-by: David S. Miller

dccp: Use flowi4->saddr in dccp_v4_connect()

2011-05-04T03:06:41+00:00

Signed-off-by: David S. Miller