linux-stable.git/net/core, branch linux-2.6.16.y

[PKTGEN]: srcmac fix

2007-11-02T23:56:44+00:00

Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[NET]: gen_estimator deadlock fix

2007-11-02T21:51:48+00:00

-Fixes ABBA deadlock noted by Patrick McHardy :

> There is at least one ABBA deadlock, est_timer() does:
> read_lock(&est_lock)
> spin_lock(e->stats_lock) (which is dev->queue_lock)
>
> and qdisc_destroy calls htb_destroy under dev->queue_lock, which
> calls htb_destroy_class, then gen_kill_estimator and this
> write_locks est_lock.

To fix the ABBA deadlock the rate estimators are now kept on an rcu list.

-The est_lock changes the use from protecting the list to protecting
the update to the 'bstat' pointer in order to avoid NULL dereferencing.

-The 'interval' member of the gen_estimator structure removed as it is
not needed.

Signed-off-by: Ranko Zivojnovic 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

unexport neigh_update_hhs

2007-10-06T19:15:09+00:00

A static function mustn't be exported.

Signed-off-by: Adrian Bunk

[NET]: Fix gen_estimator timer removal race

2007-07-22T16:26:20+00:00

As noticed by Jarek Poplawski , the timer removal in
gen_kill_estimator races with the timer function rearming the timer.

Check whether the timer list is empty before rearming the timer
in the timer function to fix this.

Signed-off-by: Patrick McHardy 
Acked-by: Jarek Poplawski 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[NET] skbuff: remove export of static symbol

2007-07-22T16:11:42+00:00

skb_clone_fraglist is static so it shouldn't be exported.

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[NET]: "wrong timeout value" in sk_wait_data() v2

2007-07-22T15:46:29+00:00

sys_setsockopt() do not check properly timeout values for
SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout
values. POSIX do not defines behaviour for sys_setsockopt in case negative
timeouts, but requires that setsockopt() shall fail with -EDOM if the send and
receive timeout values are too big to fit into the timeout fields in the socket
structure.
In current implementation negative timeout can lead to error messages like
"schedule_timeout: wrong timeout value".

Proposed patch:
- checks tv_usec and returns -EDOM if it is wrong
- do not allows to set negative timeout values (sets 0 instead) and outputs
ratelimited information message about such attempts.

Signed-off-By: Vasily Averin 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[NET]: Fix UDP checksum issue in net poll mode.

2007-04-19T23:40:19+00:00

In net poll mode, the current checksum function doesn't consider the
kind of packet which is padded to reach a specific minimum length. I
believe that's the problem causing my test case failed. The following
patch fixed this issue.

Signed-off-by: Aubrey Li 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[IFB]: Fix crash on input device removal

2007-04-03T02:03:55+00:00

The input_device pointer is not refcounted, which means the device may
disappear while packets are queued, causing a crash when ifb passes packets
with a stale skb->dev pointer to netif_rx().

Fix by storing the interface index instead and do a lookup where neccessary.

Signed-off-by: Patrick McHardy 
Signed-off-by: Adrian Bunk

[NET_SCHED]: Fix ingress locking

2007-03-28T19:58:20+00:00

Ingress queueing uses a seperate lock for serializing enqueue operations,
but fails to properly protect itself against concurrent changes to the
qdisc tree. Use queue_lock for now since the real fix it quite intrusive.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[NET]: Copy mac_len in skb_clone() as well

2007-03-20T22:24:20+00:00

ANK says: "It is rarely used, that's wy it was not noticed.
But in the places, where it is used, it should be disaster."

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk