linux-stable.git/net/core/skbuff.c, branch v5.9

net/core: check length before updating Ethertype in skb_mpls_{push,pop}

2020-10-04T22:09:26+00:00

Openvswitch allows to drop a packet's Ethernet header, therefore
skb_mpls_push() and skb_mpls_pop() might be called with ethernet=true
and mac_len=0. In that case the pointer passed to skb_mod_eth_type()
doesn't point to an Ethernet header and the new Ethertype is written at
unexpected locations.

Fix this by verifying that mac_len is big enough to contain an Ethernet
header.

Fixes: fa4e0f8855fc ("net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions")
Signed-off-by: Guillaume Nault 
Acked-by: Davide Caratti 
Signed-off-by: David S. Miller

net: Get rid of consume_skb when tracing is off

2020-08-24T23:12:26+00:00

The function consume_skb is only meaningful when tracing is enabled.
This patch makes it conditional on CONFIG_TRACEPOINTS.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

net: handle the return value of pskb_carve_frag_list() correctly

2020-08-18T22:56:56+00:00

pskb_carve_frag_list() may return -ENOMEM in pskb_carve_inside_nonlinear().
we should handle this correctly or we would get wrong sk_buff.

Fixes: 6fa01ccd8830 ("skbuff: Add pskb_extract() helper function")
Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Fix potential wrong skb->protocol in skb_vlan_untag()

2020-08-16T22:33:49+00:00

We may access the two bytes after vlan_hdr in vlan_set_encap_proto(). So
we should pull VLAN_HLEN + sizeof(unsigned short) in skb_vlan_untag() or
we may access the wrong data.

Fixes: 0d5501c1c828 ("net: Always untag vlan-tagged traffic on input.")
Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Use helper function ip_is_fragment()

2020-08-08T21:24:53+00:00

Use helper function ip_is_fragment() to check ip fragment.

Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Pass NULL to skb_network_protocol() when we don't care about vlan depth

2020-08-03T22:38:31+00:00

When we don't care about vlan depth, we could pass NULL instead of the
address of a unused local variable to skb_network_protocol() as a param.

Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Use __skb_pagelen() directly in skb_cow_data()

2020-08-03T22:38:31+00:00

In fact, skb_pagelen() - skb_headlen() is equal to __skb_pagelen(), use it
directly to avoid unnecessary skb_headlen() call.

Also fix the CHECK note of checkpatch.pl:
    Comparison to NULL could be written "!__pskb_pull_tail"

Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

tcp: add earliest departure time to SCM_TIMESTAMPING_OPT_STATS

2020-08-01T00:00:44+00:00

This change adds TCP_NLA_EDT to SCM_TIMESTAMPING_OPT_STATS that reports
the earliest departure time(EDT) of the timestamped skb. By tracking EDT
values of the skb from different timestamps, we can observe when and how
much the value changed. This allows to measure the precise delay
injected on the sender host e.g. by a bpf-base throttler.

Signed-off-by: Yousuk Seung 
Signed-off-by: Eric Dumazet 
Acked-by: Neal Cardwell 
Acked-by: Soheil Hassas Yeganeh 
Acked-by: Yuchung Cheng 
Signed-off-by: David S. Miller

net: unexport skb_gro_receive()

2020-05-20T02:55:36+00:00

skb_gro_receive() used to be used by SCTP, it is no longer the case.

skb_gro_receive_list() is in the same category : never used from modules.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: allow __skb_ext_alloc to sleep

2020-05-17T19:35:34+00:00

mptcp calls this from the transmit side, from process context.
Allow a sleeping allocation instead of unconditional GFP_ATOMIC.

Acked-by: Paolo Abeni 
Signed-off-by: Florian Westphal 
Signed-off-by: David S. Miller