linux-stable.git/net/core/rtnetlink.c, branch v3.18.3

rtnetlink: release net refcnt on error in do_setlink()

2014-11-30T05:05:43+00:00

rtnl_link_get_net() holds a reference on the 'struct net', we need to release
it in case of error.

CC: Eric W. Biederman 
Fixes: b51642f6d77b ("net: Enable a userns root rtnl calls that are safe for unprivilged users")
Signed-off-by: Nicolas Dichtel 
Reviewed-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller

bridge: Sanitize IFLA_EXT_MASK for AF_BRIDGE:RTM_GETLINK

2014-11-26T20:29:01+00:00

Only search for IFLA_EXT_MASK if the message actually carries a
ifinfomsg header and validate minimal length requirements for
IFLA_EXT_MASK.

Fixes: 6cbdceeb ("bridge: Dump vlan information from a bridge port")
Cc: Vlad Yasevich 
Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

bridge: Validate IFLA_BRIDGE_FLAGS attribute length

2014-11-26T20:29:00+00:00

Payload is currently accessed blindly and may exceed valid message
boundaries.

Fixes: 407af3299 ("bridge: Add netlink interface to configure vlans on bridge ports")
Cc: Vlad Yasevich 
Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

rtnl/do_setlink(): notify when a netdev is modified

2014-09-02T19:57:04+00:00

Depending on which parameters were updated, the changes were not propagated via
the notifier chain and netlink.

The new flag has been set only when the change did not cause a call to the
notifier chain and/or to the netlink notification functions.

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

rtnl/do_setlink(): last arg is now a set of flags

2014-09-02T19:57:04+00:00

There is no functional changes with this commit, it only prepares the next one.

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

rtnl/do_setlink(): set modified when IFLA_LINKMODE is updated

2014-09-02T19:57:04+00:00

The only effect of this patch is to print a warning if IFLA_LINKMODE is updated
and a following change fails.

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

rtnl/do_setlink(): set modified when IFLA_TXQLEN is updated

2014-09-02T19:57:04+00:00

The only effect of this patch is to print a warning if IFLA_TXQLEN is updated
and a following change fails.

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

rtnetlink: fix VF info size

2014-08-08T17:28:09+00:00

Commit 1d8faf48c74b8 ("net/core: Add VF link state control") added new
attribute to IFLA_VF_INFO group in rtnl_fill_ifinfo but did not adjust size
of the allocated memory in if_nlmsg_size/rtnl_vfinfo_size. As the result, we
may trigger warnings in rtnl_getlink and similar functions when many VF
links are enabled, as the information does not fit into the allocated skb.

Fixes: 1d8faf48c74b8 ("net/core: Add VF link state control")
Reported-by: Yulong Pei 
Signed-off-by: Jiri Benc 
Signed-off-by: David S. Miller

rtnetlink: Drop unnecessary return value from ndo_dflt_fdb_del

2014-07-17T06:13:26+00:00

This change cleans up ndo_dflt_fdb_del to drop the ENOTSUPP return value since
that isn't actually returned anywhere in the code.  As a result we are able to
drop a few lines by just defaulting this to -EINVAL.

Signed-off-by: Alexander Duyck 
Signed-off-by: David S. Miller

net: rtnetlink - make create_link take name_assign_type

2014-07-15T23:13:07+00:00

This passes down NET_NAME_USER (or NET_NAME_ENUM) to alloc_netdev(),
for any device created over rtnetlink.

v9: restore reverse-christmas-tree order of local variables

Signed-off-by: Tom Gundersen 
Signed-off-by: David S. Miller