linux-stable.git/net/core/rtnetlink.c, branch v3.13.2

net: fix rtnl notification in atomic context

2013-10-25T23:03:45+00:00

commit 991fb3f74c "dev: always advertise rx_flags changes via netlink"
introduced rtnl notification from __dev_set_promiscuity(),
which can be called in atomic context.

Steps to reproduce:
ip tuntap add dev tap1 mode tap
ifconfig tap1 up
tcpdump -nei tap1 &
ip tuntap del dev tap1 mode tap

[  271.627994] device tap1 left promiscuous mode
[  271.639897] BUG: sleeping function called from invalid context at mm/slub.c:940
[  271.664491] in_atomic(): 1, irqs_disabled(): 0, pid: 3394, name: ip
[  271.677525] INFO: lockdep is turned off.
[  271.690503] CPU: 0 PID: 3394 Comm: ip Tainted: G        W    3.12.0-rc3+ #73
[  271.703996] Hardware name: System manufacturer System Product Name/P8Z77 WS, BIOS 3007 07/26/2012
[  271.731254]  ffffffff81a58506 ffff8807f0d57a58 ffffffff817544e5 ffff88082fa0f428
[  271.760261]  ffff8808071f5f40 ffff8807f0d57a88 ffffffff8108bad1 ffffffff81110ff8
[  271.790683]  0000000000000010 00000000000000d0 00000000000000d0 ffff8807f0d57af8
[  271.822332] Call Trace:
[  271.838234]  [] dump_stack+0x55/0x76
[  271.854446]  [] __might_sleep+0x181/0x240
[  271.870836]  [] ? rcu_irq_exit+0x68/0xb0
[  271.887076]  [] kmem_cache_alloc_node+0x4e/0x2a0
[  271.903368]  [] ? vprintk_emit+0x1dc/0x5a0
[  271.919716]  [] ? __alloc_skb+0x57/0x2a0
[  271.936088]  [] ? vprintk_emit+0x1e0/0x5a0
[  271.952504]  [] __alloc_skb+0x57/0x2a0
[  271.968902]  [] rtmsg_ifinfo+0x52/0x100
[  271.985302]  [] __dev_notify_flags+0xad/0xc0
[  272.001642]  [] __dev_set_promiscuity+0x8c/0x1c0
[  272.017917]  [] ? packet_notifier+0x5/0x380
[  272.033961]  [] dev_set_promiscuity+0x29/0x50
[  272.049855]  [] packet_dev_mc+0x87/0xc0
[  272.065494]  [] packet_notifier+0x1b2/0x380
[  272.080915]  [] ? packet_notifier+0x5/0x380
[  272.096009]  [] notifier_call_chain+0x66/0x150
[  272.110803]  [] __raw_notifier_call_chain+0xe/0x10
[  272.125468]  [] raw_notifier_call_chain+0x16/0x20
[  272.139984]  [] call_netdevice_notifiers_info+0x40/0x70
[  272.154523]  [] call_netdevice_notifiers+0x16/0x20
[  272.168552]  [] rollback_registered_many+0x145/0x240
[  272.182263]  [] rollback_registered+0x31/0x40
[  272.195369]  [] unregister_netdevice_queue+0x58/0x90
[  272.208230]  [] __tun_detach+0x140/0x340
[  272.220686]  [] tun_chr_close+0x36/0x60

Signed-off-by: Alexei Starovoitov 
Acked-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

dev: update __dev_notify_flags() to send rtnl msg

2013-09-30T19:08:12+00:00

This patch only prepares the next one, there is no functional change.
Now, __dev_notify_flags() can also be used to notify flags changes via
rtnetlink.

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2013-08-16T22:37:26+00:00

rtnetlink: remove an unneeded test

2013-08-15T08:29:02+00:00

We know that "dev" is a valid pointer at this point, so we can remove
the test and clean up a little.

Signed-off-by: Dan Carpenter 
Reviewed-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller

rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr() with ifinfomsg header

2013-08-14T02:09:29+00:00

Fix the iproute2 command `bridge vlan show`, after switching from
rtgenmsg to ifinfomsg.

Let's start with a little history:

Feb 20:   Vlad Yasevich got his VLAN-aware bridge patchset included in
          the 3.9 merge window.
          In the kernel commit 6cbdceeb, he added attribute support to
          bridge GETLINK requests sent with rtgenmsg.

Mar 6th:  Vlad got this iproute2 reference implementation of the bridge
          vlan netlink interface accepted (iproute2 9eff0e5c)

Apr 25th: iproute2 switched from using rtgenmsg to ifinfomsg (63338dca)
          http://patchwork.ozlabs.org/patch/239602/
          http://marc.info/?t=136680900700007

Apr 28th: Linus released 3.9

Apr 30th: Stephen released iproute2 3.9.0

The `bridge vlan show` command haven't been working since the switch to
ifinfomsg, or in a released version of iproute2. Since the kernel side
only supports rtgenmsg, which iproute2 switched away from just prior to
the iproute2 3.9.0 release.

I haven't been able to find any documentation, about neither rtgenmsg
nor ifinfomsg, and in which situation to use which, but kernel commit
88c5b5ce seams to suggest that ifinfomsg should be used.

Fixing this in kernel will break compatibility, but I doubt that anybody
have been using it due to this bug in the user space reference
implementation, at least not without noticing this bug. That said the
functionality is still fully functional in 3.9, when reversing iproute2
commit 63338dca.

This could also be fixed in iproute2, but thats an ugly patch that would
reintroduce rtgenmsg in iproute2, and from searching in netdev it seams
like rtgenmsg usage is discouraged. I'm assuming that the only reason
that Vlad implemented the kernel side to use rtgenmsg, was because
iproute2 was using it at the time.

Signed-off-by: Asbjoern Sloth Toennesen 
Reviewed-by: Vlad Yasevich 
Signed-off-by: David S. Miller

rtnetlink: Fix inverted check in ndo_dflt_fdb_del()

2013-08-10T08:24:12+00:00

Fix inverted check when deleting an fdb entry.

Signed-off-by: Sridhar Samudrala 
Signed-off-by: David S. Miller

rtnl: export physical port id via RT netlink

2013-07-31T00:31:24+00:00

Signed-off-by: Jiri Pirko 
Acked-by: Ben Hutchings 
Signed-off-by: Narendra K 
Signed-off-by: David S. Miller

rtnetlink: allow using zero MAC address in rtnl_fdb_{add,del}

2013-06-25T16:31:39+00:00

This is required for multiple default destinations management in VXLAN

Signed-off-by: Mike Rapoport 
Signed-off-by: Stephen Hemminger

net/core: Add VF link state control

2013-06-14T00:51:04+00:00

Add netlink directives and ndo entry to allow for controling
VF link, which can be in one of three states:

Auto - VF link state reflects the PF link state (default)

Up - VF link state is up, traffic from VF to VF works even if
the actual PF link is down

Down - VF link state is down, no traffic from/to this VF, can be of
use while configuring the VF

Signed-off-by: Rony Efraim 
Signed-off-by: Or Gerlitz 
Signed-off-by: David S. Miller

net: pass info struct via netdevice notifier

2013-05-28T20:11:01+00:00

So far, only net_device * could be passed along with netdevice notifier
event. This patch provides a possibility to pass custom structure
able to provide info that event listener needs to know.

Signed-off-by: Jiri Pirko 

v2->v3: fix typo on simeth
	shortened dev_getter
	shortened notifier_info struct name
v1->v2: fix notifier_call parameter in call_netdevice_notifier()
Signed-off-by: David S. Miller