linux-stable.git/net/core/ethtool.c, branch v3.0.2

ethtool: Allow zero-length register dumps again

2011-08-05T04:58:34+00:00

commit 67ae7cf1eeda777f79259c4c6cb17a0bd28dee71 upstream.

Some drivers (ab)use the ethtool_ops::get_regs operation to expose
only a hardware revision ID.  Commit
a77f5db361ed9953b5b749353ea2c7fed2bf8d93 ('ethtool: Allocate register
dump buffer with vmalloc()') had the side-effect of breaking these, as
vmalloc() returns a null pointer for size=0 whereas kmalloc() did not.

For backward-compatibility, allow zero-length dumps again.

Reported-by: Kalle Valo 
Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net: fix ETHTOOL_SFEATURES compatibility with old ethtool_ops.set_flags

2011-05-26T18:13:59+00:00

Current code squashes flags to bool - this makes set_flags fail whenever
some ETH_FLAG_* equivalent features are set. Fix this.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2011-05-17T21:33:11+00:00

Conflicts:
	drivers/net/vmxnet3/vmxnet3_ethtool.c
	net/core/dev.c

net: ethtool: fix IPV6 checksum feature name string

2011-05-17T20:50:02+00:00

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

ethtool: Added support for FW dump

2011-05-13T18:37:28+00:00

Added code to take FW dump via ethtool. Dump level can be controlled via setting the
dump flag. A get function is provided to query the current setting of the dump flag.
Dump data is obtained from the driver via a separate get function.

Changes from v3:
Fixed buffer length issue in ethtool_get_dump_data function.
Updated kernel doc for ethtool_dump struct and get_dump_flag function.

Changes from v2:
Provided separate commands for get flag and data.
Check for minimum of the two buffer length obtained via ethtool and driver and
use that for dump buffer
Pass up the driver return error codes up to the caller.
Added kernel doc comments.

Signed-off-by: Anirban Chakraborty 
Reviewed-by: Ben Hutchings 
Signed-off-by: David S. Miller

ethtool: bring back missing comma in netdev features strings

2011-05-12T21:50:04+00:00

The issue was introduced in commit eed2a12f1ed9aabf.

Signed-off-by: Franco Fichtner 
Acked-by: Michał Mirosław 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller

net: Allow ethtool to set interface in loopback mode.

2011-05-08T22:59:12+00:00

This patch enables ethtool to set the loopback mode on a given interface.
By configuring the interface in loopback mode in conjunction with a policy
route / rule, a userland application can stress the egress / ingress path
exposing the flows of the change in progress and potentially help developer(s)
understand the impact of those changes without even sending a packet out
on the network.

Following set of commands illustrates one such example -
    a) ip -4 addr add 192.168.1.1/24 dev eth1
    b) ip -4 rule add from all iif eth1 lookup 250
    c) ip -4 route add local 0/0 dev lo proto kernel scope host table 250
    d) arp -Ds 192.168.1.100 eth1
    e) arp -Ds 192.168.1.200 eth1
    f) sysctl -w net.ipv4.ip_nonlocal_bind=1
    g) sysctl -w net.ipv4.conf.all.accept_local=1
    # Assuming that the machine has 8 cores
    h) taskset 000f netserver -L 192.168.1.200
    i) taskset 00f0 netperf -t TCP_CRR -L 192.168.1.100 -H 192.168.1.200 -l 30

Signed-off-by: Mahesh Bandewar 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller

ethtool: remove phys_id from ethtool_ops

2011-05-08T19:49:33+00:00

After that all the upstream kernel drivers now use phys_id,
and the old ethtool_ops interface (phys_id) can be removed.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: fix hw_features ethtool_ops->set_flags compatibility

2011-04-22T00:21:43+00:00

__ethtool_set_flags() was not taking into account features set but not
user-toggleable.

Since GFLAGS returns masked dev->features, EINVAL is returned when
passed flags differ to it, and not to wanted_features.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

ethtool: allow custom interval for physical identification

2011-04-15T04:15:49+00:00

When physical identification of an adapter is done by toggling the
mechanism on and off through software utilizing the set_phys_id operation,
it is done with a fixed duration for both on and off states.  Some drivers
may want to set a custom duration for the on/off intervals.  This patch
changes the API so the return code from the driver's entry point when it
is called with ETHTOOL_ID_ACTIVE can specify the frequency at which to
cycle the on/off states, and updates the drivers that have already been
converted to use the new set_phys_id and use the synchronous method for
identifying an adapter.

The physical identification frequency set in the updated drivers is based
on how it was done prior to the introduction of set_phys_id.

Compile tested only.  Also fixes a compiler warning in sfc.

v2: drivers do not return -EINVAL for ETHOOL_ID_ACTIVE
v3: fold patchset into single patch and cleanup per Ben's feedback

Signed-off-by: Bruce Allan 
Cc: Ben Hutchings 
Cc: Sathya Perla 
Cc: Subbu Seetharaman 
Cc: Ajit Khaparde 
Cc: Michael Chan 
Cc: Eilon Greenstein 
Cc: Divy Le Ray 
Cc: Don Fry 
Cc: Jon Mason 
Cc: Solarflare linux maintainers 
Cc: Steve Hodgson 
Cc: Stephen Hemminger 
Cc: Matt Carlson 
Acked-by: Jon Mason 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller