linux-stable.git/net/core/ethtool.c, branch linux-3.18.y

net: ethtool: not call vzalloc for zero sized memory request

2019-04-27T07:30:26+00:00

[ Upstream commit 3d8830266ffc28c16032b859e38a0252e014b631 ]

NULL or ZERO_SIZE_PTR will be returned for zero sized memory
request, and derefencing them will lead to a segfault

so it is unnecessory to call vzalloc for zero sized memory
request and not call functions which maybe derefence the
NULL allocated memory

this also fixes a possible memory leak if phy_ethtool_get_stats
returns error, memory should be freed before exit

Signed-off-by: Li RongQing 
Reviewed-by: Wang Li 
Reviewed-by: Michal Kubecek 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ethtool: Use kcalloc instead of kmalloc for ethtool_get_strings

2015-11-13T18:17:15+00:00

[ Upstream commit 077cb37fcf6f00a45f375161200b5ee0cd4e937b ]

It seems that kernel memory can leak into userspace by a
kmalloc, ethtool_get_strings, then copy_to_user sequence.

Avoid this by using kcalloc to zero fill the copied buffer.

Signed-off-by: Joe Perches 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: ethtool: Return -EOPNOTSUPP if user space tries to read EEPROM with lengh 0

2014-10-31T20:12:34+00:00

If a driver supports reading EEPROM but no EEPROM is installed in the system,
the driver's get_eeprom_len function returns 0. ethtool will subsequently
try to read that zero-length EEPROM anyway. If the driver does not support
EEPROM access at all, this operation will return -EOPNOTSUPP. If the driver
does support EEPROM access but no EEPROM is installed, the operation will
return -EINVAL. Return -EOPNOTSUPP in both cases for consistency.

Signed-off-by: Guenter Roeck 
Tested-by: Andrew Lunn 
Signed-off-by: David S. Miller

ethtool: Ethtool parameter to dynamically change tx_copybreak

2014-10-06T05:04:16+00:00

Use new ethtool [sg]et_tunable() to set tx_copybread (inline threshold)

Signed-off-by: Eric Dumazet 
Signed-off-by: Amir Vadai 
Signed-off-by: David S. Miller

ethtool: Add generic options for tunables

2014-09-05T19:12:20+00:00

This patch adds new ethtool cmd, ETHTOOL_GTUNABLE & ETHTOOL_STUNABLE for getting
tunable values from driver.

Add get_tunable and set_tunable to ethtool_ops. Driver implements these
functions for getting/setting tunable value.

Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Signed-off-by: David S. Miller

ethtool: Check that reserved fields of struct ethtool_rxfh are 0

2014-06-03T01:43:16+00:00

We should fail rather than silently ignoring use of these extensions.

Signed-off-by: Ben Hutchings

ethtool: Replace ethtool_ops::{get,set}_rxfh_indir() with {get,set}_rxfh()

2014-06-03T01:42:44+00:00

ETHTOOL_{G,S}RXFHINDIR and ETHTOOL_{G,S}RSSH should work for drivers
regardless of whether they expose the hash key, unless you try to
set a hash key for a driver that doesn't expose it.

Signed-off-by: Ben Hutchings 
Acked-by: Jeff Kirsher

ethtool: Disallow ETHTOOL_SRSSH with both indir table and hash key unchanged

2014-05-19T00:29:42+00:00

This would be a no-op, so there is no reason to request it.

This also allows conversion of the current implementations of
ethtool_ops::{get,set}_rxfh_indir to ethtool_ops::{get,set}_rxfh
with no change other than their parameters.

Signed-off-by: Ben Hutchings

ethtool: Name the 'no change' value for setting RSS hash key but not indir table

2014-05-19T00:18:19+00:00

We usually allocate special values of u32 fields starting from the top
down, so also change the value to 0xffffffff.  As these operations
haven't been included in a stable release yet, it's not too late to
change.

Signed-off-by: Ben Hutchings

ethtool: Return immediately on error in ethtool_copy_validate_indir()

2014-05-19T00:17:32+00:00

We must return -EFAULT immediately rather than continuing into
the loop.

Similarly, we may as well return -EINVAL directly.

Signed-off-by: Ben Hutchings