linux-stable.git/net/core/ethtool.c, branch linux-3.16.y

ethtool: Use kcalloc instead of kmalloc for ethtool_get_strings

2015-10-28T10:33:20+00:00

commit 077cb37fcf6f00a45f375161200b5ee0cd4e937b upstream.

It seems that kernel memory can leak into userspace by a
kmalloc, ethtool_get_strings, then copy_to_user sequence.

Avoid this by using kcalloc to zero fill the copied buffer.

Signed-off-by: Joe Perches 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller 
Signed-off-by: Luis Henriques

ethtool: Check that reserved fields of struct ethtool_rxfh are 0

2014-06-03T01:43:16+00:00

We should fail rather than silently ignoring use of these extensions.

Signed-off-by: Ben Hutchings

ethtool: Replace ethtool_ops::{get,set}_rxfh_indir() with {get,set}_rxfh()

2014-06-03T01:42:44+00:00

ETHTOOL_{G,S}RXFHINDIR and ETHTOOL_{G,S}RSSH should work for drivers
regardless of whether they expose the hash key, unless you try to
set a hash key for a driver that doesn't expose it.

Signed-off-by: Ben Hutchings 
Acked-by: Jeff Kirsher

ethtool: Disallow ETHTOOL_SRSSH with both indir table and hash key unchanged

2014-05-19T00:29:42+00:00

This would be a no-op, so there is no reason to request it.

This also allows conversion of the current implementations of
ethtool_ops::{get,set}_rxfh_indir to ethtool_ops::{get,set}_rxfh
with no change other than their parameters.

Signed-off-by: Ben Hutchings

ethtool: Name the 'no change' value for setting RSS hash key but not indir table

2014-05-19T00:18:19+00:00

We usually allocate special values of u32 fields starting from the top
down, so also change the value to 0xffffffff.  As these operations
haven't been included in a stable release yet, it's not too late to
change.

Signed-off-by: Ben Hutchings

ethtool: Return immediately on error in ethtool_copy_validate_indir()

2014-05-19T00:17:32+00:00

We must return -EFAULT immediately rather than continuing into
the loop.

Similarly, we may as well return -EINVAL directly.

Signed-off-by: Ben Hutchings

ethtool: exit the loop when invalid index occurs

2014-04-28T17:28:43+00:00

The commit 3de0b592394d ("ethtool: Support for configurable RSS hash
key") introduced a new function ethtool_copy_validate_indir() with
full iteration of the loop to validate the ring indices, which could
be an overkill. To minimize the impact, we ought to exit the loop as
soon as the invalid index occurs for the very first time. The
remaining loop simply doesn't serve any more purpose.

Signed-off-by: Jean Sacren 
Cc: Venkata Duvvuru 
Signed-off-by: David S. Miller

ethtool: Support for configurable RSS hash key

2014-04-23T01:27:57+00:00

This ethtool patch primarily copies the ioctl command data structures
from/to the User space and invokes the driver hook.

Signed-off-by: Venkat Duvvuru 
Signed-off-by: David S. Miller

net: add busy_poll device feature

2014-04-03T18:31:34+00:00

Currently there is no way how to find out if a device supports busy
polling. So add a feature and make it dependent on ndo_busy_poll
existence.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: Add layer 2 hardware acceleration operations for macvlan devices

2013-11-08T00:11:41+00:00

Add a operations structure that allows a network interface to export
the fact that it supports package forwarding in hardware between
physical interfaces and other mac layer devices assigned to it (such
as macvlans). This operaions structure can be used by virtual mac
devices to bypass software switching so that forwarding can be done
in hardware more efficiently.

Signed-off-by: John Fastabend 
Signed-off-by: Neil Horman 
CC: Andy Gospodarek 
CC: "David S. Miller" 
Signed-off-by: David S. Miller