linux-stable.git/net/core/ethtool.c, branch linux-2.6.33.y

net: clear heap allocation for ETHTOOL_GRXCLSRLALL

2011-03-21T19:43:41+00:00

commit ae6df5f96a51818d6376da5307d773baeece4014 upstream.

Calling ETHTOOL_GRXCLSRLALL with a large rule_cnt will allocate kernel
heap without clearing it. For the one driver (niu) that implements it,
it will leave the unused portion of heap unchanged and copy the full
contents back to userspace.

Signed-off-by: Kees Cook 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net: clear heap allocations for privileged ethtool actions

2011-03-21T19:43:20+00:00

[ Upstream commit b00916b189d13a615ff05c9242201135992fcda3 ]

Several other ethtool functions leave heap uncleared (potentially) by
drivers. Some interfaces appear safe (eeprom, etc), in that the sizes
are well controlled. In some situations (e.g. unchecked error conditions),
the heap will remain unchanged in areas before copying back to userspace.
Note that these are less of an issue since these all require CAP_NET_ADMIN.

Cc: stable@kernel.org
Signed-off-by: Kees Cook 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ethtool: Fix potential user buffer overflow for ETHTOOL_{G, S}RXFH

2010-08-02T17:26:43+00:00

commit bf988435bd5b53529f4408a8efb1f433f6ddfda9 upstream.

struct ethtool_rxnfc was originally defined in 2.6.27 for the
ETHTOOL_{G,S}RXFH command with only the cmd, flow_type and data
fields.  It was then extended in 2.6.30 to support various additional
commands.  These commands should have been defined to use a new
structure, but it is too late to change that now.

Since user-space may still be using the old structure definition
for the ETHTOOL_{G,S}RXFH commands, and since they do not need the
additional fields, only copy the originally defined fields to and
from user-space.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ethtool: Fix potential kernel buffer overflow in ETHTOOL_GRXCLSRLALL

2010-08-02T17:26:39+00:00

commit db048b69037e7fa6a7d9e95a1271a50dc08ae233 upstream.

On a 32-bit machine, info.rule_cnt >= 0x40000000 leads to integer
overflow and the buffer may be smaller than needed.  Since
ETHTOOL_GRXCLSRLALL is unprivileged, this can presumably be used for at
least denial of service.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ethtool: allow non-admin user to read GRO settings.

2010-02-16T22:53:23+00:00

Looks like an oversight in GRO design.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

ethtool: Add reset operation

2009-10-07T08:10:44+00:00

After updating firmware stored in flash, users may wish to reset the
relevant hardware and start the new firmware immediately.  This should
not be completely automatic as it may be disruptive.

A selective reset may also be useful for debugging or diagnostics.

This adds a separate reset operation which takes flags indicating the
components to be reset.  Drivers are allowed to reset only a subset of
those requested, and must indicate the actual subset.  This allows the
use of generic component masks and some future expansion.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

ethtool: Remove support for obsolete string query operations

2009-10-05T07:10:11+00:00

The in-tree implementations have all been converted to
get_sset_count().

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

net/ethtool: Add support for the ethtool feature to flash firmware image from a specified file.

2009-09-03T06:07:39+00:00

This patch adds support to flash a firmware image to a device using ethtool.
The driver gets the filename of the firmware image and flashes the image
using the request firmware path.

The region "on the chip" to be flashed can be specified by an option.
It is upto the device driver to enumerate the region number passed by ethtool,
to the region to be flashed.

The default behavior is to flash all the regions on the chip.

Signed-off-by: Ajit Khaparde 
Signed-off-by: David S. Miller

net: ethtool_op_get_rx_csum() should be public and exported

2009-07-27T18:35:31+00:00

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ethtool: device independent rx_csum and get_flags routines

2009-07-27T02:25:45+00:00

This helps avoid error messages with ethtool -k on devices that
don't provide device specific routines.

Signed-off-by: Sridhar Samudrala 

------------------------------------------------------------------
Signed-off-by: David S. Miller