linux-stable.git/net/ceph/ceph_common.c, branch linux-3.5.y

libceph: flush msgr queue during mon_client shutdown

2012-06-20T12:43:50+00:00

We need to flush the msgr workqueue during mon_client shutdown to
ensure that any work affecting our embedded ceph_connection is
finished so that we can be safely destroyed.

Previously, we were flushing the work queue after osd_client
shutdown and before mon_client shutdown to ensure that any osd
connection refs to authorizers are flushed.  Remove the redundant
flush, and document in the comment that the mon_client flush is
needed to cover that case as well.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder 
(cherry picked from commit f3dea7edd3d449fe7a6d402c1ce56a294b985261)

net: cleanup unsigned to unsigned int

2012-04-15T16:44:40+00:00

Use of "unsigned int" is preferred to bare "unsigned" in net tree.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ceph: ensure Boolean options support both senses

2012-03-22T15:47:51+00:00

Many ceph-related Boolean options offer the ability to both enable
and disable a feature.  For all those that don't offer this, add
a new option so that they do.

Note that ceph_show_options()--which reports mount options currently
in effect--only reports the option if it is different from the
default value.

Signed-off-by: Alex Elder 
Signed-off-by: Sage Weil

rbd: make ceph_parse_options() return a pointer

2012-03-22T15:47:47+00:00

ceph_parse_options() takes the address of a pointer as an argument
and uses it to return the address of an allocated structure if
successful.  With this interface is not evident at call sites that
the pointer is always initialized.  Change the interface to return
the address instead (or a pointer-coded error code) to make the
validity of the returned pointer obvious.

Signed-off-by: Alex Elder 
Signed-off-by: Sage Weil

ceph: initialize client debugfs outside of monc->mutex

2012-02-02T20:49:01+00:00

Initializing debufs under monc->mutex introduces a lock dependency for
sb->s_type->i_mutex_key, which (combined with several other dependencies)
leads to an annoying lockdep warning.  There's no particular reason to do
the debugfs setup under this lock, so move it out.

It used to be the case that our first monmap could come from the OSD; that
is no longer the case with recent servers, so we will reliably set up the
client entry during the initial authentication.

We don't have to worry about racing with debugfs teardown by
ceph_debugfs_client_cleanup() because ceph_destroy_client() calls
ceph_msgr_flush() first, which will wait for the message dispatch work
to complete (and the debugfs init to complete).

Fixes: #1940
Signed-off-by: Sage Weil

libceph: create messenger with client

2011-10-25T23:10:15+00:00

This simplifies the init/shutdown paths, and makes client->msgr available
during the rest of the setup process.

Signed-off-by: Sage Weil

libceph: fix parse options memory leak

2011-09-16T16:19:53+00:00

ceph_destroy_options does not free opt->mon_addr that
is allocated in ceph_parse_options.

Signed-off-by: Noah Watkins 
Signed-off-by: Sage Weil

libceph: Create a new key type "ceph".

2011-03-29T19:11:24+00:00

This allows us to use existence of the key type as a feature test,
from userspace.

Signed-off-by: Tommi Virtanen 
Signed-off-by: Sage Weil

libceph: Get secret from the kernel keys api when mounting with key=NAME.

2011-03-29T19:11:19+00:00

Signed-off-by: Tommi Virtanen 
Signed-off-by: Sage Weil

ceph: Move secret key parsing earlier.

2011-03-29T19:11:16+00:00

This makes the base64 logic be contained in mount option parsing,
and prepares us for replacing the homebew key management with the
kernel key retention service.

Signed-off-by: Tommi Virtanen 
Signed-off-by: Sage Weil