linux-stable.git/net/can/raw.c, branch linux-3.3.y

can: remove references to berlios mailinglist

2011-10-17T23:22:46+00:00

The BerliOS project, which currently hosts our mailinglist, will
close with the end of the year. Now take the chance and remove all
occurrences of the mailinglist address from the source files.

Signed-off-by: Marc Kleine-Budde 
Signed-off-by: David S. Miller

can: make struct can_proto const

2011-05-04T21:08:36+00:00

commit 53914b67993c724cec585863755c9ebc8446e83b had the
same message. That commit did put everything in place but
did not make can_proto const itself.

Signed-off-by: Kurt Van Dijck 
Acked-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can: add missing socket check in can/raw release

2011-04-20T19:37:59+00:00

v2: added space after 'if' according code style.

We can get here with a NULL socket argument passed from userspace,
so we need to handle it accordingly.

Thanks to Dave Jones pointing at this issue in net/can/bcm.c

Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can: make struct proto const

2011-03-28T06:34:59+00:00

can_ioctl is the only reason for struct proto to be non-const.
script/check-patch.pl suggests struct proto be const.

Setting the reference to the common can_ioctl() in all CAN protocols directly
removes the need to make the struct proto writable in af_can.c

Signed-off-by: Kurt Van Dijck 
Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can: test size of struct sockaddr in sendmsg

2011-01-16T04:56:42+00:00

This patch makes the CAN socket code conform to the manpage of sendmsg.

Signed-off-by: Kurt Van Dijck 
Acked-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can-raw: add msg_flags to distinguish local traffic

2010-10-21T11:27:03+00:00

CAN has no addressing scheme. It is currently impossible for userspace
to tell is a received CAN frame comes from another process on the local
host, or from a remote CAN device.

This patch add support for userspace applications to distinguish between
'own', 'local' and 'remote' CAN traffic. The distinction is made by returning
flags in msg->msg_flags in the call to recvmsg().

The added documentation explains the introduced flags.

Signed-off-by: Kurt Van Dijck 
Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

net: simplify flags for tx timestamping

2010-08-19T07:08:30+00:00

This patch removes the abstraction introduced by the union skb_shared_tx in
the shared skb data.

The access of the different union elements at several places led to some
confusion about accessing the shared tx_flags e.g. in skb_orphan_try().

    http://marc.info/?l=linux-netdev&m=128084897415886&w=2

Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can-raw: Fix skb_orphan_try handling

2010-08-03T07:31:48+00:00

Commit fc6055a5ba31e2c14e36e8939f9bf2b6d586a7f5 (net: Introduce
skb_orphan_try()) allows an early orphan of the skb and takes care on
tx timestamping, which needs the sk-reference in the skb on driver level.
So does the can-raw socket, which has not been taken into account here.

The patch below adds a 'prevent_sk_orphan' bit in the skb tx shared info,
which fixes the problem discovered by Matthias Fuchs here:

      http://marc.info/?t=128030411900003&r=1&w=2

Even if it's not a primary tx timestamp topic it fits well into some skb
shared tx context. Or should be find a different place for the information to
protect the sk reference until it reaches the driver level?

Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

net/can: Use memdup_user

2010-05-31T07:24:11+00:00

Use memdup_user when user data is immediately copied into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@

-  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+  to = memdup_user(from,size);
   if (
-      to==NULL
+      IS_ERR(to)
                 || ...) {
   <+... when != goto l1;
-  -ENOMEM
+  PTR_ERR(to)
   ...+>
   }
-  if (copy_from_user(to, from, size) != 0) {
-    <+... when != goto l2;
-    -EFAULT
-    ...+>
-  }
// 

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

can: avoids a false warning

2010-04-13T10:03:14+00:00

At this point optlen == sizeof(sfilter) but some compilers are dumb.

Reported-by: Németh Márton 
Acked-by: Oliver Hartkopp 
Signed-off-by: David S. Miller