linux-stable.git/net/bridge/br_stp_timer.c, branch linux-3.2.y

bridge: fix race with topology change timer

2013-05-30T13:35:12+00:00

[ Upstream commit 83401eb4990ff6af55aeed8f49681558544192e6 ]

A bridge should only send topology change notice if it is not
the root bridge. It is possible for message age timer to elect itself
as a new root bridge, and still have a topology change timer running
but waiting for bridge lock on other CPU.

Solve the race by checking if we are root bridge before continuing.
This was the root cause of the cases where br_send_tcn_bpdu would OOPS.

Reported-by: JerryKang 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

bridge: add notification over netlink when STP changes state

2011-07-23T00:01:12+00:00

When STP changes state of interface need to send a new link
message to reflect that change.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: control carrier based on ports online

2011-03-14T21:29:02+00:00

This makes the bridge device behave like a physical device.
In earlier releases the bridge always asserted carrier. This
changes the behavior so that bridge device carrier is on only
if one or more ports are in the forwarding state. This
should help IPv6 autoconfiguration, DHCP, and routing daemons.

I did brief testing with Network and Virt manager and they
seem fine, but since this changes behavior of bridge, it should
wait until net-next (2.6.39).

Signed-off-by: Stephen Hemminger 
Reviewed-by: Nicolas de Pesloüan 
Tested-By: Adam Majer 
Signed-off-by: David S. Miller

bridge: change console message interface

2010-05-16T06:10:02+00:00

Use one set of macro's for all bridge messages.

Note: can't use netdev_XXX macro's because bridge is purely
virtual and has no device parent.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: remove CVS keywords

2008-06-12T04:00:38+00:00

This patch removes CVS keywords that weren't updated for a long time
from comments.

Signed-off-by: Adrian Bunk 
Signed-off-by: David S. Miller

[BRIDGE]: Round off STP perodic timers.

2007-05-31T08:23:39+00:00

Peroidic STP timers don't have to be exact.  The hold timer runs at
1HZ, and the hello timer normally runs at 2HZ; save power by aligning
it them to next second.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

header cleaning: don't include smp_lock.h when not used

2007-05-08T18:15:07+00:00

Remove includes of  where it is not used/needed.
Suggested by Al Viro.

Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc,
sparc64, and arm (all 59 defconfigs).

Signed-off-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[NET] BRIDGE: Fix whitespace errors.

2007-02-11T07:19:23+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[BRIDGE]: use setup_timer

2006-03-21T06:56:38+00:00

Use the now standard setup_timer function.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[BRIDGE]: remove unneeded bh disables

2006-03-21T06:56:25+00:00

The STP timers run off softirq (kernel timers), so there is no need to
disable bottom half in the spin locks.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller