linux-stable.git/net/bluetooth/sco.c, branch linux-3.2.y

bluetooth: Validate socket address length in sco_sock_bind().

2015-12-30T02:26:03+00:00

[ Upstream commit 5233252fce714053f0151680933571a2da9cbfb4 ]

Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

Bluetooth: never linger on process exit

2014-09-13T22:41:38+00:00

commit 093facf3634da1b0c2cc7ed106f1983da901bbab upstream.

If the current process is exiting, lingering on socket close will make
it unkillable, so we should avoid it.

Reproducer:

  #include 
  #include 

  #define BTPROTO_L2CAP   0
  #define BTPROTO_SCO     2
  #define BTPROTO_RFCOMM  3

  int main()
  {
          int fd;
          struct linger ling;

          fd = socket(PF_BLUETOOTH, SOCK_STREAM, BTPROTO_RFCOMM);
          //or: fd = socket(PF_BLUETOOTH, SOCK_DGRAM, BTPROTO_L2CAP);
          //or: fd = socket(PF_BLUETOOTH, SOCK_SEQPACKET, BTPROTO_SCO);

          ling.l_onoff = 1;
          ling.l_linger = 1000000000;
          setsockopt(fd, SOL_SOCKET, SO_LINGER, &ling, sizeof(ling));

          return 0;
  }

Signed-off-by: Vladimir Davydov 
Signed-off-by: Marcel Holtmann 
Signed-off-by: Ben Hutchings

bluetooth: Properly clone LSM attributes to newly created child connections

2011-10-19T03:36:43+00:00

The Bluetooth stack has internal connection handlers for all of the various
Bluetooth protocols, and unfortunately, they are currently lacking the LSM
hooks found in the core network stack's connection handlers.  I say
unfortunately, because this can cause problems for users who have have an
LSM enabled and are using certain Bluetooth devices.  See one problem
report below:

 * http://bugzilla.redhat.com/show_bug.cgi?id=741703

In order to keep things simple at this point in time, this patch fixes the
problem by cloning the parent socket's LSM attributes to the newly created
child socket.  If we decide we need a more elaborate LSM marking mechanism
for Bluetooth (I somewhat doubt this) we can always revisit this decision
in the future.

Reported-by: James M. Cape 
Signed-off-by: Paul Moore 
Acked-by: James Morris 
Signed-off-by: David S. Miller

Bluetooth: sco: Fix lost wakeups waiting to accept socket

2011-08-11T22:50:26+00:00

Fix race conditions which can cause lost wakeups (or missed signals)
while waiting to accept a sco socket connection.

Signed-off-by: Peter Hurley 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Rename function bt_err to bt_to_errno

2011-06-30T21:44:08+00:00

Make it easier to use more normal logging styles later.

Signed-off-by: Joe Perches 
Signed-off-by: Gustavo F. Padovan

Bluetooth: fix shutdown on SCO sockets

2011-06-09T18:30:01+00:00

shutdown should wait for SCO link to be properly disconnected before
detroying the socket, otherwise an application using the socket may
assume link is properly disconnected before it really happens which
can be a problem when e.g synchronizing profile switch.

Signed-off-by: Luiz Augusto von Dentz 
Signed-off-by: Gustavo F. Padovan

Revert "Bluetooth: fix shutdown on SCO sockets"

2011-05-12T01:58:16+00:00

This reverts commit f21ca5fff6e548833fa5ee8867239a8378623150.

Quoth Gustavo F. Padovan:
  "Commit f21ca5fff6e548833fa5ee8867239a8378623150 can cause a NULL
   dereference if we call shutdown in a bluetooth SCO socket and doesn't
   wait the shutdown completion to call close().  Please revert it.  I
   may have a fix for it soon, but we don't have time anymore, so revert
   is the way to go.  ;)"

Requested-by: Gustavo F. Padovan 
Signed-off-by: Linus Torvalds

Bluetooth: fix shutdown on SCO sockets

2011-04-18T23:11:46+00:00

shutdown should wait for SCO link to be properly disconnected before
detroying the socket, otherwise an application using the socket may
assume link is properly disconnected before it really happens which
can be a problem when e.g synchronizing profile switch.

Signed-off-by: Luiz Augusto von Dentz 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Use ERR_PTR as return error from hci_connect

2011-02-27T20:11:29+00:00

Use ERR_PTR mechanism to return error from hci_connect.

Signed-off-by: Ville Tervo 
Signed-off-by: Anderson Briglia 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Merge L2CAP and SCO modules into bluetooth.ko

2011-02-14T20:27:36+00:00

Actually doesn't make sense have these modules built separately.
The L2CAP layer is needed by almost all Bluetooth protocols and profiles.
There isn't any real use case without having L2CAP loaded.
SCO is only essential for Audio transfers, but it is so small that we can
have it loaded always in bluetooth.ko without problems.
If you really doesn't want it you can disable SCO in the kernel config.

Signed-off-by: Gustavo F. Padovan