linux-stable.git/net/bluetooth/hidp, branch linux-4.0.y

Bluetooth: hidp_connection_add() unsafe use of l2cap_pi()

2014-12-19T12:40:07+00:00

it's OK after we'd verified the sockets, but not before that.

Signed-off-by: Al Viro 
Signed-off-by: Marcel Holtmann

Bluetooth: hidp: replace kzalloc/copy_from_user by memdup_user

2014-11-15T00:30:16+00:00

use memdup_user for rd_data import.

Signed-off-by: Fabian Frederick 
Signed-off-by: Marcel Holtmann

Bluetooth: Introduce BT_BREDR and BT_LE config options

2014-11-02T08:01:53+00:00

The current kernel options do not make it clear which modules are for
Bluetooth Classic (BR/EDR) and which are for Bluetooth Low Energy (LE).

To make it really clear, introduce BT_BREDR and BT_LE options with
proper dependencies into the different modules. Both new options
default to y to not create a regression with previous kernel config
files.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Improve *_get() functions to return the object type

2014-09-08T17:07:52+00:00

It's natural to have *_get() functions that increment the reference
count of an object to return the object type itself. This way it's
simple to make a copy of the object pointer and increase the reference
count in a single step. This patch updates two such get() functions,
namely hci_conn_get() and l2cap_conn_get(), and updates the users to
take advantage of the new API.

Signed-off-by: Johan Hedberg 
Signed-off-by: Marcel Holtmann

Bluetooth: Fix sparse warning from HID new leds handling

2014-07-30T17:28:41+00:00

The new leds bit handling produces this spares warning.

  CHECK   net/bluetooth/hidp/core.c
net/bluetooth/hidp/core.c:156:60: warning: dubious: x | !y

Just fix it by doing an explicit x << 0 shift operation.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Merge branch 'for-3.15/hid-core-ll-transport-cleanup' into for-linus

2014-04-01T17:05:09+00:00

Conflicts:
	drivers/hid/hid-ids.h
	drivers/hid/hid-sony.c
	drivers/hid/i2c-hid/i2c-hid.c

Merge branch 'for-3.15/ll-driver-new-callbacks' into for-linus

2014-04-01T16:56:24+00:00

HID: remove hid_output_raw_report transport implementations

2014-03-14T14:30:24+00:00

Nobody calls hid_output_raw_report anymore, and nobody should.
We can now remove the various implementation in the different
transport drivers and the declarations.

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: hidp: Add a comment that some devices depend on the current behavior of uniq

2014-02-24T16:38:46+00:00

Add a comment noting that some devices depend on the destination address being
stored in uniq.

Signed-off-by: Frank Praznik 
Reviewed-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: Bluetooth: hidp: make sure input buffers are big enough

2014-02-17T20:17:55+00:00

HID core expects the input buffers to be at least of size 4096
(HID_MAX_BUFFER_SIZE). Other sizes will result in buffer-overflows if an
input-report is smaller than advertised. We could, like i2c, compute the
biggest report-size instead of using HID_MAX_BUFFER_SIZE, but this will
blow up if report-descriptors are changed after ->start() has been called.
So lets be safe and just use the biggest buffer we have.

Note that this adds an additional copy to the HIDP input path. If there is
a way to make sure the skb-buf is big enough, we should use that instead.

The best way would be to make hid-core honor the @size argument, though,
that sounds easier than it is. So lets just fix the buffer-overflows for
now and afterwards look for a faster way for all transport drivers.

Signed-off-by: David Herrmann 
Signed-off-by: Jiri Kosina