linux-stable.git/net/bluetooth/hidp, branch linux-3.17.y

Bluetooth: Fix sparse warning from HID new leds handling

2014-07-30T17:28:41+00:00

The new leds bit handling produces this spares warning.

  CHECK   net/bluetooth/hidp/core.c
net/bluetooth/hidp/core.c:156:60: warning: dubious: x | !y

Just fix it by doing an explicit x << 0 shift operation.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Merge branch 'for-3.15/hid-core-ll-transport-cleanup' into for-linus

2014-04-01T17:05:09+00:00

Conflicts:
	drivers/hid/hid-ids.h
	drivers/hid/hid-sony.c
	drivers/hid/i2c-hid/i2c-hid.c

Merge branch 'for-3.15/ll-driver-new-callbacks' into for-linus

2014-04-01T16:56:24+00:00

HID: remove hid_output_raw_report transport implementations

2014-03-14T14:30:24+00:00

Nobody calls hid_output_raw_report anymore, and nobody should.
We can now remove the various implementation in the different
transport drivers and the declarations.

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: hidp: Add a comment that some devices depend on the current behavior of uniq

2014-02-24T16:38:46+00:00

Add a comment noting that some devices depend on the destination address being
stored in uniq.

Signed-off-by: Frank Praznik 
Reviewed-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: Bluetooth: hidp: make sure input buffers are big enough

2014-02-17T20:17:55+00:00

HID core expects the input buffers to be at least of size 4096
(HID_MAX_BUFFER_SIZE). Other sizes will result in buffer-overflows if an
input-report is smaller than advertised. We could, like i2c, compute the
biggest report-size instead of using HID_MAX_BUFFER_SIZE, but this will
blow up if report-descriptors are changed after ->start() has been called.
So lets be safe and just use the biggest buffer we have.

Note that this adds an additional copy to the HIDP input path. If there is
a way to make sure the skb-buf is big enough, we should use that instead.

The best way would be to make hid-core honor the @size argument, though,
that sounds easier than it is. So lets just fix the buffer-overflows for
now and afterwards look for a faster way for all transport drivers.

Signed-off-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: remove hid_get_raw_report in struct hid_device

2014-02-17T13:05:58+00:00

dev->hid_get_raw_report(X) and hid_hw_raw_request(X, HID_REQ_GET_REPORT)
are strictly equivalent. Switch the hid subsystem to the hid_hw notation
and remove the field .hid_get_raw_report in struct hid_device.

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: HIDp: remove duplicated coded

2014-02-17T13:05:56+00:00

- Move hidp_output_report() above
- Removed duplicated code in hidp_output_raw_report()

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: HIDp: remove hidp_hidinput_event

2014-02-17T13:05:56+00:00

hidp uses its own ->hidinput_input_event() instead of the generic binding
in hid-input.
Moving the handling of LEDs towards hidp_hidinput_event() allows two things:
- remove hidinput_input_event definitively from struct hid_device
- hidraw user space programs can also set the LEDs

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: Add the transport-driver functions to the HIDP driver.

2014-01-29T13:23:43+00:00

Add raw_request, set_raw_report and output_report transport-driver functions to
the HIDP driver.

Signed-off-by: Frank Praznik 
Acked-by: David Herrmann 
Signed-off-by: Jiri Kosina