linux-stable.git/net/atm, branch v5.16.2

net: atm: use address setting helpers

2021-10-24T12:59:45+00:00

Get it ready for constant netdev->dev_addr.

Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

ethernet: replace netdev->dev_addr assignment loops

2021-10-14T16:22:25+00:00

A handful of drivers contains loops assigning the mac
addr byte by byte. Convert those to eth_hw_addr_set().

Signed-off-by: Jakub Kicinski

net: use dev_addr_set()

2021-10-09T10:55:01+00:00

Use dev_addr_set() instead of writing directly to netdev->dev_addr
in various misc and old drivers.

Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

atm: Use list_for_each_entry() to simplify code in resources.c

2021-06-10T21:08:09+00:00

Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot 
Signed-off-by: Wang Hai 
Signed-off-by: David S. Miller

atm: [br2864] fix spelling mistakes

2021-06-07T20:17:37+00:00

interrupt should be changed to interrupting.

Signed-off-by: gushengxian 
Signed-off-by: David S. Miller

net: atm: use DEVICE_ATTR_RO macro

2021-05-20T22:50:54+00:00

Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing 
Signed-off-by: David S. Miller

net: atm: pppoatm: use new API for wakeup tasklet

2021-01-30T02:24:05+00:00

This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")

Signed-off-by: Emil Renner Berthing 
Link: https://lore.kernel.org/r/20210127173256.13954-2-kernel@esmil.dk
Signed-off-by: Jakub Kicinski

net: atm: pppoatm: use tasklet_init to initialize wakeup tasklet

2021-01-30T02:24:05+00:00

Previously a temporary tasklet structure was initialized on the stack
using DECLARE_TASKLET_OLD() and then copied over and modified. Nothing
else in the kernel seems to use this pattern, so let's just call
tasklet_init() like everyone else.

Signed-off-by: Emil Renner Berthing 
Link: https://lore.kernel.org/r/20210127173256.13954-1-kernel@esmil.dk
Signed-off-by: Jakub Kicinski

atm: nicstar: Replace in_interrupt() usage

2020-11-19T00:43:55+00:00

push_scqe() uses in_interrupt() to figure out if it is allowed to sleep.

The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

Aside of that in_interrupt() is not correct as it does not catch preempt
disabled regions which neither can sleep.

ns_send() (the only caller of push_scqe()) has the following callers:

- vcc_sendmsg() used as proto_ops::sendmsg is expected to be invoked in
  preemtible context.
  -> vcc->dev->ops->send() (ns_send())

- atm_vcc::send via atmdev_ops::send either directly (pointer copied by
  atm_init_aal34() or atm_init_aal5()) or via atm_send_aal0().
  This is invoked by drivers (like br2684, clip, pppoatm, ...) which are
  called from net_device_ops::ndo_start_xmit with BH disabled.

Add atmdev_ops::send_bh which is used by callers from BH context
(atm_send_aal*()) and if this callback missing then ::send is used
instead.
Implement this callback in nicstar and use it to replace in_interrupt().

Cc: Chas Williams <3chas3@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Jakub Kicinski

net: atm: fix update of position index in lec_seq_next

2020-10-31T19:26:30+00:00

The position index in leq_seq_next is not updated when the next
entry is fetched an no more entries are available. This causes
seq_file to report the following error:

"seq_file: buggy .next function lec_seq_next [lec] did not update
 position index"

Fix this by always updating the position index.

[ Note: this is an ancient 2002 bug, the sha is from the
  tglx/history repo ]

Fixes 4aea2cbff417 ("[ATM]: Move lan seq_file ops to lec.c [1/3]")
Signed-off-by: Colin Ian King 
Link: https://lore.kernel.org/r/20201027114925.21843-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski