linux-stable.git/lib/iov_iter.c, branch v6.0.2 Linux kernel stable tree fix copy_page_from_iter() for compound destinations 2022-08-09T02:37:26+00:00 Al Viro viro@zeniv.linux.org.uk 2022-07-29T16:54:53+00:00 c03f05f183cd15f4259684ab658fbc3d23797d99 had been broken for ITER_BVEC et.al. since ever (OK, v3.17 when ITER_BVEC had first appeared)... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
had been broken for ITER_BVEC et.al. since ever (OK, v3.17 when
ITER_BVEC had first appeared)...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
copy_page_to_iter(): don't split high-order page in case of ITER_PIPE 2022-08-09T02:37:25+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-23T21:21:37+00:00 f0f6b614f83dbae99d283b7b12ab5dd2e04df979 ... just shove it into one pipe_buffer. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
... just shove it into one pipe_buffer.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
expand those iov_iter_advance()... 2022-08-09T02:37:25+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-11T08:04:33+00:00 310d9d5a5009a93377200b98daa2d84aa2bd8160 Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
pipe_get_pages(): switch to append_pipe() 2022-08-09T02:37:25+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-14T20:38:53+00:00 746de1f86fcd33464acac047f111eea877f2f7a0 now that we are advancing the iterator, there's no need to treat the first page separately - just call append_pipe() in a loop. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
now that we are advancing the iterator, there's no need to
treat the first page separately - just call append_pipe()
in a loop.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
get rid of non-advancing variants 2022-08-09T02:37:24+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-10T17:05:12+00:00 eba2d3d798295dc43cae8fade102f9d083a2a741 mechanical change; will be further massaged in subsequent commits Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
mechanical change; will be further massaged in subsequent commits

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
iov_iter: saner helper for page array allocation 2022-08-09T02:37:22+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-17T18:45:41+00:00 3cf42da327f26eb4461864dd64812345b37f4fd9 All call sites of get_pages_array() are essenitally identical now. Replace with common helper... Returns number of slots available in resulting array or 0 on OOM; it's up to the caller to make sure it doesn't ask to zero-entry array (i.e. neither maxpages nor size are allowed to be zero). Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
All call sites of get_pages_array() are essenitally identical now.
Replace with common helper...

Returns number of slots available in resulting array or 0 on OOM;
it's up to the caller to make sure it doesn't ask to zero-entry
array (i.e. neither maxpages nor size are allowed to be zero).

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fold __pipe_get_pages() into pipe_get_pages() 2022-08-09T02:37:21+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-17T18:30:39+00:00 8520008417c581c4c22e39597f92b9814ae34c31 ... and don't mangle maxsize there - turn the loop into counting one instead. Easier to see that we won't run out of array that way. Note that special treatment of the partial buffer in that thing is an artifact of the non-advancing semantics of iov_iter_get_pages() - if not for that, it would be append_pipe(), same as the body of the loop that follows it. IOW, once we make iov_iter_get_pages() advancing, the whole thing will turn into calculate how many pages do we want allocate an array (if needed) call append_pipe() that many times. Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
... and don't mangle maxsize there - turn the loop into counting
one instead.  Easier to see that we won't run out of array that
way.  Note that special treatment of the partial buffer in that
thing is an artifact of the non-advancing semantics of
iov_iter_get_pages() - if not for that, it would be append_pipe(),
same as the body of the loop that follows it.  IOW, once we make
iov_iter_get_pages() advancing, the whole thing will turn into
	calculate how many pages do we want
	allocate an array (if needed)
	call append_pipe() that many times.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
ITER_XARRAY: don't open-code DIV_ROUND_UP() 2022-08-09T02:37:21+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-11T00:30:35+00:00 0aa4fc32f54028f6fbb35bf71df4b0d86ff1662b Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
unify the rest of iov_iter_get_pages()/iov_iter_get_pages_alloc() guts 2022-08-09T02:37:21+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-17T17:54:15+00:00 451c0ba9475ebdce36249c5c769efa5d580d1d83 same as for pipes and xarrays; after that iov_iter_get_pages() becomes a wrapper for __iov_iter_get_pages_alloc(). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
same as for pipes and xarrays; after that iov_iter_get_pages() becomes
a wrapper for __iov_iter_get_pages_alloc().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
unify xarray_get_pages() and xarray_get_pages_alloc() 2022-08-09T02:37:20+00:00 Al Viro viro@zeniv.linux.org.uk 2022-06-17T17:48:03+00:00 68fe506f3731ecf7881de9512cc5f4c14fd13f3a same as for pipes Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
same as for pipes

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>