linux-stable.git/kernel/time/clocksource.c, branch v5.10.78

clocksource: Check per-CPU clock synchronization when marked unstable

2021-07-14T14:56:01+00:00

[ Upstream commit 7560c02bdffb7c52d1457fa551b9e745d4b9e754 ]

Some sorts of per-CPU clock sources have a history of going out of
synchronization with each other.  However, this problem has purportedy been
solved in the past ten years.  Except that it is all too possible that the
problem has instead simply been made less likely, which might mean that
some of the occasional "Marking clocksource 'tsc' as unstable" messages
might be due to desynchronization.  How would anyone know?

Therefore apply CPU-to-CPU synchronization checking to newly unstable
clocksource that are marked with the new CLOCK_SOURCE_VERIFY_PERCPU flag.
Lists of desynchronized CPUs are printed, with the caveat that if it
is the reporting CPU that is itself desynchronized, it will appear that
all the other clocks are wrong.  Just like in real life.

Reported-by: Chris Mason 
Signed-off-by: Paul E. McKenney 
Signed-off-by: Thomas Gleixner 
Acked-by: Feng Tang 
Link: https://lore.kernel.org/r/20210527190124.440372-2-paulmck@kernel.org
Signed-off-by: Sasha Levin

clocksource: Retry clock read if long delays detected

2021-07-14T14:56:01+00:00

[ Upstream commit db3a34e17433de2390eb80d436970edcebd0ca3e ]

When the clocksource watchdog marks a clock as unstable, this might be due
to that clock being unstable or it might be due to delays that happen to
occur between the reads of the two clocks.  Yes, interrupts are disabled
across those two reads, but there are no shortage of things that can delay
interrupts-disabled regions of code ranging from SMI handlers to vCPU
preemption.  It would be good to have some indication as to why the clock
was marked unstable.

Therefore, re-read the watchdog clock on either side of the read from the
clock under test.  If the watchdog clock shows an excessive time delta
between its pair of reads, the reads are retried.

The maximum number of retries is specified by a new kernel boot parameter
clocksource.max_cswd_read_retries, which defaults to three, that is, up to
four reads, one initial and up to three retries.  If more than one retry
was required, a message is printed on the console (the occasional single
retry is expected behavior, especially in guest OSes).  If the maximum
number of retries is exceeded, the clock under test will be marked
unstable.  However, the probability of this happening due to various sorts
of delays is quite small.  In addition, the reason (clock-read delays) for
the unstable marking will be apparent.

Reported-by: Chris Mason 
Signed-off-by: Paul E. McKenney 
Signed-off-by: Thomas Gleixner 
Acked-by: Feng Tang 
Link: https://lore.kernel.org/r/20210527190124.440372-1-paulmck@kernel.org
Signed-off-by: Sasha Levin

clocksource: Remove obsolete ifdef

2020-06-09T14:36:47+00:00

CONFIG_GENERIC_VDSO_CLOCK_MODE was a transitional config switch which got
removed after all architectures got converted to the new storage model.

But the removal forgot to remove the #ifdef which guards the
vdso_clock_mode sanity check, which effectively disables the sanity check.

Remove it now.

Fixes: f86fd32db706 ("lib/vdso: Cleanup clock mode storage leftovers")
Signed-off-by: Thomas Gleixner 
Tested-by: Miklos Szeredi 
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20200606221531.845475036@linutronix.de

clocksource: Add common vdso clock mode storage

2020-02-17T13:40:23+00:00

All architectures which use the generic VDSO code have their own storage
for the VDSO clock mode. That's pointless and just requires duplicate code.

Provide generic storage for it. The new Kconfig symbol is intermediate and
will be removed once all architectures are converted over.

Signed-off-by: Thomas Gleixner 
Tested-by: Vincenzo Frascino 
Reviewed-by: Vincenzo Frascino 
Link: https://lkml.kernel.org/r/20200207124403.028046322@linutronix.de

clocksource: Prevent double add_timer_on() for watchdog_timer

2020-02-01T10:07:56+00:00

Kernel crashes inside QEMU/KVM are observed:

  kernel BUG at kernel/time/timer.c:1154!
  BUG_ON(timer_pending(timer) || !timer->function) in add_timer_on().

At the same time another cpu got:

  general protection fault: 0000 [#1] SMP PTI of poinson pointer 0xdead000000000200 in:

  __hlist_del at include/linux/list.h:681
  (inlined by) detach_timer at kernel/time/timer.c:818
  (inlined by) expire_timers at kernel/time/timer.c:1355
  (inlined by) __run_timers at kernel/time/timer.c:1686
  (inlined by) run_timer_softirq at kernel/time/timer.c:1699

Unfortunately kernel logs are badly scrambled, stacktraces are lost.

Printing the timer->function before the BUG_ON() pointed to
clocksource_watchdog().

The execution of clocksource_watchdog() can race with a sequence of
clocksource_stop_watchdog() .. clocksource_start_watchdog():

expire_timers()
 detach_timer(timer, true);
  timer->entry.pprev = NULL;
 raw_spin_unlock_irq(&base->lock);
 call_timer_fn
  clocksource_watchdog()

					clocksource_watchdog_kthread() or
					clocksource_unbind()

					spin_lock_irqsave(&watchdog_lock, flags);
					clocksource_stop_watchdog();
					 del_timer(&watchdog_timer);
					 watchdog_running = 0;
					spin_unlock_irqrestore(&watchdog_lock, flags);

					spin_lock_irqsave(&watchdog_lock, flags);
					clocksource_start_watchdog();
					 add_timer_on(&watchdog_timer, ...);
					 watchdog_running = 1;
					spin_unlock_irqrestore(&watchdog_lock, flags);

  spin_lock(&watchdog_lock);
  add_timer_on(&watchdog_timer, ...);
   BUG_ON(timer_pending(timer) || !timer->function);
    timer_pending() -> true
    BUG()

I.e. inside clocksource_watchdog() watchdog_timer could be already armed.

Check timer_pending() before calling add_timer_on(). This is sufficient as
all operations are synchronized by watchdog_lock.

Fixes: 75c5158f70c0 ("timekeeping: Update clocksource with stop_machine")
Signed-off-by: Konstantin Khlebnikov 
Signed-off-by: Thomas Gleixner 
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/158048693917.4378.13823603769948933793.stgit@buzz

clocksource: Move inline keyword to the beginning of function declarations

2019-06-14T15:04:03+00:00

The inline keyword was not at the beginning of the function declarations.
Fix the following warnings triggered when using W=1:

  kernel/time/clocksource.c:108:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
  kernel/time/clocksource.c:113:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

Signed-off-by: Mathieu Malaterre 
Signed-off-by: Thomas Gleixner 
Cc: trivial@kernel.org
Cc: kernel-janitors@vger.kernel.org
Cc: John Stultz 
Cc: Stephen Boyd 
Link: https://lkml.kernel.org/r/20190524103339.28787-1-malat@debian.org

time: Remove license boilerplate

2018-11-23T10:51:21+00:00

The SPDX identifier defines the license of the files already. No need for
the boilerplates.

Signed-off-by: Thomas Gleixner 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Acked-by: Paul E. McKenney 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Peter Anvin 
Cc: Russell King 
Cc: Richard Cochran 
Cc: Nicolas Pitre 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Cc: Paul E. McKenney 
Link: https://lkml.kernel.org/r/20181031182253.132458951@linutronix.de

time: Add SPDX license identifiers

2018-11-23T10:51:20+00:00

Update the time(r) core files files with the correct SPDX license
identifier based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can be used instead of the
full boiler plate text.

This work is based on a script and data from Philippe Ombredanne, Kate
Stewart and myself. The data has been created with two independent license
scanners and manual inspection.

The following files do not contain any direct license information and have
been omitted from the big initial SPDX changes:

  timeconst.bc: The .bc files were not touched
  time.c, timer.c, timekeeping.c: Licence was deduced from EXPORT_SYMBOL_GPL

As those files do not contain direct license references they fall under the
project license, i.e. GPL V2 only.

Signed-off-by: Thomas Gleixner 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Russell King 
Cc: Richard Cochran 
Cc: Nicolas Pitre 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Cc: H. Peter Anvin 
Cc: Paul E. McKenney 
Link: https://lkml.kernel.org/r/20181031182252.879109557@linutronix.de

time: Remove useless filenames in top level comments

2018-11-23T10:51:20+00:00

Remove the pointless filenames in the top level comments. They have no
value at all and just occupy space. While at it tidy up some of the
comments and remove a stale one.

Signed-off-by: Thomas Gleixner 
Acked-by: Nicolas Pitre 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Peter Anvin 
Cc: Russell King 
Cc: Richard Cochran 
Cc: "Paul E. McKenney" 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Link: https://lkml.kernel.org/r/20181031182252.794898238@linutronix.de

clocksource: Provide clocksource_arch_init()

2018-10-04T21:00:24+00:00

Architectures have extra archdata in the clocksource, e.g. for VDSO
support. There are no sanity checks or general initializations for this
available. Add support for that.

Signed-off-by: Thomas Gleixner 
Acked-by: Andy Lutomirski 
Acked-by: John Stultz 
Cc: Peter Zijlstra 
Cc: Matt Rickard 
Cc: Stephen Boyd 
Cc: Florian Weimer 
Cc: "K. Y. Srinivasan" 
Cc: Vitaly Kuznetsov 
Cc: devel@linuxdriverproject.org
Cc: virtualization@lists.linux-foundation.org
Cc: Paolo Bonzini 
Cc: Arnd Bergmann 
Cc: Juergen Gross 
Link: https://lkml.kernel.org/r/20180917130706.973042587@linutronix.de