linux-stable.git/kernel/power/main.c, branch linux-5.4.y

PM: s2idle: ACPI: Fix wakeup interrupts handling

2022-02-16T11:52:50+00:00

commit cb1f65c1e1424a4b5e4a86da8aa3b8fd8459c8ec upstream.

After commit e3728b50cd9b ("ACPI: PM: s2idle: Avoid possible race
related to the EC GPE") wakeup interrupts occurring immediately after
the one discarded by acpi_s2idle_wake() may be missed.  Moreover, if
the SCI triggers again immediately after the rearming in
acpi_s2idle_wake(), that wakeup may be missed too.

The problem is that pm_system_irq_wakeup() only calls pm_system_wakeup()
when pm_wakeup_irq is 0, but that's not the case any more after the
interrupt causing acpi_s2idle_wake() to run until pm_wakeup_irq is
cleared by the pm_wakeup_clear() call in s2idle_loop().  However,
there may be wakeup interrupts occurring in that time frame and if
that happens, they will be missed.

To address that issue first move the clearing of pm_wakeup_irq to
the point at which it is known that the interrupt causing
acpi_s2idle_wake() to tun will be discarded, before rearming the SCI
for wakeup.  Moreover, because that only reduces the size of the
time window in which the issue may manifest itself, allow
pm_system_irq_wakeup() to register two second wakeup interrupts in
a row and, when discarding the first one, replace it with the second
one.  [Of course, this assumes that only one wakeup interrupt can be
discarded in one go, but currently that is the case and I am not
aware of any plans to change that.]

Fixes: e3728b50cd9b ("ACPI: PM: s2idle: Avoid possible race related to the EC GPE")
Cc: 5.4+  # 5.4+
Signed-off-by: Rafael J. Wysocki 
Signed-off-by: Greg Kroah-Hartman

PM: sleep: include for pm_wq

2019-10-10T09:11:56+00:00

Include the  for the definition of
pm_wq to avoid the following warning:

kernel/power/main.c:890:25: warning: symbol 'pm_wq' was not declared. Should it be static?

Signed-off-by: Ben Dooks 
Signed-off-by: Rafael J. Wysocki

PM: sleep: Replace strncmp() with str_has_prefix()

2019-08-16T12:18:53+00:00

Use str_has_prefix() instead of strncmp() which is less
straightforward in decode_state().

Signed-off-by: Chuhong Yuan 
[ rjw: Subject & changelog ]
Signed-off-by: Rafael J. Wysocki

PM/sleep: Expose suspend stats in sysfs

2019-08-05T10:03:18+00:00

Userspace can get suspend stats from the suspend stats debugfs node.
Since debugfs doesn't have stable ABI, expose suspend stats in
sysfs under /sys/power/suspend_stats.

Signed-off-by: Kalesh Singh 
Reviewed-by: Greg Kroah-Hartman 
Signed-off-by: Rafael J. Wysocki

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428

2019-06-05T15:37:16+00:00

Based on 1 normalized pattern(s):

  this file is released under the gplv2

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 68 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Armijn Hemel 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190531190114.292346262@linutronix.de
Signed-off-by: Greg Kroah-Hartman

PM / sleep: Measure the time of filesystems syncing

2019-04-02T08:53:19+00:00

Measure the filesystems sync time during system sleep more precisely.

Among other things, this allows the pr_cont() to be dropped from
ksys_sync_helper() and makes automatic system suspend and hibernation
profiling somewhat more straightforward.

Signed-off-by: Harry Pan 
[ rjw: Changelog ]
Signed-off-by: Rafael J. Wysocki

PM / sleep: Refactor filesystems sync to reduce duplication

2019-04-02T08:53:19+00:00

Create a common helper to sync filesystems for system suspend and
hibernation.

Signed-off-by: Harry Pan 
Acked-by: Pavel Machek 
[ rjw: Changelog ]
Signed-off-by: Rafael J. Wysocki

PM / sleep: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-12T22:23:58+00:00

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li 
Acked-by: Pavel Machek 
Signed-off-by: Rafael J. Wysocki

PM / reboot: Eliminate race between reboot and suspend

2018-08-06T10:35:20+00:00

At present, "systemctl suspend" and "shutdown" can run in parrallel. A
system can suspend after devices_shutdown(), and resume. Then the shutdown
task goes on to power off. This causes many devices are not really shut
off. Hence replacing reboot_mutex with system_transition_mutex (renamed
from pm_mutex) to achieve the exclusion. The renaming of pm_mutex as
system_transition_mutex can be better to reflect the purpose of the mutex.

Signed-off-by: Pingfan Liu 
Acked-by: Pavel Machek 
Signed-off-by: Rafael J. Wysocki

fix a series of Documentation/ broken file name references

2018-06-15T21:10:01+00:00

As files move around, their previous links break. Fix the
references for them.

Acked-by: Andy Shevchenko 
Signed-off-by: Mauro Carvalho Chehab 
Acked-by: Jonathan Corbet