linux-stable.git/kernel/irq/manage.c, branch linux-rolling-lts

genirq/cpuhotplug: Notify about affinity changes breaking the affinity mask

2026-03-04T12:19:40+00:00

[ Upstream commit dd9f6d30c64001ca4dde973ac04d8d155e856743 ]

During CPU offlining the interrupts affined to that CPU are moved to other
online CPUs, which might break the original affinity mask if the outgoing
CPU was the last online CPU in that mask. This change is not propagated to
irq_desc::affinity_notify(), which leaves users of the affinity notifier
mechanism with stale information.

Avoid this by scheduling affinity change notification work for interrupts
that were affined to the CPU being offlined, if the new target CPU is not
part of the original affinity mask.

Since irq_set_affinity_locked() uses the same logic to schedule affinity
change notification work, split out this logic into a dedicated function
and use that at both places.

[ tglx: Removed the EXPORT(), removed the !SMP stub, moved the prototype,
  	added a lockdep assert instead of a comment, fixed up coding style
  	and name space. Polished and clarified the change log ]

Signed-off-by: Imran Khan 
Signed-off-by: Thomas Gleixner 
Link: https://patch.msgid.link/20260113143727.1041265-1-imran.f.khan@oracle.com
Signed-off-by: Sasha Levin

genirq/manage: Add buslock back in to enable_irq()

2025-10-24T09:38:39+00:00

The locking was changed from a buslock to a plain lock, but the patch
description states there was no functional change. Assuming this was
accidental so reverting to using the buslock.

Fixes: bddd10c55407 ("genirq/manage: Rework enable_irq()")
Signed-off-by: Charles Keepax 
Signed-off-by: Thomas Gleixner 
Link: https://patch.msgid.link/20251023154901.1333755-4-ckeepax@opensource.cirrus.com

genirq/manage: Add buslock back in to __disable_irq_nosync()

2025-10-24T09:38:39+00:00

The locking was changed from a buslock to a plain lock, but the patch
description states there was no functional change. Assuming this was
accidental so reverting to using the buslock.

Fixes: 1b7444446724 ("genirq/manage: Rework __disable_irq_nosync()")
Signed-off-by: Charles Keepax 
Signed-off-by: Thomas Gleixner 
Link: https://patch.msgid.link/20251023154901.1333755-3-ckeepax@opensource.cirrus.com

genirq/manage: Use the correct lock guard in irq_set_irq_wake()

2025-05-14T10:05:58+00:00

Commit 8589e325ba4f ("genirq/manage: Rework irq_set_irq_wake()") updated
the irq_set_irq_wake() to use the new guards for locking the interrupt
descriptor.

However, in doing so it inadvertently changed irq_set_irq_wake() such that
the 'chip_bus_lock' is no longer acquired. This has caused system suspend
tests to fail on some Tegra platforms.

Fix this by correcting the guard used in irq_set_irq_wake() to ensure the
'chip_bus_lock' is held.

Fixes: 8589e325ba4f ("genirq/manage: Rework irq_set_irq_wake()")
Signed-off-by: Jon Hunter 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/all/20250514095041.1109783-1-jonathanh@nvidia.com

genirq: Use scoped_guard() to shut clang up

2025-05-07T15:08:44+00:00

This code pattern trips clang up:

     if (fail)
     	goto undo;

     guard(lock)(lock);
     do_stuff();
     return 0;

undo:
     ...

as it somehow extends the scope of the guard beyond the return statement.

Replace it with a scoped guard to help it to get its act together.

Reported-by: kernel test robot 
Signed-off-by: Thomas Gleixner 
Closes: https://lore.kernel.org/oe-kbuild-all/202505071809.ajpPxfoZ-lkp@intel.com/

genirq: Remove unused remove_percpu_irq()

2025-05-07T09:35:41+00:00

remove_percpu_irq() has been unused since it was added in 2011 by
commit 31d9d9b6d830 ("genirq: Add support for per-cpu dev_id interrupts")

Remove it.

Signed-off-by: Dr. David Alan Gilbert 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/all/20250420164656.112641-1-linux@treblig.org

genirq/manage: Rework irq_set_irqchip_state()

2025-05-07T07:08:16+00:00

Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

No functional change.

Signed-off-by: Thomas Gleixner 
Acked-by: Peter Zijlstra (Intel) 
Link: https://lore.kernel.org/all/20250429065422.670808288@linutronix.de

genirq/manage: Rework irq_get_irqchip_state()

2025-05-07T07:08:16+00:00

Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

No functional change.

Signed-off-by: Thomas Gleixner 
Acked-by: Peter Zijlstra (Intel) 
Link: https://lore.kernel.org/all/20250429065422.612184618@linutronix.de

genirq/manage: Rework teardown_percpu_nmi()

2025-05-07T07:08:16+00:00

Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

No functional change.

Signed-off-by: Thomas Gleixner 
Acked-by: Peter Zijlstra (Intel) 
Link: https://lore.kernel.org/all/20250429065422.552884529@linutronix.de

genirq/manage: Rework prepare_percpu_nmi()

2025-05-07T07:08:16+00:00

Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

No functional change.

Signed-off-by: Thomas Gleixner 
Acked-by: Peter Zijlstra (Intel) 
Link: https://lore.kernel.org/all/20250429065422.494561120@linutronix.de