linux-stable.git/kernel/dma/coherent.c, branch linux-5.4.y

dma-mapping: clear dev->dma_mem to NULL after freeing it

2024-01-25T22:34:25+00:00

[ Upstream commit b07bc2347672cc8c7293c64499f1488278c5ca3d ]

Reproduced with below sequence:
dma_declare_coherent_memory()->dma_release_coherent_memory()
->dma_declare_coherent_memory()->"return -EBUSY" error

It will return -EBUSY from the dma_assign_coherent_memory()
in dma_declare_coherent_memory(), the reason is that dev->dma_mem
pointer has not been set to NULL after it's freed.

Fixes: cf65a0f6f6ff ("dma-mapping: move all DMA mapping code to kernel/dma")
Signed-off-by: Joakim Zhang 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Sasha Levin

dma-coherent: fix integer overflow in the reserved-memory dma allocation

2020-04-23T08:36:30+00:00

[ Upstream commit 286c21de32b904131f8cf6a36ce40b8b0c9c5da3 ]

pageno is an int and the PAGE_SHIFT shift is done on an int,
overflowing if the memory is bigger than 2G

This can be reproduced using for example a reserved-memory of 4G

reserved-memory {
		    #address-cells = <2>;
		    #size-cells = <2>;
		    ranges;

		    reserved_dma: buffer@0 {
		        compatible = "shared-dma-pool";
		        no-map;
		        reg = <0x5 0x00000000 0x1 0x0>;
        };
};

Signed-off-by: Kevin Grandemange 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Sasha Levin

dma-mapping: fix handling of dma-ranges for reserved memory (again)

2020-01-04T18:17:00+00:00

[ Upstream commit a445e940ea686fc60475564009821010eb213be3 ]

Daniele reported that issue previously fixed in c41f9ea998f3
("drivers: dma-coherent: Account dma_pfn_offset when used with device
tree") reappear shortly after 43fc509c3efb ("dma-coherent: introduce
interface for default DMA pool") where fix was accidentally dropped.

Lets put fix back in place and respect dma-ranges for reserved memory.

Fixes: 43fc509c3efb ("dma-coherent: introduce interface for default DMA pool")

Reported-by: Daniele Alessandrelli 
Tested-by: Daniele Alessandrelli 
Tested-by: Alexandre Torgue 
Signed-off-by: Vladimir Murzin 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Sasha Levin

dma-mapping: remove the dma_declare_coherent_memory export

2019-09-04T09:13:19+00:00

dma_declare_coherent_memory is something that the platform setup code
(which pretty much means the device tree these days) need to do so that
drivers can use the memory as declared by the platform.  Drivers
themselves have no business calling this function.

Signed-off-by: Christoph Hellwig

dma-mapping: remove the dma_mmap_from_dev_coherent export

2019-09-04T09:13:19+00:00

dma_mmap_from_dev_coherent is only used by dma_map_ops instances,
none of which is modular.

Signed-off-by: Christoph Hellwig

dma-mapping: remove dma_release_declared_memory

2019-09-04T09:13:19+00:00

This function is entirely unused given that declared memory is
generally provided by platform setup code.

Signed-off-by: Christoph Hellwig

dma-mapping: remove the DMA_MEMORY_EXCLUSIVE flag

2019-02-20T14:27:00+00:00

All users of dma_declare_coherent want their allocations to be
exclusive, so default to exclusive allocations.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Greg Kroah-Hartman

dma-mapping: remove dma_mark_declared_memory_occupied

2019-02-20T14:27:00+00:00

This API is not used anywhere, so remove it.

Signed-off-by: Christoph Hellwig

dma-mapping: remove an incorrect __iommem annotation

2019-02-13T18:19:50+00:00

memmap return a regular void pointer, not and __iomem one.

Signed-off-by: Christoph Hellwig

dma-mapping: remove a few unused exports

2019-01-04T08:03:17+00:00

Now that the slow path DMA API calls are implemented out of line a few
helpers only used by them don't need to be exported anymore.

Signed-off-by: Christoph Hellwig