linux-stable.git/kernel/auditfilter.c, branch v3.9.4

audit: Make testing for a valid loginuid explicit.

2013-05-19T18:38:47+00:00

commit 780a7654cee8d61819512385e778e4827db4bfbc upstream.

audit rule additions containing "-F auid!=4294967295" were failing
with EINVAL because of a regression caused by e1760bd.

Apparently some userland audit rule sets want to know if loginuid uid
has been set and are using a test for auid != 4294967295 to determine
that.

In practice that is a horrible way to ask if a value has been set,
because it relies on subtle implementation details and will break
every time the uid implementation in the kernel changes.

So add a clean way to test if the audit loginuid has been set, and
silently convert the old idiom to the cleaner and more comprehensible
new idiom.

RGB notes: In upstream, audit_rule_to_entry has been refactored out.
This is patch is already upstream in functionally the same form in
commit 780a7654cee8d61819512385e778e4827db4bfbc .  The decimal constant
was cast to unsigned to quiet GCC 4.6 32-bit architecture warnings.

Reported-By: Steve Grubb 
Signed-off-by: "Eric W. Biederman" 
Tested-by: Richard Guy Briggs 
Signed-off-by: Eric Paris 
Backported-by: Richard Guy Briggs 
Signed-off-by: Greg Kroah-Hartman

audit: fix auditfilter.c kernel-doc warnings

2013-01-10T22:35:23+00:00

Fix new kernel-doc warning in auditfilter.c:

  Warning(kernel/auditfilter.c:1157): Excess function parameter 'uid' description in 'audit_receive_filter'

Signed-off-by: Randy Dunlap 
Cc: Al Viro 
Cc: Eric Paris 
Cc: linux-audit@redhat.com (subscribers-only)
Signed-off-by: Linus Torvalds

audit: optimize audit_compare_dname_path

2012-10-12T04:32:02+00:00

In the cases where we already know the length of the parent, pass it as
a parm so we don't need to recompute it. In the cases where we don't
know the length, pass in AUDIT_NAME_FULL (-1) to indicate that it should
be determined.

Signed-off-by: Jeff Layton 
Signed-off-by: Al Viro

audit: make audit_compare_dname_path use parent_len helper

2012-10-12T04:32:02+00:00

Signed-off-by: Eric Paris 
Signed-off-by: Al Viro

audit: remove dirlen argument to audit_compare_dname_path

2012-10-12T04:32:01+00:00

All the callers set this to NULL now.

Signed-off-by: Jeff Layton 
Signed-off-by: Al Viro

audit: set the name_len in audit_inode for parent lookups

2012-10-12T04:32:01+00:00

Currently, this gets set mostly by happenstance when we call into
audit_inode_child. While that might be a little more efficient, it seems
wrong. If the syscall ends up failing before audit_inode_child ever gets
called, then you'll have an audit_names record that shows the full path
but has the parent inode info attached.

Fix this by passing in a parent flag when we call audit_inode that gets
set to the value of LOOKUP_PARENT. We can then fix up the pathname for
the audit entry correctly from the get-go.

While we're at it, clean up the no-op macro for audit_inode in the
!CONFIG_AUDITSYSCALL case.

Signed-off-by: Jeff Layton 
Signed-off-by: Al Viro

userns: Convert the audit loginuid to be a kuid

2012-09-18T01:08:54+00:00

Always store audit loginuids in type kuid_t.

Print loginuids by converting them into uids in the appropriate user
namespace, and then printing the resulting uid.

Modify audit_get_loginuid to return a kuid_t.

Modify audit_set_loginuid to take a kuid_t.

Modify /proc//loginuid on read to convert the loginuid into the
user namespace of the opener of the file.

Modify /proc//loginud on write to convert the loginuid
rom the user namespace of the opener of the file.

Cc: Al Viro 
Cc: Eric Paris 
Cc: Paul Moore  ?
Cc: David Miller 
Signed-off-by: Eric W. Biederman

audit: Add typespecific uid and gid comparators

2012-09-18T01:08:09+00:00

The audit filter code guarantees that uid are always compared with
uids and gids are always compared with gids, as the comparason
operations are type specific.  Take advantage of this proper to define
audit_uid_comparator and audit_gid_comparator which use the type safe
comparasons from uidgid.h.

Build on audit_uid_comparator and audit_gid_comparator and replace
audit_compare_id with audit_compare_uid and audit_compare_gid.  This
is one of those odd cases where being type safe and duplicating code
leads to simpler shorter and more concise code.

Don't allow bitmask operations in uid and gid comparisons in
audit_data_to_entry.  Bitmask operations are already denined in
audit_rule_to_entry.

Convert constants in audit_rule_to_entry and audit_data_to_entry into
kuids and kgids when appropriate.

Convert the uid and gid field in struct audit_names to be of type
kuid_t and kgid_t respectively, so that the new uid and gid comparators
can be applied in a type safe manner.

Cc: Al Viro 
Cc: Eric Paris 
Signed-off-by: "Eric W. Biederman"

audit: Remove the unused uid parameter from audit_receive_filter

2012-09-18T01:07:07+00:00

Cc: Al Viro 
Cc: Eric Paris 
Signed-off-by: "Eric W. Biederman"

audit: Use current instead of NETLINK_CREDS() in audit_filter

2012-09-18T01:03:31+00:00

Get caller process uid and gid and pid values from the current task
instead of the NETLINK_CB.  This is simpler than passing NETLINK_CREDS
from from audit_receive_msg to audit_filter_user_rules and avoid the
chance of being hit by the occassional bugs in netlink uid/gid
credential passing.  This is a safe changes because all netlink
requests are processed in the task of the sending process.

Cc: Al Viro 
Cc: Eric Paris 
Signed-off-by: "Eric W. Biederman"