linux-stable.git/include/linux/sunrpc/svc.h, branch linux-6.3.y

SUNRPC: Replace pool stats with per-CPU variables

2023-02-20T14:20:32+00:00

Eliminate the use of bus-locked operations in svc_xprt_enqueue(),
which is a hot path. Replace them with per-cpu variables to reduce
cross-CPU memory bus traffic.

Signed-off-by: Chuck Lever

SUNRPC: Use per-CPU counters to tally server RPC counts

2023-02-20T14:20:32+00:00

 - Improves counting accuracy
 - Reduces cross-CPU memory traffic

Signed-off-by: Chuck Lever

SUNRPC: Set rq_accept_statp inside ->accept methods

2023-02-20T14:20:31+00:00

To navigate around the space that svcauth_gss_accept() reserves
for the RPC payload body length and sequence number fields,
svcauth_gss_release() does a little dance with the reply's
accept_stat, moving the accept_stat value in the response buffer
down by two words.

Instead, let's have the ->accept() methods each set the proper
final location of the accept_stat to avoid having to move
things.

Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever

SUNRPC: Refactor RPC server dispatch method

2023-02-20T14:20:31+00:00

Currently, svcauth_gss_accept() pre-reserves response buffer space
for the RPC payload length and GSS sequence number before returning
to the dispatcher, which then adds the header's accept_stat field.

The problem is the accept_stat field is supposed to go before the
length and seq_num fields. So svcauth_gss_release() has to relocate
the accept_stat value (see svcauth_gss_prepare_to_wrap()).

To enable these fields to be added to the response buffer in the
correct (final) order, the pointer to the accept_stat has to be made
available to svcauth_gss_accept() so that it can set it before
reserving space for the length and seq_num fields.

As a first step, move the pointer to the location of the accept_stat
field into struct svc_rqst.

Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever

SUNRPC: Remove no-longer-used helper functions

2023-02-20T14:20:31+00:00

The svc_get/put helpers are no longer used.

Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever

SUNRPC: Convert unwrap data paths to use xdr_stream for replies

2023-02-20T14:20:28+00:00

We're now moving svcxdr_init_encode() to /before/ the flavor's
->accept method has set rq_auth_slack. Add a helper that can
set rq_auth_slack /after/ svcxdr_init_encode() has been called.

Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever

sunrpc: svc: Remove an unused static function svc_ungetu32()

2022-12-10T15:59:30+00:00

The svc_ungetu32 function is not used, you could remove it.

Signed-off-by: Li zeming 
Signed-off-by: Chuck Lever

SUNRPC: Remove unused svc_rqst::rq_lock field

2022-11-28T17:54:44+00:00

Clean up after commit 22700f3c6df5 ("SUNRPC: Improve ordering of
transport processing").

Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever

SUNRPC: Parametrize how much of argsize should be zeroed

2022-09-26T18:02:42+00:00

Currently, SUNRPC clears the whole of .pc_argsize before processing
each incoming RPC transaction. Add an extra parameter to struct
svc_procedure to enable upper layers to reduce the amount of each
operation's argument structure that is zeroed by SUNRPC.

The size of struct nfsd4_compoundargs, in particular, is a lot to
clear on each incoming RPC Call. A subsequent patch will cut this
down to something closer to what NFSv2 and NFSv3 uses.

This patch should cause no behavior changes.

Signed-off-by: Chuck Lever

SUNRPC: Fix svcxdr_init_encode's buflen calculation

2022-09-26T18:02:26+00:00

Commit 2825a7f90753 ("nfsd4: allow encoding across page boundaries")
added an explicit computation of the remaining length in the rq_res
XDR buffer.

The computation appears to suffer from an "off-by-one" bug. Because
buflen is too large by one page, XDR encoding can run off the end of
the send buffer by eventually trying to use the struct page address
in rq_page_end, which always contains NULL.

Fixes: bddfdbcddbe2 ("NFSD: Extract the svcxdr_init_encode() helper")
Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever