linux-stable.git/include/linux/mfd/cros_ec.h, branch v4.2.4

mfd: cros_ec: Support multiple EC in a system

2015-06-15T12:18:23+00:00

Chromebooks can have more than one Embedded Controller so the
cros_ec device id has to be incremented for each EC registered.

Add a new structure to represent multiple EC as different char
devices (e.g: /dev/cros_ec, /dev/cros_pd). It connects to
cros_ec_device and allows sysfs inferface for cros_pd.

Also reduce number of allocated objects, make chromeos sysfs
class object a static and add refcounting to prevent object
deletion while command is in progress.

Signed-off-by: Gwendal Grignou 
Reviewed-by: Dmitry Torokhov 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: add bus-specific proto v3 code

2015-06-15T12:18:22+00:00

Add proto v3 support to the SPI, I2C, and LPC.

Signed-off-by: Stephen Barber 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Reviewed-by: Gwendal Grignou 
Tested-by: Gwendal Grignou 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: add proto v3 skeleton

2015-06-15T12:18:21+00:00

Add support in cros_ec.c to handle EC host command protocol v3.
For v3+, probe for maximum shared protocol version and max
request, response, and passthrough sizes. For now, this will
always fall back to v2, since there is no bus-specific code
for handling proto v3 packets.

Signed-off-by: Stephen Barber 
Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Gwendal Grignou 
Tested-by: Gwendal Grignou 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: Use a zero-length array for command data

2015-06-15T12:18:19+00:00

Commit 1b84f2a4cd4a ("mfd: cros_ec: Use fixed size arrays to transfer
data with the EC") modified the struct cros_ec_command fields to not
use pointers for the input and output buffers and use fixed length
arrays instead.

This change was made because the cros_ec ioctl API uses that struct
cros_ec_command to allow user-space to send commands to the EC and
to get data from the EC. So using pointers made the API not 64-bit
safe. Unfortunately this approach was not flexible enough for all
the use-cases since there may be a need to send larger commands
on newer versions of the EC command protocol.

So to avoid to choose a constant length that it may be too big for
most commands and thus wasting memory and CPU cycles on copy from
and to user-space or having a size that is too small for some big
commands, use a zero-length array that is both 64-bit safe and
flexible. The same buffer is used for both output and input data
so the maximum of these values should be used to allocate it.

Suggested-by: Gwendal Grignou 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: Remove parent field

2015-06-15T12:18:17+00:00

Parent and device were pointing to the same device structure.

Parent is unused, removed.

Signed-off-by: Gwendal Grignou 
Tested-by: Stephen Barber 
Tested-by: Heiko Stuebner 
Tested-by: Gwendal Grignou 
Reviewed-by: Puthikorn Voravootivat 
Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Lee Jones

mfd: cros_ec: Add char dev and virtual dev pointers

2015-02-26T23:44:58+00:00

The ChromeOS Embedded Controller has to be accessed by applications.
A virtual character device is used as an interface with user-space.

Extend the struct cros_ec_device with the fields needed by the driver
of this virtual character device.

Signed-off-by: Javier Martinez Canillas 
Acked-by: Lee Jones 
Tested-by: Gwendal Grignou 
Reviewed-by: Gwendal Grignou 
Signed-off-by: Olof Johansson

mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-02-26T23:44:52+00:00

The struct cros_ec_command will be used as an ioctl() argument for the
API to control the ChromeOS EC from user-space. So the data structure
has to be 64-bit safe to make it compatible between 32 and 64 avoiding
the need for a compat ioctl interface. Since pointers are self-aligned
to different byte boundaries, use fixed size arrays instead of pointers
for transferring ingoing and outgoing data with the Embedded Controller.

Also, re-arrange struct members by decreasing alignment requirements to
reduce the needing padding size.

Signed-off-by: Javier Martinez Canillas 
Acked-by: Lee Jones 
Tested-by: Gwendal Grignou 
Reviewed-by: Gwendal Grignou 
Signed-off-by: Olof Johansson

mfd: cros_ec: stop calling ->cmd_xfer() directly

2014-10-06T20:29:07+00:00

Instead of having users of the ChromeOS EC call the interface-specific
cmd_xfer() callback directly, introduce a central cros_ec_cmd_xfer()
to use instead.  This will allow us to put all the locking and retry
logic in one place instead of duplicating it across the different
drivers.

Signed-off-by: Andrew Bresticker 
Reviewed-by: Simon Glass 
Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Doug Anderson 
Signed-off-by: Lee Jones

mfd: cros_ec: Move EC interrupt to cros_ec_keyb

2014-07-09T13:58:20+00:00

If we receive EC interrupts after the cros_ec driver has probed, but
before the cros_ec_keyb driver has probed, the cros_ec IRQ handler
will not run the cros_ec_keyb notifier and the EC will leave the IRQ
line asserted.  The cros_ec IRQ handler then returns IRQ_HANDLED and
the resulting flood of interrupts causes the machine to hang.

Since the EC interrupt is currently only used for the keyboard, move
the setup and handling of the EC interrupt to the cros_ec_keyb driver.

Signed-off-by: Andrew Bresticker 
Signed-off-by: Doug Anderson 
Acked-by: Dmitry Torokhov 
Signed-off-by: Lee Jones

mfd: cros_ec: ec_dev->cmd_xfer() returns number of bytes received from EC

2014-07-09T13:58:20+00:00

When communicating with the EC, the cmd_xfer() function should return the
number of bytes it received from the EC, or negative on error.

Signed-off-by: Bill Richardson 
Signed-off-by: Doug Anderson 
Reviewed-by: Simon Glass 
Acked-by: Wolfram Sang 
Signed-off-by: Lee Jones