linux-stable.git/include/linux/lockd/lockd.h, branch linux-2.6.17.y

LOCKD: nlmsvc_traverse_blocks return is unused

2006-03-21T04:24:13+00:00

Note that we never return non-zero.

Signed-off-by: J. Bruce Fields 
Signed-off-by: Trond Myklebust

lockd: Add helper for *_RES callbacks

2006-03-20T18:44:45+00:00

Signed-off-by: Trond Myklebust

NLM: Add nlmclnt_release_call

2006-03-20T18:44:45+00:00

Add a helper function to simplify the freeing of NLM client requests.

Signed-off-by: Trond Myklebust

NLM: Simplify client locks

2006-03-20T18:44:44+00:00

Signed-off-by: Trond Myklebust

lockd: stop abusing file_lock_list

2006-03-20T18:44:40+00:00

Currently lockd directly access the file_lock_list from fs/locks.c.
It does so to mark locks granted or reclaimable.  This is very
suboptimal, because a) lockd needs to poke into locks.c internals, and
b) it needs to iterate over all locks in the system for marking locks
granted or reclaimable.

This patch adds lists for granted and reclaimable locks to the nlm_host
structure instead, and adds locks to those.

nlmclnt_lock:
	now adds the lock to h_granted instead of setting the
	NFS_LCK_GRANTED, still O(1)

nlmclnt_mark_reclaim:
	goes away completely, replaced by a list_splice_init.
	Complexity reduced from O(locks in the system) to O(1)

reclaimer:
	iterates over h_reclaim now, complexity reduced from
	O(locks in the system) to O(locks per nlm_host)

Signed-off-by: Christoph Hellwig 
Signed-off-by: Trond Myklebust

lockd: Clean up of the server-side GRANTED code

2006-03-20T18:44:39+00:00

Signed-off-by: Trond Myklebust

lockd: Add refcounting to struct nlm_block

2006-03-20T18:44:39+00:00

Otherwise, the block may disappear from underneath us when in
nlmsvc_retry_blocked.

Signed-off-by: Trond Myklebust

[PATCH] NLM: Fix the NLM_GRANTED callback checks

2006-02-15T00:09:34+00:00

If 2 threads attached to the same process are blocking on different locks on
different files (maybe even on different servers) but have the same lock
arguments (i.e.  same offset+length - actually quite common, since most
processes try to lock the entire file) then the first GRANTED call that wakes
one up will also wake the other.

Currently when the NLM_GRANTED callback comes in, lockd walks the list of
blocked locks in search of a match to the lock that the NLM server has
granted.  Although it checks the lock pid, start and end, it fails to check
the filehandle and the server address.

By checking the filehandle and server IP address, we ensure that this only
happens if the locks truly are referencing the same file.

Signed-off-by: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

NLM: Ensure that nlmclnt_cancel_callback() doesn't loop forever

2006-02-01T17:52:23+00:00

 If the server returns NLM_LCK_DENIED_NOLOCKS, we currently retry the
 entire NLM_CANCEL request. This may end up looping forever unless the
 server changes its mind (why would it do that, though?).

 Ensure that we limit the number of retries (to 3).

 See bug# 5957 in bugzilla.kernel.org.

 Signed-off-by: Trond Myklebust

NLM: Fix arguments to NLM_CANCEL call

2006-02-01T17:52:23+00:00

 The OpenGroup docs state that the arguments "block", "exclusive" and
 "alock" must exactly match the arguments for the lock call that we are
 trying to cancel.
 Currently, "block" is always set to false, which is wrong.

 See bug# 5956 on bugzilla.kernel.org.

 Signed-off-by: Trond Myklebust