linux-stable.git/include/linux/libata.h, branch v5.17.7

ata: libata-core: Introduce ATA_HORKAGE_NO_LOG_DIR horkage

2022-02-04T07:44:23+00:00

06f6c4c6c3e8 ("ata: libata: add missing ata_identify_page_supported() calls")
introduced additional calls to ata_identify_page_supported(), thus also
adding indirectly accesses to the device log directory log page through
ata_log_supported(). Reading this log page causes SATADOM-ML 3ME devices
to lock up.

Introduce the horkage flag ATA_HORKAGE_NO_LOG_DIR to prevent accesses to
the log directory in ata_log_supported() and add a blacklist entry
with this flag for "SATADOM-ML 3ME" devices.

Fixes: 636f6e2af4fb ("libata: add horkage for missing Identify Device log")
Cc: stable@vger.kernel.org # v5.10+
Signed-off-by: Anton Lundin 
Signed-off-by: Damien Le Moal

ata: libata: Rename link flag ATA_LFLAG_NO_DB_DELAY

2022-01-14T06:17:17+00:00

Rename the link flag ATA_LFLAG_NO_DB_DELAY to
ATA_LFLAG_NO_DEBOUNCE_DELAY. The new name is longer, but clearer.

Signed-off-by: Paul Menzel 
Signed-off-by: Damien Le Moal

ata: fix read_id() ata port operation interface

2022-01-14T06:17:16+00:00

Drivers that need to tweak a device IDENTIFY data implement the
read_id() port operation. The IDENTIFY data buffer is passed as an
argument to the read_id() operation for drivers to use. However, when
this operation is called, the IDENTIFY data is not yet converted to CPU
endian and contains le16 words.

Change the interface of the read_id operation to pass a __le16 * pointer
to the IDENTIFY data buffer to clarify the buffer endianness. Fix the
pata_netcell, pata_it821x, ahci_xgene, ahci_ceva and ahci_brcm drivers
implementation of this operation and modify the code to corretly deal
with identify data words manipulation to avoid sparse warnings such as:

drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &=
drivers/ata/ahci_xgene.c:262:33:    left side has type unsigned short
drivers/ata/ahci_xgene.c:262:33:    right side has type restricted __le16

Signed-off-by: Damien Le Moal 
Reviewed-by: Hannes Reinecke

ata: sata_fsl: fix scsi host initialization

2022-01-14T06:17:16+00:00

When compiling with W=1, the sata_fsl driver compilation throws the
warning:

drivers/ata/sata_fsl.c:1385:22: error: initialized field overwritten
[-Werror=override-init]
 1385 |         .can_queue = SATA_FSL_QUEUE_DEPTH,

This is due to the driver scsi host template initialization overwriting
the can_queue field that is already set using the ATA_NCQ_SHT()
initializer macro, resulting in the same field being initialized twice
in the host template declaration.

To remove this warning, introduce the ATA_SUBBASE_SHT_QD() and
ATA_NCQ_SHT_QD() initialization macros to allow specifying a queue depth
different from the default ATA_DEF_QUEUE using an additional argument to
the macro.

Signed-off-by: Damien Le Moal 
Reviewed-by: Hannes Reinecke

ata: libata: remove debug compilation switches

2022-01-05T10:33:02+00:00

Unused now, so remove and drop any references to them.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: remove 'new' ata message handling

2022-01-05T10:33:02+00:00

Remove the remaining bits for the 'new' ata message handling.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_drv()

2022-01-05T10:33:02+00:00

Callers are already protected by ata_dev_print_info(), so no need
to have an additional configuration parameter here.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_info()

2022-01-05T10:33:02+00:00

Convert the sole caller to ata_dev_dbg() and remove the definition.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_probe()

2022-01-05T10:33:02+00:00

All callsites have been converted to dynamic debugging.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_warn()

2022-01-05T10:33:02+00:00

The WARN level was always enabled, so drop ata_msg_warn().

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal