linux-stable.git/include/linux/libata.h, branch v3.2.56

libata: disable LPM for some WD SATA-I devices

2014-04-01T23:58:43+00:00

commit ecd75ad514d73efc1bbcc5f10a13566c3ace5f53 upstream.

For some reason, some early WD drives spin up and down drives
erratically when the link is put into slumber mode which can reduce
the life expectancy of the device significantly.  Unfortunately, we
don't have full list of devices and given the nature of the issue it'd
be better to err on the side of false positives than the other way
around.  Let's disable LPM on all WD devices which match one of the
known problematic model prefixes and are SATA-I.

As horkage list doesn't support matching SATA capabilities, this is
implemented as two horkages - WD_BROKEN_LPM and NOLPM.  The former is
set for the known prefixes and sets the latter if the matched device
is SATA-I.

Note that this isn't optimal as this disables all LPM operations and
partial link power state reportedly works fine on these; however, the
way LPM is implemented in libata makes it difficult to precisely map
libata LPM setting to specific link power state.  Well, these devices
are already fairly outdated.  Let's just disable whole LPM for now.

Signed-off-by: Tejun Heo 
Reported-and-tested-by: Nikos Barkas 
Reported-and-tested-by: Ioannis Barkas 
References: https://bugzilla.kernel.org/show_bug.cgi?id=57211
[bwh: Backported to 3.2:
 - Adjust context
 - Use literal 76 instead of ATA_ID_SATA_CAPABILITY]
Signed-off-by: Ben Hutchings

libata: Set max sector to 65535 for Slimtype DVD A DS8A8SH drive

2013-04-25T19:25:32+00:00

commit a32450e127fc6e5ca6d958ceb3cfea4d30a00846 upstream.

The Slimtype DVD A  DS8A8SH drive locks up when max sector is smaller than
65535, and the blow backtrace is observed on locking up:

INFO: task flush-8:32:1130 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
flush-8:32      D ffffffff8180cf60     0  1130      2 0x00000000
 ffff880273aef618 0000000000000046 0000000000000005 ffff880273aee000
 ffff880273aee000 ffff880273aeffd8 ffff880273aee010 ffff880273aee000
 ffff880273aeffd8 ffff880273aee000 ffff88026e842ea0 ffff880274a10000
Call Trace:
 [] schedule+0x5d/0x70
 [] io_schedule+0x8c/0xd0
 [] get_request+0x731/0x7d0
 [] ? cfq_allow_merge+0x50/0x90
 [] ? wake_up_bit+0x40/0x40
 [] ? bio_attempt_back_merge+0x33/0x110
 [] blk_queue_bio+0x23a/0x3f0
 [] generic_make_request+0xc6/0x120
 [] submit_bio+0x138/0x160
 [] ? bio_alloc_bioset+0x96/0x120
 [] submit_bh+0x1f1/0x220
 [] __block_write_full_page+0x228/0x340
 [] ? attach_nobh_buffers+0xc0/0xc0
 [] ? I_BDEV+0x10/0x10
 [] ? I_BDEV+0x10/0x10
 [] block_write_full_page_endio+0xe6/0x100
 [] block_write_full_page+0x15/0x20
 [] blkdev_writepage+0x18/0x20
 [] __writepage+0x17/0x40
 [] write_cache_pages+0x34a/0x4a0
 [] ? set_page_dirty+0x70/0x70
 [] generic_writepages+0x51/0x80
 [] do_writepages+0x20/0x50
 [] __writeback_single_inode+0xa6/0x2b0
 [] writeback_sb_inodes+0x311/0x4d0
 [] __writeback_inodes_wb+0x86/0xd0
 [] wb_writeback+0x1a3/0x330
 [] ? _raw_spin_lock_irqsave+0x3f/0x50
 [] ? get_nr_inodes+0x52/0x70
 [] wb_do_writeback+0x1dc/0x260
 [] ? schedule_timeout+0x204/0x240
 [] bdi_writeback_thread+0x102/0x2b0
 [] ? wb_do_writeback+0x260/0x260
 [] kthread+0xc0/0xd0
 [] ? kthread_worker_fn+0x1b0/0x1b0
 [] ret_from_fork+0x7c/0xb0
 [] ? kthread_worker_fn+0x1b0/0x1b0

 The above trace was triggered by
   "dd if=/dev/zero of=/dev/sr0 bs=2048 count=32768"

 It was previously working by accident, since another bug introduced
 by 4dce8ba94c7 (libata: Use 'bool' return value for ata_id_XXX) caused
 all drives to use maxsect=65535.

Signed-off-by: Shan Hai 
Signed-off-by: Jeff Garzik 
Signed-off-by: Ben Hutchings

treewide: use printf not attribute__((format(printf,...)))

2011-11-01T00:30:54+00:00

Standardize the style for compiler based printf format verification.
Standardized the location of __printf too.

Done via script and a little typing.

$ grep -rPl --include=*.[ch] -w "__attribute__" * | \
  grep -vP "^(tools|scripts|include/linux/compiler-gcc.h)" | \
  xargs perl -n -i -e 'local $/; while (<>) { s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.+)\s*,\s*(.+)\s*\)\s*\)\s*\)/__printf($1, $2)/g ; print; }'

[akpm@linux-foundation.org: revert arch bits]
Signed-off-by: Joe Perches 
Cc: "Kirill A. Shutemov" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[SCSI] libsas,libata: fix ->change_queue_{depth|type} for sata devices

2011-10-02T17:30:30+00:00

Pass queue_depth change requests to libata, and prevent queue_type
changes for ATA devices.

Otherwise:
1/ we do not honor the libata specific restrictions on the queue depth
2/ libsas drivers that do not set sdev->tagged_supported are unable to
   change the queue_depth of ata devices via sysfs

Signed-off-by: Dan Williams 
Acked-by: Jeff Garzik 
Signed-off-by: James Bottomley

ata: Add and use ata_print_version_once

2011-07-23T21:57:36+00:00

Use a single mechanism to show driver version.
Reduces text a tiny bit too.

Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.

$ size drivers/ata/built-in.*
   text	   data	    bss	    dec	    hex	filename
 544969	  73893	 116584	 735446	  b38d6	drivers/ata/built-in.allyesconfig.ata.o
 543870	  73893	 116592	 734355	  b34ad	drivers/ata/built-in.allyesconfig.print_once.o
 141328	  14689	   4220	 160237	  271ed	drivers/ata/built-in.defconfig.ata.o
 141212	  14689	   4220	 160121	  27179	drivers/ata/built-in.defconfig.print_once.o

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Garzik

ata: Convert ata__printk(KERN_ to ata__

2011-07-23T21:57:36+00:00

Saves text by removing nearly duplicated text format strings by
creating ata__printk functions and printf extension %pV.

ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)

Format string duplication comes from:

 #define ata_link_printk(link, lv, fmt, args...) do { \
       if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link)    \
               printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id,   \
                      (link)->pmp , ##args); \
       else \
               printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
       } while(0)

Coalesce long formats.

$ size drivers/ata/built-in.*
   text	   data	    bss	    dec	    hex	filename
 544969	  73893	 116584	 735446	  b38d6	drivers/ata/built-in.allyesconfig.ata.o
 558429	  73893	 117864	 750186	  b726a	drivers/ata/built-in.allyesconfig.dev_level.o
 141328	  14689	   4220	 160237	  271ed	drivers/ata/built-in.defconfig.ata.o
 149567	  14689	   4220	 168476	  2921c	drivers/ata/built-in.defconfig.dev_level.o

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Garzik

libata: Power off empty ports

2011-05-20T00:50:53+00:00

Give users the option of completely powering off unoccupied
SATA ports using the existing min_power link_power_management_policy
option.  When the use selects this option on an empty port, we
will power the port off by setting DET to off.  For occupied ports,
behavior is unchanged.

Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Jeff Garzik

libata: Implement ATA_FLAG_NO_DIPM and apply it to mcp65

2011-04-24T15:32:16+00:00

NVIDIA mcp65 familiy of controllers cause command timeouts when DIPM
is used.  Implement ATA_FLAG_NO_DIPM and apply it.

This problem was reported by Stefan Bader in the following thread.

 http://thread.gmane.org/gmane.linux.ide/48841

stable: applicable to 2.6.37 and 38.

Signed-off-by: Tejun Heo 
Reported-by: Stefan Bader 
Cc: stable@kernel.org
Signed-off-by: Jeff Garzik

libata: Kill unused ATA_DFLAG_{H|D}IPM flags

2011-04-24T15:32:03+00:00

ATA_DFLAG_{H|D}IPM flags are no longer used.  Kill them.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi