linux-stable.git/include/linux/igmp.h, branch linux-2.6.19.y

[IGMP]: Fix IGMPV3_EXP() normalization bit shift value.

2006-11-22T00:16:33+00:00

The IGMPV3_EXP() macro doesn't correctly shift the normalization bit, so
time-out values are longer than they should be.

Thanks to Dirk Ooms for finding the problem in IGMPv3 - MLDv2 had a
similar problem that was already fixed a year ago. :-(

Signed-off-by: David L Stevens 
Signed-off-by: David S. Miller

[IPV4]: trivial igmp annotations

2006-09-29T01:02:02+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[IPV4]: ip_mc_sf_allow() annotated

2006-09-29T01:02:01+00:00

ip_mc_sf_allow() expects addresses to be passed net-endian.

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[IPV4]: struct ip_sf_list and struct ip_sf_socklist annotated

2006-09-29T01:02:00+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[IPV4]: IGMP on-the-wire data is net-endian

2006-09-29T01:01:59+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[IPV4]: ip_mc_{inc,dec}_group() annotations

2006-09-29T01:01:58+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[IPV4]: ip_check_mc() annotations

2006-09-29T00:54:10+00:00

annotated arguments

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[IPV4] igmp: Fixup struct ip_mc_list::multiaddr type

2006-06-18T04:29:37+00:00

All users except two expect 32-bit big-endian value. One is of

	->multiaddr = ->multiaddr

variety. And last one is "%08lX".

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

[NET]: Fix sparse warnings

2005-08-29T23:01:32+00:00

Of this type, mostly:

CHECK   net/ipv6/netfilter.c
net/ipv6/netfilter.c:96:12: warning: symbol 'ipv6_netfilter_init' was not declared. Should it be static?
net/ipv6/netfilter.c:101:6: warning: symbol 'ipv6_netfilter_fini' was not declared. Should it be static?

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[IPV4]: multicast API "join" issues

2005-07-09T00:38:07+00:00

        This patch corrects a few problems with the IP_ADD_MEMBERSHIP
socket option:

1) The existing code makes an attempt at reference counting joins when
   using the ip_mreqn/imr_ifindex interface. Joining the same group
   on the same socket is an error, whatever the API. This leads to
   unexpected results when mixing ip_mreqn by index with ip_mreqn by
   address, ip_mreq, or other API's. For example, ip_mreq followed by
   ip_mreqn of the same group will "work" while the same two reversed
   will not.
           Fixed to always return EADDRINUSE on a duplicate join and
   removed the (now unused) reference count in ip_mc_socklist.

2) The group-search list in ip_mc_join_group() is comparing a full 
   ip_mreqn structure and all of it must match for it to find the
   group. This doesn't correctly match a group that was joined with
   ip_mreq or ip_mreqn with an address (with or without an index). It
   also doesn't match groups that are joined by different addresses on
   the same interface. All of these are the same multicast group,
   which is identified by group address and interface index.
           Fixed the check to correctly match groups so we don't get
   duplicate group entries on the ip_mc_socklist.

3) The old code allocates a multicast address before searching for
   duplicates requiring it to free in various error cases. This
   patch moves the allocate until after the search and
   igmp_max_memberships check, so never a need to allocate, then free
   an entry.

Signed-off-by: David L Stevens 
Signed-off-by: David S. Miller