linux-stable.git/include/linux/hid.h, branch v4.9.243

HID: core: Sanitize event code and type when mapping input

2020-09-12T09:47:31+00:00

commit 35556bed836f8dc07ac55f69c8d17dce3e7f0e25 upstream.

When calling into hid_map_usage(), the passed event code is
blindly stored as is, even if it doesn't fit in the associated bitmap.

This event code can come from a variety of sources, including devices
masquerading as input devices, only a bit more "programmable".

Instead of taking the event code at face value, check that it actually
fits the corresponding bitmap, and if it doesn't:
- spit out a warning so that we know which device is acting up
- NULLify the bitmap pointer so that we catch unexpected uses

Code paths that can make use of untrusted inputs can now check
that the mapping was indeed correct and bail out if not.

Cc: stable@vger.kernel.org
Signed-off-by: Marc Zyngier 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Greg Kroah-Hartman

HID: core: increase HID report buffer size to 8KiB

2020-03-11T06:53:06+00:00

commit 84a4062632462c4320704fcdf8e99e89e94c0aba upstream.

We have a HID touch device that reports its opens and shorts test
results in HID buffers of size 8184 bytes. The maximum size of the HID
buffer is currently set to 4096 bytes, causing probe of this device to
fail. With this patch we increase the maximum size of the HID buffer to
8192 bytes, making device probe and acquisition of said buffers succeed.

Signed-off-by: Johan Korsnes 
Cc: Alan Stern 
Cc: Armando Visconti 
Cc: Jiri Kosina 
Signed-off-by: Jiri Kosina 
Signed-off-by: Greg Kroah-Hartman

HID: core: move Usage Page concatenation to Main item

2019-05-31T13:48:29+00:00

[ Upstream commit 58e75155009cc800005629955d3482f36a1e0eec ]

As seen on some USB wireless keyboards manufactured by Primax, the HID
parser was using some assumptions that are not always true. In this case
it's s the fact that, inside the scope of a main item, an Usage Page
will always precede an Usage.

The spec is not pretty clear as 6.2.2.7 states "Any usage that follows
is interpreted as a Usage ID and concatenated with the Usage Page".
While 6.2.2.8 states "When the parser encounters a main item it
concatenates the last declared Usage Page with a Usage to form a
complete usage value." Being somewhat contradictory it was decided to
match Window's implementation, which follows 6.2.2.8.

In summary, the patch moves the Usage Page concatenation from the local
item parsing function to the main item parsing function.

Signed-off-by: Nicolas Saenz Julienne 
Reviewed-by: Terry Junge 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Sasha Levin

HID: core: Fix size as type u32

2018-04-24T07:34:12+00:00

commit 6de0b13cc0b4ba10e98a9263d7a83b940720b77a upstream.

When size is negative, calling memset will make segment fault.
Declare the size as type u32 to keep memset safe.

size in struct hid_report is unsigned, fix return type of
hid_report_len to u32.

Cc: stable@vger.kernel.org
Signed-off-by: Aaron Ma 
Signed-off-by: Jiri Kosina 
Signed-off-by: Greg Kroah-Hartman

HID: add missing \n to end of dev_warn messages

2016-09-29T08:40:13+00:00

Trival fix, dev_warn messages are missing a \n, so add it.

Signed-off-by: Colin Ian King 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: add a new helper to_hid_driver()

2015-12-28T12:41:50+00:00

Add a new helper to_hid_driver() and use it in hid-core.c.

Signed-off-by: Geliang Tang 
Signed-off-by: Jiri Kosina

HID: move to_hid_device() to hid.h

2015-12-28T12:41:11+00:00

to_hid_device() macro is defined in both hid-lg4ff.c and
hid-logitech-hidpp.c. So I move it to include/linux/hid.h.

Signed-off-by: Geliang Tang 
Signed-off-by: Jiri Kosina

HID: Add vendor specific usage pages for Logitech G920

2015-11-20T09:30:00+00:00

The Logitech G920 uses a couple of vendor specific usage pages,
which results in incorrect number of axis/buttons being detected.

This patch adds these pages to the 'ignore' list.

Reported-by: Elias Vanderstuyft 
Signed-off-by: Simon Wood 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: hid-input: allow input_configured callback return errors

2015-11-05T17:51:50+00:00

When configuring input device via input_configured callback we may
encounter errors (for example input_mt_init_slots() may fail). Instead
of continuing with half-initialized input device let's allow driver
indicate failures.

Signed-off-by: Jaikumar Ganesh 
Signed-off-by: Arve Hjønnevåg 
Reviewed-by: Benjamin Tissoires 
Reviewed-by: David Herrmann 
Acked-by: Nikolai Kondrashov 
Acked-by: Andrew Duggan 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Jiri Kosina

HID: Export hid_field_extract()

2015-06-01T12:33:35+00:00

Rename the function extract() to hid_field_extract(), make it external linkage
to allow the use from other modules.

Suggested-by: Jiri Kosina 
Signed-off-by: Goffredo Baroncelli 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina