linux-stable.git/include/linux/firmware/cirrus, branch linux-6.10.y

ALSA: cirrus: Tidy up of firmware control read/write

2024-04-03T19:45:32+00:00

Merge series from Richard Fitzgerald :

This set of patches factors out some repeated code to clean up
firmware control read/write functions, and removes some redundant
control notification code.

base-commit: f193957b0fbbba397c8bddedf158b3bf7e4850fc

firmware: cs_dsp: Add locked wrappers for coeff read and write

2024-04-03T15:10:27+00:00

It is a common pattern for functions to take and release the DSP
pwr_lock over the cs_dsp calls to read and write firmware controls.
Add wrapper functions to do this sequence so that the calling code can
be simplified to a single function call..

Signed-off-by: Simon Trimmer 
Signed-off-by: Richard Fitzgerald 
Reviewed-by: Takashi Iwai 
Link: https://msgid.link/r/20240325113127.112783-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cirrus: cs_dsp: Remove non-existent member from kerneldoc

2024-03-07T13:03:55+00:00

The kerneldoc for struct cs_dsp refers to a fw_file_name member but
there's no such member.

Signed-off-by: Richard Fitzgerald 
Link: https://msgid.link/r/20240307105516.40250-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Introduce no_core_startstop for self-booting DSPs

2023-03-21T12:13:17+00:00

There are devices containing Halo Core DSPs that self-boot, cs_dsp is
used to manage the running firmware but the host does not have direct
control over starting and stopping the DSP and so cs_dsp should consider
the DSP to be always running.

Signed-off-by: Simon Trimmer 
Signed-off-by: Richard Fitzgerald 
Link: https://lore.kernel.org/r/20230320112245.115720-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Add memory chunk helpers

2022-07-22T12:40:00+00:00

Add helpers that can be layered on top of a buffer read from or to be
written to the DSP to faciliate accessing datastructures within the DSP
memory. These functions handle adding the padding bytes for the DSP,
converting to big endian, and packing arbitrary length data.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20220722094851.92521-2-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Add pre_stop callback

2022-07-22T12:39:59+00:00

The code already has a post_stop callback, add a matching pre_stop
callback to the client_ops that is called before execution is stopped.
This callback provides a convenient place for the client code to
communicate with the DSP before it is stopped.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20220722094851.92521-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cirrus: cs_dsp: Avoid padding bytes in cs_dsp_coeff_ctl

2022-04-25T12:59:02+00:00

Change the order of members in struct cs_dsp_coeff_ctl to avoid
the compiler having to insert alignment padding bytes. On a x86_64
build this saves 16 bytes per control.

- Pointers are collected to the top of the struct (with the exception of
  priv, as noted below), so that they are inherently aligned.
- The set and enable bitflags are placed together so they can be merged.
- priv is placed at the end of the struct - it is for use by the
  client so it is helpful to make it stand out, and since the compiler
  will always pad the struct size to an alignment multiple putting a
  pointer last won't introduce any more padding.
- struct cs_dsp_alg_region is placed at the end, right before priv, for
  the same reasoning as priv.

Signed-off-by: Richard Fitzgerald 
Reviewed-by: Charles Keepax 
Link: https://lore.kernel.org/r/20220425095159.3044527-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Allow creation of event controls

2021-11-17T22:16:28+00:00

Some firmwares contain controls intended to convey firmware state back
to the host. Whilst more infrastructure will probably be needed for
these in time, as a first step allow creation of the controls, so said
firmwares arn't completely rejected.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-10-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Add offset to cs_dsp read/write

2021-11-17T22:16:27+00:00

Provide a mechanism to access only part of a control through the cs_dsp
interface.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-9-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Clarify some kernel doc comments

2021-11-17T22:16:26+00:00

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-8-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown