linux-stable.git/include/linux/dpll.h, branch v6.8.4

dpll: move all dpll<>netdev helpers to dpll code

2024-03-06T02:36:42+00:00

Older versions of GCC really want to know the full definition
of the type involved in rcu_assign_pointer().

struct dpll_pin is defined in a local header, net/core can't
reach it. Move all the netdev <> dpll code into dpll, where
the type is known. Otherwise we'd need multiple function calls
to jump between the compilation units.

This is the same problem the commit under fixes was trying to address,
but with rcu_assign_pointer() not rcu_dereference().

Some of the exports are not needed, networking core can't
be a module, we only need exports for the helpers used by
drivers.

Reported-by: Geert Uytterhoeven 
Link: https://lore.kernel.org/all/35a869c8-52e8-177-1d4d-e57578b99b6@linux-m68k.org/
Fixes: 640f41ed33b5 ("dpll: fix build failure due to rcu_dereference_check() on unknown type")
Reviewed-by: Jiri Pirko 
Reviewed-by: Eric Dumazet 
Link: https://lore.kernel.org/r/20240305013532.694866-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski

dpll: fix build failure due to rcu_dereference_check() on unknown type

2024-02-29T20:18:37+00:00

Tasmiya reports that their compiler complains that we deref
a pointer to unknown type with rcu_dereference_rtnl():

include/linux/rcupdate.h:439:9: error: dereferencing pointer to incomplete type ‘struct dpll_pin’

Unclear what compiler it is, at the moment, and we can't report
but since DPLL can't be a module - move the code from the header
into the source file.

Fixes: 0d60d8df6f49 ("dpll: rely on rcu for netdev_dpll_pin()")
Reported-by: Tasmiya Nalatwad 
Link: https://lore.kernel.org/all/3fcf3a2c-1c1b-42c1-bacb-78fdcd700389@linux.vnet.ibm.com/
Signed-off-by: Eric Dumazet 
Link: https://lore.kernel.org/r/20240229190515.2740221-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski

dpll: rely on rcu for netdev_dpll_pin()

2024-02-27T02:39:34+00:00

This fixes a possible UAF in if_nlmsg_size(),
which can run without RTNL.

Add rcu protection to "struct dpll_pin"

Move netdev_dpll_pin() from netdevice.h to dpll.h to
decrease name pollution.

Note: This looks possible to no longer acquire RTNL in
netdev_dpll_pin_assign() later in net-next.

v2: do not force rcu_read_lock() in rtnl_dpll_pin_size() (Jiri Pirko)

Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice")
Signed-off-by: Eric Dumazet 
Cc: Arkadiusz Kubalewski 
Cc: Vadim Fedorenko 
Reviewed-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20240223123208.3543319-1-edumazet@google.com
Signed-off-by: Jakub Kicinski

dpll: expose fractional frequency offset value to user

2024-01-05T15:58:19+00:00

Add a new netlink attribute to expose fractional frequency offset value
for a pin. Add an op to get the value from the driver.

Signed-off-by: Jiri Pirko 
Acked-by: Vadim Fedorenko 
Acked-by: Arkadiusz Kubalewski 
Link: https://lore.kernel.org/r/20240103132838.1501801-2-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

dpll: remove leftover mode_supported() op and use mode_get() instead

2023-12-13T10:31:19+00:00

Mode supported is currently reported to the user exactly the same, as
the current mode. That's because mode changing is not implemented.
Remove the leftover mode_supported() op and use mode_get() to fill up
the supported mode exposed to user.

One, if even, mode changing is going to be introduced, this could be
very easily taken back. In the meantime, prevent drivers form
implementing this in wrong way (as for example recent netdevsim
implementation attempt intended to do).

Signed-off-by: Jiri Pirko 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-15T15:08:24+00:00

Add callback ops for pin-dpll phase measurement.
Add callback for pin signal phase adjustment.
Add min and max phase adjustment values to pin proprties.
Invoke callbacks in dpll_netlink.c when filling the pin details to
provide user with phase related attribute values.

Signed-off-by: Arkadiusz Kubalewski 
Signed-off-by: David S. Miller

netdev: expose DPLL pin handle for netdevice

2023-09-17T10:50:20+00:00

In case netdevice represents a SyncE port, the user needs to understand
the connection between netdevice and associated DPLL pin. There might me
multiple netdevices pointing to the same pin, in case of VF/SF
implementation.

Add a IFLA Netlink attribute to nest the DPLL pin handle, similar to
how it is implemented for devlink port. Add a struct dpll_pin pointer
to netdev and protect access to it by RTNL. Expose netdev_dpll_pin_set()
and netdev_dpll_pin_clear() helpers to the drivers so they can set/clear
the DPLL pin relationship to netdev.

Note that during the lifetime of struct dpll_pin the pin handle does not
change. Therefore it is save to access it lockless. It is drivers
responsibility to call netdev_dpll_pin_clear() before dpll_pin_put().

Signed-off-by: Jiri Pirko 
Signed-off-by: Arkadiusz Kubalewski 
Signed-off-by: Vadim Fedorenko 
Signed-off-by: David S. Miller

dpll: netlink: Add DPLL framework base functions

2023-09-17T10:50:20+00:00

DPLL framework is used to represent and configure DPLL devices
in systems. Each device that has DPLL and can configure inputs
and outputs can use this framework.

Implement dpll netlink framework functions for enablement of dpll
subsystem netlink family.

Co-developed-by: Milena Olech 
Signed-off-by: Milena Olech 
Co-developed-by: Michal Michalik 
Signed-off-by: Michal Michalik 
Signed-off-by: Vadim Fedorenko 
Co-developed-by: Arkadiusz Kubalewski 
Signed-off-by: Arkadiusz Kubalewski 
Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

dpll: core: Add DPLL framework base functions

2023-09-17T10:50:20+00:00

DPLL framework is used to represent and configure DPLL devices
in systems. Each device that has DPLL and can configure inputs
and outputs can use this framework.

Implement core framework functions for further interactions
with device drivers implementing dpll subsystem, as well as for
interactions of DPLL netlink framework part with the subsystem
itself.

Co-developed-by: Milena Olech 
Signed-off-by: Milena Olech 
Co-developed-by: Michal Michalik 
Signed-off-by: Michal Michalik 
Signed-off-by: Vadim Fedorenko 
Co-developed-by: Arkadiusz Kubalewski 
Signed-off-by: Arkadiusz Kubalewski 
Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller