linux-stable.git/include/drm/ttm, branch linux-6.10.y

drm/ttm: warn when resv objs are mixed in a bulk_move

2024-03-20T10:18:10+00:00

The BOs in a bulk move must share all the same reservation object
to make sure that we lock the whole bulk during eviction.

Actually document and enforce that with a warning.

Signed-off-by: Christian König 
Reviewed-by: Thomas Hellström 
Link: https://patchwork.freedesktop.org/patch/msgid/20240312105555.3065-1-christian.koenig@amd.com

drm/ttm: make ttm_pool.h self-contained

2024-03-11T09:47:06+00:00

struct seq_file needs a forward declaration in some configs. Sort the
forward declarations while at it.

Cc: Christian Koenig 
Cc: Huang Rui 
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202403072259.EEC2Vf1X-lkp@intel.com/
Reviewed-by: Christian König 
Reviewed-by: Alex Deucher 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/b92373759bba305ddf8d24fdca345f195400e206.1709898638.git.jani.nikula@intel.com

drm/ttm: fix ttm_kmap_iter.h kernel-doc warnings

2024-03-11T09:47:06+00:00

There's no proper way to document function pointer members, but at least
silence the warnings.

Cc: Christian Koenig 
Cc: Huang Rui 
Acked-by: Thomas Zimmermann 
Reviewed-by: Christian König 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/e80e74ac4b6c5f1df3bc2dd98651ba289aae8e83.1709898638.git.jani.nikula@intel.com

drm/ttm: fix ttm_execbuf_util.h kernel-doc warnings

2024-03-11T09:47:06+00:00

Fix some formatting errors and excess documentation.

Cc: Christian Koenig 
Cc: Huang Rui 
Acked-by: Thomas Zimmermann 
Reviewed-by: Christian König 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/b0f6d243c4e5eb1564ef2f4bb5bb834ee2c0305b.1709898638.git.jani.nikula@intel.com

drm/ttm: make ttm_caching.h self-contained

2024-03-11T09:47:06+00:00

Include  for pgprot_t.

Cc: Christian Koenig 
Cc: Huang Rui 
Acked-by: Thomas Zimmermann 
Reviewed-by: Christian König 
Reviewed-by: Alex Deucher 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/fb87ab4b4490c53e9ece66d53c4f178ead244cb5.1709898638.git.jani.nikula@intel.com

drm/ttm: fix ttm_bo.h kernel-doc warnings

2024-03-11T09:47:06+00:00

Some renames, some formatting fixes, add some missing documentation.

v3: Fix struct ttm_buffer_object .sg documentation (Christian)

Cc: Christian Koenig 
Cc: Huang Rui 
Acked-by: Thomas Zimmermann 
Reviewed-by: Christian König 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/20240308160750.3741833-1-jani.nikula@intel.com

drm/ttm: improve idle/busy handling v5

2024-03-01T16:11:16+00:00

Previously we would never try to move a BO into the preferred placements
when it ever landed in a busy placement since those were considered
compatible.

Rework the whole handling and finally unify the idle and busy handling.
ttm_bo_validate() is now responsible to try idle placement first and then
use the busy placement if that didn't worked.

Drawback is that we now always try the idle placement first for each
validation which might cause some additional CPU overhead on overcommit.

v2: fix kerneldoc warning and coding style
v3: take care of XE as well
v4: keep the ttm_bo_mem_space functionality as it is for now, only add
    new handling for ttm_bo_validate as suggested by Thomas
v5: fix bug pointed out by Matthew

Signed-off-by: Christian König 
Reviewed-by: Zack Rusin  v3
Link: https://patchwork.freedesktop.org/patch/msgid/20240229134003.3688-1-christian.koenig@amd.com
Reviewed-by: Thomas Hellström

Merge drm/drm-next into drm-misc-next

2024-01-29T13:20:23+00:00

Kickstart 6.9 development cycle.

Signed-off-by: Maxime Ripard

drm/ttm: Make sure the mapped tt pages are decrypted when needed

2024-01-26T19:10:52+00:00

Some drivers require the mapped tt pages to be decrypted. In an ideal
world this would have been handled by the dma layer, but the TTM page
fault handling would have to be rewritten to able to do that.

A side-effect of the TTM page fault handling is using a dma allocation
per order (via ttm_pool_alloc_page) which makes it impossible to just
trivially use dma_mmap_attrs. As a result ttm has to be very careful
about trying to make its pgprot for the mapped tt pages match what
the dma layer thinks it is. At the ttm layer it's possible to
deduce the requirement to have tt pages decrypted by checking
whether coherent dma allocations have been requested and the system
is running with confidential computing technologies.

This approach isn't ideal but keeping TTM matching DMAs expectations
for the page properties is in general fragile, unfortunately proper
fix would require a rewrite of TTM's page fault handling.

Fixes vmwgfx with SEV enabled.

v2: Explicitly include cc_platform.h
v3: Use CC_ATTR_GUEST_MEM_ENCRYPT instead of CC_ATTR_MEM_ENCRYPT to
limit the scope to guests and log when memory decryption is enabled.

Signed-off-by: Zack Rusin 
Fixes: 3bf3710e3718 ("drm/ttm: Add a generic TTM memcpy move for page-based iomem")
Reviewed-by: Thomas Hellström 
Acked-by: Christian König 
Cc: Huang Rui 
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Cc:  # v5.14+
Link: https://patchwork.freedesktop.org/patch/msgid/20230926040359.3040017-1-zack@kde.org

drm/ttm: replace busy placement with flags v6

2024-01-25T08:59:44+00:00

Instead of a list of separate busy placement add flags which indicate
that a placement should only be used when there is room or if we need to
evict.

v2: add missing TTM_PL_FLAG_IDLE for i915
v3: fix auto build test ERROR on drm-tip/drm-tip
v4: fix some typos pointed out by checkpatch
v5: cleanup some rebase problems with VMWGFX
v6: implement some missing VMWGFX functionality pointed out by Zack,
    rename the flags as suggested by Michel, rebase on drm-tip and
    adjust XE as well

Signed-off-by: Christian König 
Signed-off-by: Somalapuram Amaranath 
Reviewed-by: Zack Rusin 
Reviewed-by: Thomas Zimmermann 
Reviewed-by: Thomas Hellström 
Link: https://patchwork.freedesktop.org/patch/msgid/20240112125158.2748-4-christian.koenig@amd.com