linux-stable.git/include/drm/drm_print.h, branch linux-5.7.y

drm/print: clean up RATELIMITED macros

2020-02-15T13:39:35+00:00

Drop a few indirections, making the code simpler.
This also drops a RATELIMITED variant that is not in use.

Signed-off-by: Sam Ravnborg 
Reviewed-by: Daniel Vetter 
Cc: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/20200214175919.GA14492@ravnborg.org

drm/print: Delete a few unused shouting macros

2020-02-14T16:26:02+00:00

We want to go over to the new lowercase ones, encourage that a bit
more.

v2: Remove the accidentally included hunk from some WIP branch this
was based on (Jani&Sam).

Cc: Jani Nikula 
Acked-by: Jani Nikula 
Reviewed-by: Sam Ravnborg 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20200214090428.2929833-1-daniel.vetter@ffwll.ch

drm/print: introduce new struct drm_device based WARN* macros

2020-01-22T14:17:32+00:00

Add new struct drm_device based WARN* macros. These are modeled after
the core kernel device based WARN* macros. These would be preferred
over the regular WARN* macros, where possible.

These macros include device information in the backtrace, so we know
what device the warnings originate from.

Knowing the device specific information in the backtrace would be
helpful in development all around.

Signed-off-by: Pankaj Bharadiya 
Reviewed-by: Jani Nikula 
Reviewed-by: Sam Ravnborg 
Acked-by: Maxime Ripard 
Acked-by: Maarten Lankhorst 
Acked-by: Sean Paul 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/20200115034455.17658-2-pankaj.laxminarayan.bharadiya@intel.com

drm/print: introduce new struct drm_device based logging macros

2019-12-17T14:43:20+00:00

Add new struct drm_device based logging macros modeled after the core
kernel device based logging macros. These would be preferred over the
drm printk and struct device based macros in drm code, where possible.

We have existing drm specific struct device based logging functions, but
they are too verbose to use for two main reasons:

 * The names are unnecessarily long, for example DRM_DEV_DEBUG_KMS().

 * The use of struct device over struct drm_device is too generic for
   most users, leading to an extra dereference.

For example:

	DRM_DEV_DEBUG_KMS(drm->dev, "Hello, world\n");

vs.

	drm_dbg_kms(drm, "Hello, world\n");

It's a matter of taste, but the SHOUTING UPPERCASE has been argued to be
less readable than lowercase.

Some names are changed from old DRM names to be based on the core kernel
logging functions. For example, NOTE -> notice, ERROR -> err, DEBUG ->
dbg.

Due to the conflation of DRM_DEBUG and DRM_DEBUG_DRIVER macro use
(DRM_DEBUG is used widely in drivers though it's supposed to be a core
debugging category), they are named as drm_dbg_core and drm_dbg,
respectively.

The drm_err and _once/_ratelimited variants no longer include the
function name in order to be able to use the core device based logging
macros. Arguably this is not a significant change; error messages should
not be so common to be only distinguishable by the function name.

Ratelimited debug logging macros are to be added later.

Cc: Sam Ravnborg 
Acked-by: Ville Syrjälä 
Reviewed-by: Rodrigo Vivi 
Acked-by: Sean Paul 
Acked-by: Sam Ravnborg 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/20191210123050.8799-1-jani.nikula@intel.com

drm/print: group logging functions by prink or device based

2019-11-14T12:09:08+00:00

In preparation for adding struct drm_device based logging, group the
existing functions by prink or struct device based logging. No
functional changes.

Reviewed-by: Rodrigo Vivi 
Acked-by: Ville Syrjälä 
Acked-by: Sean Paul 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/51c70d80e7dd06c49ba3be56fbb6ae70edddc102.1572258936.git.jani.nikula@intel.com

drm/print: convert debug category macros into an enum

2019-11-14T12:08:57+00:00

Mostly for improved documentation, convert the debug category macros
into an enum. Drop unused DRM_UT_NONE. Document previously undocumented
categories.

Reviewed-by: Joonas Lahtinen 
Acked-by: Ville Syrjälä 
Acked-by: Sean Paul 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/96582479e7829d92b89adb805f829e23043ca85c.1572258936.git.jani.nikula@intel.com

drm/print: underscore prefix functions that should be private to print

2019-11-14T12:08:42+00:00

We don't want people calling the functions directly. No functional
changes.

Reviewed-by: Rodrigo Vivi 
Acked-by: Ville Syrjälä 
Acked-by: Sean Paul 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/6b236ed4d2e6d2987eaaeb9cb737f9c3699281cc.1572258936.git.jani.nikula@intel.com

drm/print: rename drm_debug to __drm_debug to discourage use

2019-11-14T12:08:41+00:00

drm_debug_enabled() is the way to check. __drm_debug is now reserved for
drm print code only. No functional changes.

v2: Rebase on move unlikely() to drm_debug_enabled()

Acked-by: Alex Deucher 
Reviewed-by: Eric Engestrom 
Acked-by: Ville Syrjälä 
Acked-by: Sean Paul 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/840ff7292d1a39512bac2fcb1f45de9d50694bf1.1572258936.git.jani.nikula@intel.com

drm/print: add drm_debug_enabled()

2019-10-02T13:28:55+00:00

Add helper to check if a drm debug category is enabled. Convert drm core
to use it. No functional changes.

v2: Move unlikely() to drm_debug_enabled() (Eric)

v3: Keep unlikely() when combined with other conditions (Eric)

Cc: Eric Engestrom 
Acked-by: Alex Deucher 
Reviewed-by: Eric Engestrom 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/20191001140614.26909-1-jani.nikula@intel.com

drm/print: move drm_debug variable to drm_print.[ch]

2019-10-02T13:28:24+00:00

Move drm_debug variable declaration and definition to where they are
relevant and needed. No functional changes.

Acked-by: Alex Deucher 
Reviewed-by: Eric Engestrom 
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/71a566c68883b6e6c61414cd9f7c36c84015edb1.1569329774.git.jani.nikula@intel.com