linux-stable.git/fs, branch v4.5.3

btrfs: cleaner_kthread() doesn't need explicit freeze

2016-05-04T21:49:15+00:00

commit 838fe1887765f4cc679febea60d87d2a06bd300e upstream.

cleaner_kthread() is not marked freezable, and therefore calling
try_to_freeze() in its context is a pointless no-op.

In addition to that, as has been clearly demonstrated by 80ad623edd2d
("Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()"), it's perfectly
valid / legal for cleaner_kthread() to stay scheduled out in an arbitrary
place during suspend (in that particular example that was waiting for
reading of extent pages), so there is no need to leave any traces of
freezer in this kthread.

Fixes: 80ad623edd2d ("Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()")
Fixes: 696249132158 ("btrfs: clear PF_NOFREEZE in cleaner_kthread()")
Signed-off-by: Jiri Kosina 
Signed-off-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman

btrfs: fix memory leak of fs_info in block group cache

2016-05-04T21:49:15+00:00

commit aa66b0bb08869d93492bd817d2eae694ca743a3d upstream.

When starting up linux with btrfs filesystem, I got many memory leak
messages by kmemleak as,

unreferenced object 0xffff880066882000 (size 4096):
  comm "modprobe", pid 730, jiffies 4294690024 (age 196.599s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [] kmemleak_alloc+0x4e/0xb0
    [] kmem_cache_alloc_trace+0xea/0x1e0
    [] btrfs_alloc_dummy_fs_info+0x6b/0x2a0 [btrfs]
    [] btrfs_alloc_dummy_block_group+0x5c/0x120 [btrfs]
    [] btrfs_test_free_space_cache+0x39/0xed0 [btrfs]
    [] trace_raw_output_xfs_attr_class+0x54/0xe0 [xfs]
    [] do_one_initcall+0xb2/0x1f0
    [] do_init_module+0x5e/0x1e9
    [] load_module+0x20a9/0x2690
    [] SyS_finit_module+0xb9/0xf0
    [] entry_SYSCALL_64_fastpath+0x12/0x76
    [] 0xffffffffffffffff
unreferenced object 0xffff8800573f8000 (size 10256):
  comm "modprobe", pid 730, jiffies 4294690185 (age 196.460s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [] kmemleak_alloc+0x4e/0xb0
    [] kmalloc_order+0x5e/0x70
    [] kmalloc_order_trace+0x24/0x90
    [] btrfs_alloc_dummy_fs_info+0x23/0x2a0 [btrfs]
    [] btrfs_alloc_dummy_block_group+0x5c/0x120 [btrfs]
    [] run_test+0xfd/0x320 [btrfs]
    [] btrfs_test_free_space_tree+0x94/0xee [btrfs]
    [] trace_raw_output_xfs_attr_class+0x8b/0xe0 [xfs]
    [] do_one_initcall+0xb2/0x1f0
    [] do_init_module+0x5e/0x1e9
    [] load_module+0x20a9/0x2690
    [] SyS_finit_module+0xb9/0xf0
    [] entry_SYSCALL_64_fastpath+0x12/0x76
    [] 0xffffffffffffffff

This patch lets btrfs using fs_info stored in btrfs_root for
block group cache directly without allocating a new one.

Fixes: d0bd456074 ("Btrfs: add fragment=* debug mount option")
Signed-off-by: Kinglong Mee 
Signed-off-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman

f2fs crypto: make sure the encryption info is initialized on opendir(2)

2016-05-04T21:49:13+00:00

commit ed3360abbc0412f32c398e1c58887d74f3d04225 upstream.

This patch syncs f2fs with commit 6bc445e0ff44 ("ext4 crypto: make
sure the encryption info is initialized on opendir(2)") from ext4.

Signed-off-by: Theodore Ts'o 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

f2fs crypto: handle unexpected lack of encryption keys

2016-05-04T21:49:13+00:00

commit ae1086686487f13130937918ca91d920c1daafcb upstream.

This patch syncs f2fs with commit abdd438b26b4 ("ext4 crypto: handle
unexpected lack of encryption keys") from ext4.

Fix up attempts by users to try to write to a file when they don't
have access to the encryption key.

Signed-off-by: Theodore Ts'o 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

f2fs: don't need to call set_page_dirty for io error

2016-05-04T21:49:13+00:00

commit e3ef18762f5757d3fb86f75ca59315db6d17d719 upstream.

If end_io gets an error, we don't need to set the page as dirty, since we
already set f2fs_stop_checkpoint which will not flush any data.

This will resolve the following warning.

======================================================
[ INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected ]
4.4.0+ #9 Tainted: G           O
------------------------------------------------------
xfs_io/26773 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire:
 (&(&sbi->inode_lock[i])->rlock){+.+...}, at: [] update_dirty_page+0x6f/0xd0 [f2fs]

and this task is already holding:
 (&(&q->__queue_lock)->rlock){-.-.-.}, at: [] blk_queue_bio+0x422/0x490
which would create a new lock dependency:
 (&(&q->__queue_lock)->rlock){-.-.-.} -> (&(&sbi->inode_lock[i])->rlock){+.+...}

Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

f2fs: do f2fs_balance_fs when block is allocated

2016-05-04T21:49:13+00:00

commit 3c082b7b5b28be606ed9ef11e4741df7c722c92e upstream.

We should consider data block allocation to trigger f2fs_balance_fs.

Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

ext4/fscrypto: avoid RCU lookup in d_revalidate

2016-05-04T21:49:12+00:00

commit 03a8bb0e53d9562276045bdfcf2b5de2e4cff5a1 upstream.

As Al pointed, d_revalidate should return RCU lookup before using d_inode.
This was originally introduced by:
commit 34286d666230 ("fs: rcu-walk aware d_revalidate method").

Reported-by: Al Viro 
Signed-off-by: Jaegeuk Kim 
Cc: Theodore Ts'o 
Signed-off-by: Greg Kroah-Hartman

f2fs: cover large section in sanity check of super

2016-05-04T21:49:12+00:00

commit fd694733d523df1e0a583cf5c4c08e41d7bf9fa3 upstream.

This patch fixes the bug which does not cover a large section case when checking
the sanity of superblock.
If f2fs detects misalignment, it will fix the superblock during the mount time,
so it doesn't need to trigger fsck.f2fs further.

Reported-by: Matthias Prager 
Reported-by: David Gnedt 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

f2fs: slightly reorganize read_raw_super_block

2016-05-04T21:49:12+00:00

commit 2b39e9072d79ab2525100413f3f7a0b8a3e15873 upstream.

read_raw_super_block was introduced to help find the
first valid superblock. Commit da554e48caab ("f2fs:
recovering broken superblock during mount") changed the
behaviour to read both of them and check whether need
the recovery flag or not. So the comment before this
function isn't consistent with what it actually does.
Also, the origin code use two tags to round the err
cases, which isn't so readable. So this patch amend
the comment and slightly reorganize it.

Signed-off-by: Shawn Lin 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

f2fs crypto: fix corrupted symlink in encrypted case

2016-05-04T21:49:12+00:00

commit c90e09f7fb498f81cd4e8bb6460d3a26ccebeca3 upstream.

In the encrypted symlink case, we should check its corrupted symname after
decrypting it.
Otherwise, we can report -ENOENT incorrectly, if encrypted symname starts with
'\0'.

Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman