linux-stable.git/fs, branch v4.1.44

pnfs/blocklayout: require 64-bit sector_t

2017-09-10T20:36:12+00:00

[ Upstream commit 8a9d6e964d318533ba3d2901ce153ba317c99a89 ]

The blocklayout code does not compile cleanly for a 32-bit sector_t,
and also has no reliable checks for devices sizes, which makes it
unsafe to use with a kernel that doesn't support large block devices.

Signed-off-by: Christoph Hellwig 
Reported-by: Arnd Bergmann 
Fixes: 5c83746a0cf2 ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing")
Signed-off-by: Anna Schumaker 
Signed-off-by: Sasha Levin

nfs/flexfiles: fix leak of nfs4_ff_ds_version arrays

2017-09-10T20:36:10+00:00

[ Upstream commit 1feb26162bee7b2f110facfec71b5c7bdbc7d14d ]

The client was freeing the nfs4_ff_layout_ds, but not the contained
nfs4_ff_ds_version array.

Signed-off-by: Weston Andros Adamson 
Cc: stable@vger.kernel.org # v4.0+
Signed-off-by: Anna Schumaker 
Signed-off-by: Sasha Levin

fuse: initialize the flock flag in fuse_file on allocation

2017-09-10T20:36:10+00:00

[ Upstream commit 68227c03cba84a24faf8a7277d2b1a03c8959c2c ]

Before the patch, the flock flag could remain uninitialized for the
lifespan of the fuse_file allocation. Unless set to true in
fuse_file_flock(), it would remain in an indeterminate state until read in
an if statement in fuse_release_common(). This could consequently lead to
taking an unexpected branch in the code.

The bug was discovered by a runtime instrumentation designed to detect use
of uninitialized memory in the kernel.

Signed-off-by: Mateusz Jurczyk 
Fixes: 37fb3a30b462 ("fuse: fix flock")
Cc:  # v3.1+
Signed-off-by: Miklos Szeredi 
Signed-off-by: Sasha Levin

f2fs: sanity check checkpoint segno and blkoff

2017-09-10T20:36:01+00:00

[ Upstream commit 15d3042a937c13f5d9244241c7a9c8416ff6e82a ]

Make sure segno and blkoff read from raw image are valid.

Cc: stable@vger.kernel.org
Signed-off-by: Jin Qian 
[Jaegeuk Kim: adjust minor coding style]
Signed-off-by: Jaegeuk Kim 

Signed-off-by: Sasha Levin

ext4: fix overflow caused by missing cast in ext4_resize_fs()

2017-09-10T20:36:00+00:00

[ Upstream commit aec51758ce10a9c847a62a48a168f8c804c6e053 ]

On a 32-bit platform, the value of n_blcoks_count may be wrong during
the file system is resized to size larger than 2^32 blocks.  This may
caused the superblock being corrupted with zero blocks count.

Fixes: 1c6bd7173d66
Signed-off-by: Jerry Lee 
Signed-off-by: Theodore Ts'o 
Cc: stable@vger.kernel.org # 3.7+
Signed-off-by: Sasha Levin

ext4: fix SEEK_HOLE/SEEK_DATA for blocksize < pagesize

2017-09-10T20:36:00+00:00

[ Upstream commit fcf5ea10992fbac3c7473a1db33d56a139333cd1 ]

ext4_find_unwritten_pgoff() does not properly handle a situation when
starting index is in the middle of a page and blocksize < pagesize. The
following command shows the bug on filesystem with 1k blocksize:

  xfs_io -f -c "falloc 0 4k" \
            -c "pwrite 1k 1k" \
            -c "pwrite 3k 1k" \
            -c "seek -a -r 0" foo

In this example, neither lseek(fd, 1024, SEEK_HOLE) nor lseek(fd, 2048,
SEEK_DATA) will return the correct result.

Fix the problem by neglecting buffers in a page before starting offset.

Reported-by: Andreas Gruenbacher 
Signed-off-by: Theodore Ts'o 
Signed-off-by: Jan Kara 
CC: stable@vger.kernel.org # 3.8+
Signed-off-by: Sasha Levin

Make file credentials available to the seqfile interfaces

2017-09-10T20:35:50+00:00

[ Upstream commit 34dbbcdbf63360661ff7bda6c5f52f99ac515f92 ]

A lot of seqfile users seem to be using things like %pK that uses the
credentials of the current process, but that is actually completely
wrong for filesystem interfaces.

The unix semantics for permission checking files is to check permissions
at _open_ time, not at read or write time, and that is not just a small
detail: passing off stdin/stdout/stderr to a suid application and making
the actual IO happen in privileged context is a classic exploit
technique.

So if we want to be able to look at permissions at read time, we need to
use the file open credentials, not the current ones.  Normal file
accesses can just use "f_cred" (or any of the helper functions that do
that, like file_ns_capable()), but the seqfile interfaces do not have
any such options.

It turns out that seq_file _does_ save away the user_ns information of
the file, though.  Since user_ns is just part of the full credential
information, replace that special case with saving off the cred pointer
instead, and suddenly seq_file has all the permission information it
needs.

Signed-off-by: Linus Torvalds 
Signed-off-by: Sasha Levin

udf: Fix deadlock between writeback and udf_setsize()

2017-09-10T20:35:43+00:00

[ Upstream commit f2e95355891153f66d4156bf3a142c6489cd78c6 ]

udf_setsize() called truncate_setsize() with i_data_sem held. Thus
truncate_pagecache() called from truncate_setsize() could lock a page
under i_data_sem which can deadlock as page lock ranks below
i_data_sem - e. g. writeback can hold page lock and try to acquire
i_data_sem to map a block.

Fix the problem by moving truncate_setsize() calls from under
i_data_sem. It is safe for us to change i_size without holding
i_data_sem as all the places that depend on i_size being stable already
hold inode_lock.

CC: stable@vger.kernel.org
Fixes: 7e49b6f2480cb9a9e7322a91592e56a5c85361f5
Signed-off-by: Jan Kara 
Signed-off-by: Sasha Levin

NFS: only invalidate dentrys that are clearly invalid.

2017-09-10T20:35:43+00:00

[ Upstream commit cc89684c9a265828ce061037f1f79f4a68ccd3f7 ]

Since commit bafc9b754f75 ("vfs: More precise tests in d_invalidate")
in v3.18, a return of '0' from ->d_revalidate() will cause the dentry
to be invalidated even if it has filesystems mounted on or it or on a
descendant.  The mounted filesystem is unmounted.

This means we need to be careful not to return 0 unless the directory
referred to truly is invalid.  So -ESTALE or -ENOENT should invalidate
the directory.  Other errors such a -EPERM or -ERESTARTSYS should be
returned from ->d_revalidate() so they are propagated to the caller.

A particular problem can be demonstrated by:

1/ mount an NFS filesystem using NFSv3 on /mnt
2/ mount any other filesystem on /mnt/foo
3/ ls /mnt/foo
4/ turn off network, or otherwise make the server unable to respond
5/ ls /mnt/foo &
6/ cat /proc/$!/stack # note that nfs_lookup_revalidate is in the call stack
7/ kill -9 $! # this results in -ERESTARTSYS being returned
8/ observe that /mnt/foo has been unmounted.

This patch changes nfs_lookup_revalidate() to only treat
  -ESTALE from nfs_lookup_verify_inode() and
  -ESTALE or -ENOENT from ->lookup()
as indicating an invalid inode.  Other errors are returned.

Also nfs_check_inode_attributes() is changed to return -ESTALE rather
than -EIO.  This is consistent with the error returned in similar
circumstances from nfs_update_inode().

As this bug allows any user to unmount a filesystem mounted on an NFS
filesystem, this fix is suitable for stable kernels.

Fixes: bafc9b754f75 ("vfs: More precise tests in d_invalidate")
Cc: stable@vger.kernel.org (v3.18+)
Signed-off-by: NeilBrown 
Signed-off-by: Anna Schumaker 
Signed-off-by: Sasha Levin

f2fs: Don't clear SGID when inheriting ACLs

2017-09-10T14:59:18+00:00

[ Upstream commit c925dc162f770578ff4a65ec9b08270382dba9e6 ]

This patch copies commit b7f8a09f80:
"btrfs: Don't clear SGID when inheriting ACLs" written by Jan.

Fixes: 073931017b49d9458aa351605b43a7e34598caef
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara 
Reviewed-by: Chao Yu 
Reviewed-by: Jan Kara 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Sasha Levin