linux-stable.git/fs/xfs, branch v3.5

xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks

2012-07-13T18:09:49+00:00

xfs_bdstrat_cb only adds a check for a shutdown filesystem over
xfs_buf_iorequest, but xfs_buf_iodone_callbacks just checked for a shut down
filesystem a little earlier.  In addition the shutdown handling in
xfs_bdstrat_cb is not very suitable for this caller.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Ben Myers

xfs: prevent recursion in xfs_buf_iorequest

2012-07-13T18:09:39+00:00

If the b_iodone handler is run in calling context in xfs_buf_iorequest we
can run into a recursion where xfs_buf_iodone_callbacks keeps calling back
into xfs_buf_iorequest because an I/O error happened, which keeps calling
back into xfs_buf_iorequest.  This chain will usually not take long
because the filesystem gets shut down because of log I/O errors, but even
over a short time it can cause stack overflows if run on the same context.

As a short term workaround make sure we always call the iodone handler in
workqueue context.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Ben Myers

xfs: don't defer metadata allocation to the workqueue

2012-07-13T18:09:27+00:00

Almost all metadata allocations come from shallow stack usage
situations. Avoid the overhead of switching the allocation to a
workqueue as we are not in danger of running out of stack when
making these allocations. Metadata allocations are already marked
through the args that are passed down, so this is trivial to do.

Signed-off-by: Dave Chinner 
Reported-by: Mel Gorman 
Tested-by: Mel Gorman 
Signed-off-by: Ben Myers

xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near

2012-07-13T18:09:18+00:00

The current cursor is reallocated when retrying the allocation, so
the existing cursor needs to be destroyed in both the restart and
the failure cases.

Signed-off-by: Dave Chinner 
Tested-by: Mike Snitzer 
Signed-off-by: Ben Myers

xfs: rename log structure to xlog

2012-06-21T19:21:11+00:00

Rename the XFS log structure to xlog to help crash distinquish it from the
other logs in Linux.

Signed-off-by: Mark Tinguely 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ben Myers

xfs: shutdown xfs_sync_worker before the log

2012-06-21T19:20:48+00:00

Revert commit 1307bbd, which uses the s_umount semaphore to provide
exclusion between xfs_sync_worker and unmount, in favor of shutting down
the sync worker before freeing the log in xfs_log_unmount.  This is a
cleaner way of resolving the race between xfs_sync_worker and unmount
than using s_umount.

Signed-off-by: Ben Myers 
Reviewed-by: Mark Tinguely 
Reviewed-by: Dave Chinner

xfs: Fix overallocation in xfs_buf_allocate_memory()

2012-06-21T19:20:36+00:00

Commit de1cbee which removed b_file_offset in favor of b_bn introduced a bug
causing xfs_buf_allocate_memory() to overestimate the number of necessary
pages. The problem is that xfs_buf_alloc() sets b_bn to -1 and thus effectively
every buffer is straddling a page boundary which causes
xfs_buf_allocate_memory() to allocate two pages and use vmalloc() for access
which is unnecessary.

Dave says xfs_buf_alloc() doesn't need to set b_bn to -1 anymore since the
buffer is inserted into the cache only after being fully initialized now.
So just make xfs_buf_alloc() fill in proper block number from the beginning.

CC: David Chinner 
Signed-off-by: Jan Kara 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Ben Myers

xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near

2012-06-21T19:20:20+00:00

When we fail to find an matching extent near the requested extent
specification during a left-right distance search in
xfs_alloc_ag_vextent_near, we fail to free the original cursor that
we used to look up the XFS_BTNUM_CNT tree and hence leak it.

Reported-by: Chris J Arges 
Signed-off-by: Dave Chinner 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ben Myers

xfs: check for stale inode before acquiring iflock on push

2012-06-21T19:20:06+00:00

An inode in the AIL can be flush locked and marked stale if
a cluster free transaction occurs at the right time. The
inode item is then marked as flushing, which causes xfsaild
to spin and leaves the filesystem stalled. This is
reproduced by running xfstests 273 in a loop for an
extended period of time.

Check for stale inodes before the flush lock. This marks
the inode as pinned, leads to a log flush and allows the
filesystem to proceed.

Signed-off-by: Brian Foster 
Reviewed-by: Dave Chinner 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Mark Tinguely 
Signed-off-by: Ben Myers

xfs: fix debug_object WARN at xfs_alloc_vextent()

2012-06-20T19:58:24+00:00

Fengguang reports:

[  780.529603] XFS (vdd): Ending clean mount
[  781.454590] ODEBUG: object is on stack, but not annotated
[  781.455433] ------------[ cut here ]------------
[  781.455433] WARNING: at /c/kernel-tests/sound/lib/debugobjects.c:301 __debug_object_init+0x173/0x1f1()
[  781.455433] Hardware name: Bochs
[  781.455433] Modules linked in:
[  781.455433] Pid: 26910, comm: kworker/0:2 Not tainted 3.4.0+ #51
[  781.455433] Call Trace:
[  781.455433]  [] warn_slowpath_common+0x83/0x9b
[  781.455433]  [] warn_slowpath_null+0x1a/0x1c
[  781.455433]  [] __debug_object_init+0x173/0x1f1
[  781.455433]  [] debug_object_init+0x14/0x16
[  781.455433]  [] __init_work+0x20/0x22
[  781.455433]  [] xfs_alloc_vextent+0x6c/0xd5

Use INIT_WORK_ONSTACK in xfs_alloc_vextent instead of INIT_WORK.

Reported-by: Wu Fengguang 
Signed-off-by: Jie Liu 
Signed-off-by: Ben Myers